From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
Cc: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>,
hemant.agrawal@nxp.com, nipun.gupta@nxp.com
Subject: Re: [dpdk-dev] [RFC] eventdev: add caps API and PMD callback for crypto adapter
Date: Wed, 29 Nov 2017 09:20:35 +0530 [thread overview]
Message-ID: <20171129035034.GA1810@jerin> (raw)
In-Reply-To: <1510210357-61382-1-git-send-email-abhinandan.gujjar@intel.com>
-----Original Message-----
> Date: Thu, 9 Nov 2017 12:22:37 +0530
> From: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, Abhinandan Gujjar <abhinandan.gujjar@intel.com>, Nikhil
> Rao <nikhil.rao@intel.com>
> Subject: [RFC] eventdev: add caps API and PMD callback for crypto adapter
> X-Mailer: git-send-email 1.9.1
>
> Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
Hi Abhinandan,
Thanks for the contribution. Some comments below,
> ---
> lib/librte_eventdev/rte_eventdev.c | 25 +++++++++++++++++++
> lib/librte_eventdev/rte_eventdev.h | 44 ++++++++++++++++++++++++++++++++++
> lib/librte_eventdev/rte_eventdev_pmd.h | 32 +++++++++++++++++++++++++
> 3 files changed, 101 insertions(+)
> +
> +/* Crypto Rx adapter capability bitmap flags */
> +#define RTE_EVENT_CYRPTO_ADAPTER_CAP_INTERNAL_PORT 0x1
> +/**< Flag indicates HW is capable of generating events.
> + * Cryptodev can send packets to the event device using internal event port.
> + */
> +#define RTE_EVENT_CRYPTO_ADAPTER_CAP_MULTI_EVENTQ 0x2
> +/**< Flag indicates adapter supports multiple event queues per cryptodev.
> + * Each cryptodev queue pair can be connected to a unique event queue.
> + */
> +#define RTE_EVENT_CRYPTO_ADAPTER_CAP_MBUF_MULTI_EVENTQ 0x3
The value should be 4 as it is a flag.
> +/**< Flag indicates adapter supports event queue enqueue based on mbuf metadata.
> + * Mbuf metadata will be used enqueue to unique event queue.
> + * Event information will be stored in metadata of each mbuf
> + * @see struct rte_event_crypto_adapter_mbuf_metadata
Since CPU is enqueuing the crypto ops to HW(Unlike ethdev Rx adapter,
Which is hardwired to Ingress packet Input hardware), I think, we may
NOT need RTE_EVENT_CRYPTO_ADAPTER_CAP_MULTI_EVENTQ and
RTE_EVENT_CRYPTO_ADAPTER_CAP_MBUF_MULTI_EVENTQ capabilities.
Adding NXP folks to get the comment on capabilities requirement for
their HW. If no one needs RTE_EVENT_CRYPTO_ADAPTER_CAP_MULTI_EVENTQ and
RTE_EVENT_CRYPTO_ADAPTER_CAP_MBUF_MULTI_EVENTQ then we can remove it.
Jerin
prev parent reply other threads:[~2017-11-29 3:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 6:52 Abhinandan Gujjar
2017-11-29 3:50 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129035034.GA1810@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=abhinandan.gujjar@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=nikhil.rao@intel.com \
--cc=nipun.gupta@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).