From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal/x86: get hypervisor name
Date: Thu, 30 Nov 2017 14:11:34 -0800 [thread overview]
Message-ID: <20171130141134.52068e4f@xeon-e3> (raw)
In-Reply-To: <2407814.uAEd4ZzsLf@xps>
On Thu, 30 Nov 2017 23:03:57 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:
> 30/11/2017 22:55, Stephen Hemminger:
> > On Thu, 30 Nov 2017 22:47:20 +0100
> > Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > > + for (int reg = 1; reg < 4; reg++)
> > > + memcpy(name + (reg - 1) * 4, ®s[reg], 4);
> > > + name[12] = '\0';
> >
> > C99 style declarations are not generally used in DPDK.
>
> True :)
> It will be fixed in v2.
>
> I think I should add a log somewhere at initialization in order
> to test this function.
> Do you think it deserves a table of name strings in the .h?
Same table is short-listed in util-linux (lscpu).
You might also want to handle Xen, Xen PV, VirtualBox,
Windows and WSL at some point.
next prev parent reply other threads:[~2017-11-30 22:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 21:47 Thomas Monjalon
2017-11-30 21:55 ` Stephen Hemminger
2017-11-30 22:03 ` Thomas Monjalon
2017-11-30 22:11 ` Stephen Hemminger [this message]
2017-12-01 8:12 ` Jerin Jacob
2017-12-01 8:52 ` Thomas Monjalon
2017-12-01 9:17 ` Jerin Jacob
2017-12-30 22:47 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2018-01-02 10:20 ` Jerin Jacob
2018-01-02 16:34 ` Stephen Hemminger
2018-01-03 8:11 ` Thomas Monjalon
2018-01-07 22:20 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2018-01-08 16:54 ` Stephen Hemminger
2018-01-08 18:45 ` Thomas Monjalon
2018-01-08 19:05 ` Stephen Hemminger
2018-01-11 23:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130141134.52068e4f@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).