From: Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com>
To: "Carrillo, Erik G" <erik.g.carrillo@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC PATCH v4 3/4] eventtimer: add default software implementation stub
Date: Fri, 1 Dec 2017 10:45:43 +0530 [thread overview]
Message-ID: <20171201051542.ffdokbwme46efiq2@Pavan-LT> (raw)
In-Reply-To: <BE54F058557D9A4FAC1D84E2FC6D87570ED7E9A5@fmsmsx115.amr.corp.intel.com>
On Thu, Nov 30, 2017 at 11:56:20PM +0000, Carrillo, Erik G wrote:
> Hi Pavan,
>
> Response in-line:
>
> > -----Original Message-----
> > From: Pavan Nikhilesh Bhagavatula
> > [mailto:pbhagavatula@caviumnetworks.com]
> > Sent: Wednesday, November 29, 2017 4:35 AM
> > To: Carrillo, Erik G <erik.g.carrillo@intel.com>
> > Cc: dev@dpdk.org; nipun.gupta@nxp.com; hemant.agrawal@nxp.com; Rao,
> > Nikhil <nikhil.rao@intel.com>; jerin.jacobkollanukkaran@cavium.com
> > Subject: Re: [RFC PATCH v4 3/4] eventtimer: add default software
> > implementation stub
> >
> > On Tue, Nov 28, 2017 at 11:40:07AM -0600, Erik Gabriel Carrillo wrote:
> > > If an eventdev PMD does not wish to provide event timer adapter ops
> > > definitions, the library will fall back to a default software
> > > implementation whose entry points are added by this commit.
> > >
> >
> > I do agree with having sw driver in lib/librte_eventdev as it doesn't fit
> > anywhere else, but it seems out of place maybe it would be better to
> > merged it with rte_event_timer_adapter_driver.h or in
> > rte_event_timer_adapter.c as done by eth_rx_adapter.
> >
> > Thoughts?
>
> I had also considered merging the SW driver with rte_event_timer_adapter.c but then thought it would be cleaner to separate it into its own module.
>
> But I'll make the change so that it's more like the eth rx adapter, and if the file gets too messy when we flesh out the SW driver, we can break it back out.
>
Sounds good to me.
Cheers,
Pavan
> Thanks,
> Gabriel
>
> > -Pavan
> >
> > > Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> > > ---
> > > lib/librte_eventdev/Makefile | 1 +
> > > lib/librte_eventdev/rte_event_timer_adapter.c | 14 +++
> > > lib/librte_eventdev/sw_event_timer_adapter.c | 123
> > > ++++++++++++++++++++++++++
> > > 3 files changed, 138 insertions(+)
> > > create mode 100644 lib/librte_eventdev/sw_event_timer_adapter.c
next prev parent reply other threads:[~2017-12-01 5:16 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 16:11 [dpdk-dev] [RFC PATCH 0/1] eventtimer: introduce event timer wheel Jerin Jacob
2017-08-17 16:11 ` [dpdk-dev] [RFC PATCH 1/1] " Jerin Jacob
2017-08-23 22:57 ` [dpdk-dev] [RFC PATCH 0/1] " Carrillo, Erik G
2017-08-25 10:25 ` Jerin Jacob
2017-08-29 15:02 ` Thomas Monjalon
2017-08-29 15:41 ` Jerin Jacob
2017-08-29 15:48 ` Thomas Monjalon
2017-08-29 16:07 ` Jerin Jacob
2017-09-22 15:17 ` [dpdk-dev] [RFC PATCH v2 0/1] eventtimer: introduce event timer adapter Erik Gabriel Carrillo
2017-09-22 15:17 ` [dpdk-dev] [RFC PATCH v2 1/1] " Erik Gabriel Carrillo
2017-10-03 14:37 ` [dpdk-dev] [RFC PATCH v2 0/1] " Jerin Jacob
2017-10-09 20:30 ` Carrillo, Erik G
2017-10-16 12:04 ` Pavan Nikhilesh Bhagavatula
2017-10-16 12:37 ` Pavan Nikhilesh Bhagavatula
2017-10-18 21:48 ` Carrillo, Erik G
2017-10-26 15:45 ` Pavan Nikhilesh Bhagavatula
2017-11-20 22:35 ` [dpdk-dev] [RFC PATCH v3 " Erik Gabriel Carrillo
2017-11-20 22:35 ` [dpdk-dev] [RFC PATCH v3 1/1] " Erik Gabriel Carrillo
2017-11-23 4:37 ` Pavan Nikhilesh Bhagavatula
2017-11-27 14:47 ` Carrillo, Erik G
2017-11-28 17:40 ` [dpdk-dev] [RFC PATCH v4 0/4] " Erik Gabriel Carrillo
2017-11-28 17:40 ` [dpdk-dev] [RFC PATCH v4 1/4] " Erik Gabriel Carrillo
2017-11-29 10:29 ` Pavan Nikhilesh Bhagavatula
2017-11-28 17:40 ` [dpdk-dev] [RFC PATCH v4 2/4] eventtimer: add common code Erik Gabriel Carrillo
2017-11-29 5:19 ` Pavan Nikhilesh Bhagavatula
2017-11-30 20:59 ` Carrillo, Erik G
2017-12-01 5:13 ` Pavan Nikhilesh Bhagavatula
2017-12-01 20:19 ` Carrillo, Erik G
2017-11-28 17:40 ` [dpdk-dev] [RFC PATCH v4 3/4] eventtimer: add default software implementation stub Erik Gabriel Carrillo
2017-11-29 10:34 ` Pavan Nikhilesh Bhagavatula
2017-11-30 23:56 ` Carrillo, Erik G
2017-12-01 5:15 ` Pavan Nikhilesh Bhagavatula [this message]
2017-11-28 17:40 ` [dpdk-dev] [RFC PATCH v4 4/4] test: add event timer adapter auto-test Erik Gabriel Carrillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201051542.ffdokbwme46efiq2@Pavan-LT \
--to=pbhagavatula@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).