From: Olivier MATZ <olivier.matz@6wind.com>
To: Ilya Matveychikov <matvejchikov@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mbuf: cleanup rte_pktmbuf_lastseg(), remove useless variable
Date: Fri, 1 Dec 2017 17:36:40 +0100 [thread overview]
Message-ID: <20171201163639.rduvosv6aq22ukpd@platinum> (raw)
In-Reply-To: <3DBFD712-8DA6-4FDB-B139-66398039B4C0@gmail.com>
Hi Ilya,
On Tue, Nov 14, 2017 at 05:44:49PM +0400, Ilya Matveychikov wrote:
> Fixes: af75078fece3 ("first public release")
> Cc: intel.com
The Cc tag seems wrong, should be removed.
> Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
> ---
>
> There is no reason to have local variable m2 or am I wrong?
Yes, you're right. Can you please say it in the commit log?
Thanks,
Olivier
>
> lib/librte_mbuf/rte_mbuf.h | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> index 7e326bbc2..be79e3728 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -1538,12 +1538,10 @@ static inline uint16_t rte_pktmbuf_tailroom(const struct rte_mbuf *m)
> */
> static inline struct rte_mbuf *rte_pktmbuf_lastseg(struct rte_mbuf *m)
> {
> - struct rte_mbuf *m2 = (struct rte_mbuf *)m;
> -
> __rte_mbuf_sanity_check(m, 1);
> - while (m2->next != NULL)
> - m2 = m2->next;
> - return m2;
> + while (m->next != NULL)
> + m = m->next;
> + return m;
> }
>
> /**
> --
> 2.15.0
next prev parent reply other threads:[~2017-12-01 16:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 13:44 Ilya Matveychikov
2017-11-14 20:32 ` Hanoch Haim (hhaim)
2017-11-14 20:50 ` Ilya Matveychikov
2017-12-01 16:36 ` Olivier MATZ [this message]
2017-12-09 21:08 ` [dpdk-dev] [PATCH v2] mbuf: cleanup rte_pktmbuf_lastseg function Ilya V. Matveychikov
2017-12-14 8:48 ` Olivier MATZ
2017-12-14 9:30 ` Olivier MATZ
2018-01-11 23:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201163639.rduvosv6aq22ukpd@platinum \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=matvejchikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).