From: Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com>
To: Olivier MATZ <olivier.matz@6wind.com>,
ferruh.yigit@intel.com, thomas@monjalon.net
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/3] logs: remove log level config option
Date: Thu, 7 Dec 2017 19:37:14 +0530 [thread overview]
Message-ID: <20171207140713.d6s5mh6ggncs3b3p@Pavan-LT> (raw)
In-Reply-To: <20171207132120.nwrshnurnn74qhsg@glumotte.dev.6wind.com>
Hi Oliver,
Thanks for the review.
On Thu, Dec 07, 2017 at 02:21:21PM +0100, Olivier MATZ wrote:
> On Wed, Nov 22, 2017 at 02:58:06PM +0530, Pavan Nikhilesh wrote:
> > Remove RTE_LOG_LEVEL config option, use existing RTE_LOG_DP_LEVEL config
> > option for controlling datapath log level.
> > RTE_LOG_LEVEL is no longer needed as dynamic logging can be used to
> > control global and module specific log levels.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
>
> Tome, removing the RTE_LOG_LEVEL goes in the good direction (less
> compile-time options).
>
> [...]
>
> > --- a/drivers/net/ena/base/ena_plat_dpdk.h
> > +++ b/drivers/net/ena/base/ena_plat_dpdk.h
> > @@ -96,7 +96,7 @@ typedef uint64_t dma_addr_t;
> > #define ENA_GET_SYSTEM_USECS() \
> > (rte_get_timer_cycles() * US_PER_S / rte_get_timer_hz())
> >
> > -#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
> > +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
> > #define ENA_ASSERT(cond, format, arg...) \
> > do { \
> > if (unlikely(!(cond))) { \
> > diff --git a/drivers/net/sfc/sfc_debug.h b/drivers/net/sfc/sfc_debug.h
> > index 92eba9c38..3f9ccf1e6 100644
> > --- a/drivers/net/sfc/sfc_debug.h
> > +++ b/drivers/net/sfc/sfc_debug.h
> > @@ -35,7 +35,7 @@
> > #include <rte_debug.h>
> >
> > #ifdef RTE_LIBRTE_SFC_EFX_DEBUG
> > -/* Avoid dependency from RTE_LOG_LEVEL to be able to enable debug check
> > +/* Avoid dependency from RTE_LOG_DP_LEVEL to be able to enable debug check
> > * in the driver only.
> > */
> > #define SFC_ASSERT(exp) RTE_VERIFY(exp)
> > diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c
> > index e50b1a1a8..eb78decdd 100644
> > --- a/examples/l3fwd-acl/main.c
> > +++ b/examples/l3fwd-acl/main.c
> > @@ -68,7 +68,7 @@
> > #include <rte_string_fns.h>
> > #include <rte_acl.h>
> >
> > -#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
> > +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
> > #define L3FWDACL_DEBUG
> > #endif
> > #define DO_RFC_1812_CHECKS
> > diff --git a/test/test/test.h b/test/test/test.h
> > index 08ffe949c..8fdb3045e 100644
> > --- a/test/test/test.h
> > +++ b/test/test/test.h
> > @@ -204,7 +204,7 @@ struct unit_test_case {
> >
> > #define TEST_CASES_END() { NULL, NULL, NULL, NULL, 0 }
> >
> > -#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
> > +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
> > #define TEST_HEXDUMP(file, title, buf, len) rte_hexdump(file, title, buf, len)
> > #else
> > #define TEST_HEXDUMP(file, title, buf, len) do {} while (0)
>
> For drivers, it looks correct to replace RTE_LOG_LEVEL by
> RTE_LOG_DP_LEVEL, from what I see it's about dataplane logs.
>
> For l3fwd, I'm less sure, but it could make sense too.
>
> For test, I think we should replace TEST_HEXDUMP() by a function
> that checks the runtime log level instead of relying on RTE_LOG_DP_LEVEL.
> I can submit a patch for this.
Agreed.
Pavan
>
> Olivier
next prev parent reply other threads:[~2017-12-07 14:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 9:28 [dpdk-dev] [PATCH 1/3] eal: update legacy modules dynamic logs regex Pavan Nikhilesh
2017-11-22 9:28 ` [dpdk-dev] [PATCH 2/3] eal: update default log levels Pavan Nikhilesh
2017-12-07 13:15 ` Olivier MATZ
2017-11-22 9:28 ` [dpdk-dev] [PATCH 3/3] logs: remove log level config option Pavan Nikhilesh
2017-12-07 13:21 ` Olivier MATZ
2017-12-07 14:07 ` Pavan Nikhilesh Bhagavatula [this message]
2017-12-08 15:37 ` Olivier MATZ
2017-11-22 22:57 ` [dpdk-dev] [PATCH 1/3] eal: update legacy modules dynamic logs regex Ferruh Yigit
2017-12-07 13:14 ` Olivier MATZ
2017-12-09 13:23 ` [dpdk-dev] [PATCH v2 " Pavan Nikhilesh
2017-12-09 13:23 ` [dpdk-dev] [PATCH v2 2/3] eal: update default log levels Pavan Nikhilesh
2017-12-09 13:23 ` [dpdk-dev] [PATCH v2 3/3] logs: remove log level config option Pavan Nikhilesh
2017-12-12 16:36 ` Olivier MATZ
2018-01-12 15:46 ` Thomas Monjalon
2018-01-12 15:52 ` Pavan Nikhilesh
2018-01-12 16:08 ` Thomas Monjalon
2018-01-17 13:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207140713.d6s5mh6ggncs3b3p@Pavan-LT \
--to=pbhagavatula@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).