From: Olivier MATZ <olivier.matz@6wind.com>
To: Ilya Matveychikov <matvejchikov@gmail.com>
Cc: dev@dpdk.org, "Hanoch Haim (hhaim)" <hhaim@cisco.com>,
konstantin.ananyev@intel.com
Subject: Re: [dpdk-dev] [PATCH v4] mbuf: fix mbuf free performance with non atomic refcnt
Date: Fri, 8 Dec 2017 17:19:42 +0100 [thread overview]
Message-ID: <20171208161941.7bjpif7n5kioax4n@platinum> (raw)
In-Reply-To: <60A7E7E9-91D7-48C0-BE51-D284318FD659@gmail.com>
On Fri, Dec 08, 2017 at 08:04:50PM +0400, Ilya Matveychikov wrote:
> Olivier,
>
> > On Dec 8, 2017, at 7:46 PM, Olivier Matz <olivier.matz@6wind.com> wrote:
> >
>
> >
> > lib/librte_mbuf/rte_mbuf.h | 23 ++++++++++++++++++-----
> > 1 file changed, 18 insertions(+), 5 deletions(-)
> >
> > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> > index ce8a05ddf..dd08cb72b 100644
> > --- a/lib/librte_mbuf/rte_mbuf.h
> > +++ b/lib/librte_mbuf/rte_mbuf.h
> > @@ -764,6 +764,13 @@ rte_mbuf_refcnt_set(struct rte_mbuf *m, uint16_t new_value)
> > rte_atomic16_set(&m->refcnt_atomic, new_value);
> > }
> >
> > +/* internal */
> > +static inline uint16_t
> > +__rte_mbuf_refcnt_update(struct rte_mbuf *m, int16_t value)
> > +{
> > + return (uint16_t)(rte_atomic16_add_return(&m->refcnt_atomic, value));
>
> What’s the purpose of using direct cast to uint16_t here and in other places?
This is just a code move.
Few years ago, I remember that icc was quite quick to trigger warnings when
doing implicit casts. I don't know it it's still true, but that may be the
reason why this was done like this initially, or not.
I agree we could remove this explicit cast, but I think it should go in
another patch, because there are several of them.
Olivier
next prev parent reply other threads:[~2017-12-08 16:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 9:14 [dpdk-dev] [PATCH v3] mbuf: cleanup rte_pktmbuf_lastseg(), fix atomic usage Hanoh Haim
2017-11-15 11:13 ` Ilya Matveychikov
2017-11-15 12:46 ` Hanoch Haim (hhaim)
2017-11-15 17:30 ` Olivier MATZ
2017-11-16 7:16 ` Hanoch Haim (hhaim)
2017-11-16 8:07 ` Ilya Matveychikov
2017-11-16 8:42 ` Olivier MATZ
2017-11-16 9:06 ` Hanoch Haim (hhaim)
2017-11-16 9:32 ` Ilya Matveychikov
2017-11-16 9:37 ` Olivier MATZ
2017-11-16 9:44 ` Ilya Matveychikov
2017-11-16 10:54 ` Ananyev, Konstantin
2017-12-08 15:46 ` [dpdk-dev] [PATCH v4] mbuf: fix mbuf free performance with non atomic refcnt Olivier Matz
2017-12-08 16:04 ` Ilya Matveychikov
2017-12-08 16:19 ` Olivier MATZ [this message]
2017-12-08 16:37 ` Stephen Hemminger
2017-12-10 8:37 ` Hanoch Haim (hhaim)
2017-12-11 10:28 ` Olivier MATZ
2018-01-18 23:23 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208161941.7bjpif7n5kioax4n@platinum \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=hhaim@cisco.com \
--cc=konstantin.ananyev@intel.com \
--cc=matvejchikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).