From: Jens Freimann <jfreimann@redhat.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, Yuanhan Liu <yliu@fridaylinux.org>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] vhost: fix error code check when creating pthread
Date: Mon, 11 Dec 2017 10:53:57 +0100 [thread overview]
Message-ID: <20171211095357.artnyzqvch4ine42@localhost.localdomain> (raw)
In-Reply-To: <20171208101949.1768-1-olivier.matz@6wind.com>
On Fri, Dec 08, 2017 at 11:19:49AM +0100, Olivier Matz wrote:
>On error, pthread_create() returns a positive number (errno).
>Fix the test on the return value.
>
>Fixes: af1475918124 ("vhost: introduce API to start a specific driver")
>Fixes: e623e0c6d8a5 ("vhost: add reconnect ability")
>Cc: stable@dpdk.org
>
>Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>---
> lib/librte_vhost/socket.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
>diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
>index 422da002f..811e6bf16 100644
>--- a/lib/librte_vhost/socket.c
>+++ b/lib/librte_vhost/socket.c
>@@ -472,7 +472,7 @@ vhost_user_reconnect_init(void)
>
> ret = pthread_create(&reconn_tid, NULL,
> vhost_user_client_reconnect, NULL);
>- if (ret < 0) {
>+ if (ret != 0) {
> RTE_LOG(ERR, VHOST_CONFIG, "failed to create reconnect thread");
> if (pthread_mutex_destroy(&reconn_list.mutex)) {
> RTE_LOG(ERR, VHOST_CONFIG,
>@@ -678,9 +678,8 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
> if ((flags & RTE_VHOST_USER_CLIENT) != 0) {
> vsocket->reconnect = !(flags & RTE_VHOST_USER_NO_RECONNECT);
> if (vsocket->reconnect && reconn_tid == 0) {
>- if (vhost_user_reconnect_init() < 0) {
>+ if (vhost_user_reconnect_init() != 0)
> goto out_mutex;
>- }
> }
> } else {
> vsocket->is_server = true;
>@@ -837,7 +836,7 @@ rte_vhost_driver_start(const char *path)
> if (fdset_tid == 0) {
> int ret = pthread_create(&fdset_tid, NULL, fdset_event_dispatch,
> &vhost_user.fdset);
>- if (ret < 0)
>+ if (ret != 0)
> RTE_LOG(ERR, VHOST_CONFIG,
> "failed to create fdset handling thread");
> }
Reviewed-by: Jens Freimann <jfreimann@redhat.com>
next prev parent reply other threads:[~2017-12-11 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 10:19 [dpdk-stable] " Olivier Matz
2017-12-11 9:53 ` Jens Freimann [this message]
2017-12-11 13:26 ` Maxime Coquelin
2018-01-09 13:27 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171211095357.artnyzqvch4ine42@localhost.localdomain \
--to=jfreimann@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).