DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Elza Mathew <elza.mathew@intel.com>
Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/3] hash: run-time function selection
Date: Mon, 11 Dec 2017 12:52:10 +0000	[thread overview]
Message-ID: <20171211125210.GA15784@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <1509991442-26391-1-git-send-email-elza.mathew@intel.com>

On Mon, Nov 06, 2017 at 10:04:02AM -0800, Elza Mathew wrote:
> Compile-time function selection can potentially lead to
> lower performance on generic builds done by distros.
> Replaced compile time flag checks with run-time function
> selection.
> 
> Signed-off-by: Elza Mathew <elza.mathew@intel.com>
> ---
>  lib/librte_hash/rte_cuckoo_hash.c | 10 +++++++++-
>  lib/librte_hash/rte_cuckoo_hash.h |  6 ------
>  2 files changed, 9 insertions(+), 7 deletions(-)
> 

Looks good to me.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

  reply	other threads:[~2017-12-11 12:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-06 18:04 Elza Mathew
2017-12-11 12:52 ` Bruce Richardson [this message]
2018-01-20 14:36   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171211125210.GA15784@bricha3-MOBL3.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=elza.mathew@intel.com \
    --cc=pablo.de.lara.guarch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).