From: Bruce Richardson <bruce.richardson@intel.com>
To: Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] test/test: introduce new test-case for rte_smp_mb()
Date: Mon, 11 Dec 2017 17:08:34 +0000 [thread overview]
Message-ID: <20171211170834.GA2232@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <1512126771-27503-1-git-send-email-konstantin.ananyev@intel.com>
On Fri, Dec 01, 2017 at 11:12:50AM +0000, Konstantin Ananyev wrote:
> Simple functional test for rte_smp_mb() implementations.
> Also when executed on a single lcore could be used as rough
> estimation how many cycles particular implementation of rte_smp_mb()
> might take.
>
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> ---
> test/test/Makefile | 1 +
> test/test/test_mb.c | 278 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 279 insertions(+)
> create mode 100644 test/test/test_mb.c
>
First pass comment on this patch is that it really could do with some
comments explaining what is happening and why. Although it's meant to be
a "simple functional test", it doesn't appear to be so on first reading,
without comments as to how the test is meant to work and what the
expected output values are.
/Bruce
prev parent reply other threads:[~2017-12-11 17:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 11:12 Konstantin Ananyev
2017-12-01 11:12 ` [dpdk-dev] [PATCH 2/2] eal/x86: Use lock-prefixed instructions to reduce cost of rte_smp_mb() Konstantin Ananyev
2017-12-01 18:04 ` Stephen Hemminger
2017-12-01 23:08 ` Ananyev, Konstantin
2018-03-08 21:15 ` Stephen Hemminger
2017-12-11 17:11 ` Bruce Richardson
2017-12-11 17:30 ` Ananyev, Konstantin
2017-12-18 15:34 ` [dpdk-dev] [PATCH v2 0/2] eal/x86: Optimize rte_smp_mb() and create a new test case for it Konstantin Ananyev
2017-12-18 15:34 ` [dpdk-dev] [PATCH v2 1/2] test/test: introduce new test-case for rte_smp_mb() Konstantin Ananyev
2018-01-12 17:23 ` Thomas Monjalon
2018-01-12 17:58 ` Ananyev, Konstantin
2018-01-13 13:54 ` Wiles, Keith
2018-01-13 13:54 ` Wiles, Keith
2018-01-15 15:04 ` [dpdk-dev] [PATCH v3 0/2] eal/x86: Optimize rte_smp_mb() and create a new test case for it Konstantin Ananyev
2018-01-15 15:04 ` [dpdk-dev] [PATCH v3 1/2] test/test: introduce new test-case for rte_smp_mb() Konstantin Ananyev
2018-01-16 0:16 ` Thomas Monjalon
2018-01-15 15:04 ` [dpdk-dev] [PATCH v3 2/2] eal/x86: Use lock-prefixed instructions to reduce cost of rte_smp_mb() Konstantin Ananyev
2018-01-15 15:09 ` Konstantin Ananyev
[not found] ` <8b05f533-d146-7f97-48f4-82ddcfc3613b@redhat.com>
2018-01-16 1:54 ` [dpdk-dev] Fwd: " Michael S. Tsirkin
2018-01-29 9:29 ` Ananyev, Konstantin
2018-01-29 17:29 ` Michael S. Tsirkin
2018-01-29 15:47 ` [dpdk-dev] " Thomas Monjalon
2018-01-30 19:33 ` Stephen Hemminger
2017-12-18 15:34 ` [dpdk-dev] [PATCH v2 " Konstantin Ananyev
2017-12-18 15:46 ` Bruce Richardson
2017-12-11 17:08 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171211170834.GA2232@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).