From: Olivier MATZ <olivier.matz@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Ajit Khaparde <ajit.khaparde@broadcom.com>,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH 1/2] net/bnxt: fix headroom initialization
Date: Sat, 16 Dec 2017 18:25:04 +0100 [thread overview]
Message-ID: <20171216172502.kd2ngzl6moqfzhv5@platinum> (raw)
In-Reply-To: <5f0b6b54-9813-b03f-47ed-c10e49cb3d44@intel.com>
Hi Ferruh,
On Fri, Dec 15, 2017 at 06:30:58PM -0800, Ferruh Yigit wrote:
> On 12/14/2017 6:28 AM, Olivier Matz wrote:
> > When allocating a new mbuf for Rx, the value of m->data_off should not
> > be reset to its default value (RTE_PKTMBUF_HEADROOM), instead of reusing
> > the previous undefined value, which could cause the packet to have a too
> > small or too high headroom.
> >
> > Fixes: 2eb53b134aae ("net/bnxt: add initial Rx code")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > ---
> > drivers/net/bnxt/bnxt_rxr.c | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
> > index 188df362e..3fff4d437 100644
> > --- a/drivers/net/bnxt/bnxt_rxr.c
> > +++ b/drivers/net/bnxt/bnxt_rxr.c
> > @@ -75,7 +75,7 @@ static inline int bnxt_alloc_rx_data(struct bnxt_rx_queue *rxq,
> >
> > rx_buf->mbuf = data;
> >
> > - rxbd->addr = rte_cpu_to_le_64(RTE_MBUF_DATA_DMA_ADDR(rx_buf->mbuf));
> > + rxbd->addr = rte_cpu_to_le_64(rte_mbuf_data_dma_addr_default(data));
>
> Hi Olivier,
>
> Using deprecated rte_mbuf_data_dma_addr_default() breaks build for this commit.
>
> What do you think using directly rte_mbuf_data_iova_default() in this patch?
No problem. It was initially split in 2 patches to ease the backport for
stable versions.
next prev parent reply other threads:[~2017-12-16 17:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 14:28 Olivier Matz
2017-12-14 17:47 ` Ajit Khaparde
2017-12-16 2:30 ` Ferruh Yigit
2017-12-16 17:25 ` Olivier MATZ [this message]
[not found] ` <20180103103225.7120-1-olivier.matz@6wind.com>
2018-01-03 10:32 ` [dpdk-stable] [PATCH v2 2/2] " Olivier Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171216172502.kd2ngzl6moqfzhv5@platinum \
--to=olivier.matz@6wind.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).