From: Bruce Richardson <bruce.richardson@intel.com>
To: Harry van Haaren <harry.van.haaren@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] test: use env variable to run test if set
Date: Mon, 18 Dec 2017 13:50:38 +0000 [thread overview]
Message-ID: <20171218135037.GA15444@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <1513598038-148115-2-git-send-email-harry.van.haaren@intel.com>
On Mon, Dec 18, 2017 at 11:53:57AM +0000, Harry van Haaren wrote:
> This commit paves the way for the meson tests in the next
> patch. With this patch the test binary checks the DPDK_TEST
> environment variable and if set, the contents of the var
> are inserted on the test app command line, and run.
>
> This allows testing of various different unit tests without
> manual interaction with the RTE>> test prompt, instead automating
> it using the DPDK_TEST environment variable.
>
> If the DPDK_TEST env variable is not set, or has zero lenght,
> the test app behaves as normal.
>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> ---
This is very useful, even without the meson test part added in the next
patch.
Probably a matter of personal taste, but I think I would prefer to see
the tests to be run specified as args on the cmdline rather than passed
through the environment. I'd tend to view environment variables as
things to use for long-lasting values, rather than parameters you might
want to change between each run. Using cmdline args would also save you
having to split commands, since you'd get the list pre-split in
argv.
/Bruce
next prev parent reply other threads:[~2017-12-18 13:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 11:53 [dpdk-dev] [PATCH 0/2] next-build: add test app to build Harry van Haaren
2017-12-18 11:53 ` [dpdk-dev] [PATCH 1/2] test: use env variable to run test if set Harry van Haaren
2017-12-18 13:50 ` Bruce Richardson [this message]
2017-12-18 14:59 ` Jerin Jacob
2017-12-18 15:24 ` Van Haaren, Harry
2017-12-18 15:41 ` Jerin Jacob
2017-12-18 11:53 ` [dpdk-dev] [PATCH 2/2] meson: add tests app to build Harry van Haaren
2017-12-18 13:55 ` Bruce Richardson
2017-12-18 15:24 ` Van Haaren, Harry
2017-12-20 10:23 ` Bruce Richardson
2017-12-18 13:57 ` [dpdk-dev] [PATCH 0/2] next-build: add test " Bruce Richardson
2017-12-18 15:24 ` Van Haaren, Harry
2017-12-20 11:16 ` [dpdk-dev] [PATCH v2 " Harry van Haaren
2017-12-20 11:16 ` [dpdk-dev] [PATCH v2 1/2] test: use env variable to run test if set Harry van Haaren
2017-12-20 11:47 ` Bruce Richardson
2017-12-20 11:16 ` [dpdk-dev] [PATCH v2 2/2] meson: add tests app to build Harry van Haaren
2017-12-20 11:57 ` Laatz, Kevin
2017-12-20 12:00 ` Bruce Richardson
2017-12-20 12:20 ` Bruce Richardson
2017-12-20 12:22 ` [dpdk-dev] [PATCH v2 0/2] next-build: add test " Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171218135037.GA15444@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).