From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
To: santosh <santosh.shukla@caviumnetworks.com>, ferruh.yigit@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/octeontx: add channel to port id mapping
Date: Tue, 19 Dec 2017 03:22:27 +0530 [thread overview]
Message-ID: <20171218215226.ls5s2jjziaquzbbl@Pavan-LT> (raw)
In-Reply-To: <ae3b7e88-a768-abeb-197c-8d455a9204f3@caviumnetworks.com>
On Mon, Dec 18, 2017 at 03:11:15PM +0530, santosh wrote:
>
> On Saturday 09 December 2017 06:25 PM, Pavan Nikhilesh wrote:
> > The channel to port id map is used by event octeontx to map the received
> > wqe to the respective ethdev port.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
> >
> > v2 changes:
> > - Used extern instead of defining global variable
> >
> > drivers/net/octeontx/octeontx_ethdev.c | 6 ++++++
> > drivers/net/octeontx/octeontx_ethdev.h | 6 ++++++
> > drivers/net/octeontx/rte_pmd_octeontx_version.map | 6 ++++++
> > 3 files changed, 18 insertions(+)
> >
> > diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c
> > index bd24ec330..46cb061b4 100644
> > --- a/drivers/net/octeontx/octeontx_ethdev.c
> > +++ b/drivers/net/octeontx/octeontx_ethdev.c
> > @@ -54,6 +54,9 @@ struct octeontx_vdev_init_params {
> > uint8_t nr_port;
> > };
> >
> > +uint16_t
> > +octeontx_pchan_map[OCTEONTX_MAX_BGX_PORTS][OCTEONTX_MAX_LMAC_PER_BGX];
> > +
> > enum octeontx_link_speed {
> > OCTEONTX_LINK_SPEED_SGMII,
> > OCTEONTX_LINK_SPEED_XAUI,
> > @@ -1133,6 +1136,9 @@ octeontx_create(struct rte_vdev_device *dev, int port, uint8_t evdev,
> > nic->num_tx_queues);
> > PMD_INIT_LOG(DEBUG, "speed %d mtu %d", nic->speed, nic->mtu);
> >
> > + octeontx_pchan_map[(nic->base_ochan >> 8) & 0x7]
> > + [(nic->base_ochan >> 4) & 0xF] = data->port_id;
> > +
> > return data->port_id;
> >
> > err:
> > diff --git a/drivers/net/octeontx/octeontx_ethdev.h b/drivers/net/octeontx/octeontx_ethdev.h
> > index c47d4c6d3..f046595a8 100644
> > --- a/drivers/net/octeontx/octeontx_ethdev.h
> > +++ b/drivers/net/octeontx/octeontx_ethdev.h
> > @@ -52,12 +52,18 @@
> > #define OCTEONTX_VDEV_NR_PORT_ARG ("nr_port")
> > #define OCTEONTX_MAX_NAME_LEN 32
> >
> > +#define OCTEONTX_MAX_BGX_PORTS 4
> > +#define OCTEONTX_MAX_LMAC_PER_BGX 4
> > +
> > static inline struct octeontx_nic *
> > octeontx_pmd_priv(struct rte_eth_dev *dev)
> > {
> > return dev->data->dev_private;
> > }
> >
> > +extern uint16_t
> > +octeontx_pchan_map[OCTEONTX_MAX_BGX_PORTS][OCTEONTX_MAX_LMAC_PER_BGX];
> > +
> > /* Octeontx ethdev nic */
> > struct octeontx_nic {
> > struct rte_eth_dev *dev;
> > diff --git a/drivers/net/octeontx/rte_pmd_octeontx_version.map b/drivers/net/octeontx/rte_pmd_octeontx_version.map
> > index a70bd197b..3ec12ddb1 100644
> > --- a/drivers/net/octeontx/rte_pmd_octeontx_version.map
> > +++ b/drivers/net/octeontx/rte_pmd_octeontx_version.map
> > @@ -2,3 +2,9 @@ DPDK_17.11 {
> >
> > local: *;
> > };
> > +
> > +DPDK_18.04 {
> > + global:
> > +
> > + octeontx_pchan_map;
> > +};
>
> nits: better be rte_octeontx_pchan_map
> refer http://dpdk.org/browse/dpdk/tree/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map#n4
>
> Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
>
Thanks for the review and ack, will send out v3 fixing the name.
Pavan.
>
next prev parent reply other threads:[~2017-12-18 21:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 14:58 [dpdk-dev] [PATCH " Pavan Nikhilesh
2017-11-28 14:58 ` [dpdk-dev] [PATCH 2/2] event/octeontx: fix Rx adapter " Pavan Nikhilesh
2017-12-08 0:41 ` [dpdk-dev] [PATCH 1/2] net/octeontx: add channel to " Ferruh Yigit
2017-12-08 11:08 ` Pavan Nikhilesh Bhagavatula
2017-12-08 17:39 ` Ferruh Yigit
2017-12-09 9:25 ` Pavan Nikhilesh Bhagavatula
2017-12-09 12:55 ` [dpdk-dev] [PATCH v2 " Pavan Nikhilesh
2017-12-09 12:55 ` [dpdk-dev] [PATCH v2 2/2] event/octeontx: fix Rx adapter " Pavan Nikhilesh
2017-12-18 9:43 ` santosh
2017-12-18 9:41 ` [dpdk-dev] [PATCH v2 1/2] net/octeontx: add channel to " santosh
2017-12-18 21:52 ` Pavan Nikhilesh [this message]
2017-12-19 18:01 ` [dpdk-dev] [PATCH v3 " Pavan Nikhilesh
2017-12-19 18:01 ` [dpdk-dev] [PATCH v3 2/2] event/octeontx: fix Rx adapter " Pavan Nikhilesh
2018-01-09 12:47 ` [dpdk-dev] [PATCH v3 1/2] net/octeontx: add channel to " Ferruh Yigit
2018-01-09 12:49 ` Ferruh Yigit
2018-01-10 7:59 ` Pavan Nikhilesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171218215226.ls5s2jjziaquzbbl@Pavan-LT \
--to=pbhagavatula@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=santosh.shukla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).