From: Bruce Richardson <bruce.richardson@intel.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Doherty, Declan" <declan.doherty@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] test/test: add return value to mark unit tests as skipped
Date: Thu, 21 Dec 2017 12:21:09 +0000 [thread overview]
Message-ID: <20171221122109.GA8256@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA650FE4B63@IRSMSX102.ger.corp.intel.com>
On Thu, Dec 21, 2017 at 10:48:22AM +0000, Van Haaren, Harry wrote:
> > From: Richardson, Bruce
> > Sent: Thursday, December 21, 2017 10:23 AM
> > To: dev@dpdk.org; Doherty, Declan <declan.doherty@intel.com>; De Lara
> > Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> > Cc: Van Haaren, Harry <harry.van.haaren@intel.com>
> > Subject: Re: [PATCH 2/2] test/test: add return value to mark unit tests as
> > skipped
> >
> > On Thu, Dec 21, 2017 at 10:15:10AM +0000, Bruce Richardson wrote:
> > > Add in a TEST_SKIPPED return value for unit tests to mark the tests
> > > as skipped, rather than just failed. Use this new skipped return value for
> > > the crypto tests which can only run if they have a particular driver.
> > >
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> > +Declan and Pablo as maintainers of crypto code.
>
> Looks good to me, checked unit tests using old build system and binary, but 2nd Ack from crypto maintainers welcome :)
>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Following IRC discussion this set is now superceded by a new set
targeting these changes at the main tree.
http://dpdk.org/dev/patchwork/patch/32560/
http://dpdk.org/dev/patchwork/patch/32561/
Patchwork has been updated to reflect this.
/Bruce
prev parent reply other threads:[~2017-12-21 12:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 10:15 [dpdk-dev] [PATCH 0/2] improve meson test support Bruce Richardson
2017-12-21 10:15 ` [dpdk-dev] [PATCH 1/2] test/test: fix missed failures when running meson test Bruce Richardson
2017-12-21 10:44 ` Van Haaren, Harry
2017-12-21 10:15 ` [dpdk-dev] [PATCH 2/2] test/test: add return value to mark unit tests as skipped Bruce Richardson
2017-12-21 10:22 ` Bruce Richardson
2017-12-21 10:48 ` Van Haaren, Harry
2017-12-21 12:21 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171221122109.GA8256@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).