From: Neil Horman <nhorman@tuxdriver.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com,
gage.eads@intel.com, liang.j.ma@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 04/11] event/octeontx: modify octeontx eventdev test
Date: Tue, 26 Dec 2017 09:11:56 -0500 [thread overview]
Message-ID: <20171226141156.GB15284@neilslaptop.think-freely.org> (raw)
In-Reply-To: <20171225191738.17151-4-pbhagavatula@caviumnetworks.com>
On Tue, Dec 26, 2017 at 12:47:31AM +0530, Pavan Nikhilesh wrote:
> Modify test_eventdev_octeontx to be standalone selftest independent of
> test framework.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
> drivers/event/octeontx/octeontx_evdev_selftest.c | 427 +++++++++++++----------
> 1 file changed, 234 insertions(+), 193 deletions(-)
>
> diff --git a/drivers/event/octeontx/octeontx_evdev_selftest.c b/drivers/event/octeontx/octeontx_evdev_selftest.c
> index 8fddb4fd2..3877bca4a 100644
> --- a/drivers/event/octeontx/octeontx_evdev_selftest.c
> +++ b/drivers/event/octeontx/octeontx_evdev_selftest.c
> @@ -46,12 +46,21 @@
> #include <rte_per_lcore.h>
> #include <rte_random.h>
> #include <rte_bus_vdev.h>
> +#include <rte_test.h>
>
> -#include "test.h"
> +#include "ssovf_evdev.h"
>
> #define NUM_PACKETS (1 << 18)
> #define MAX_EVENTS (16 * 1024)
>
> +#define OCTEONTX_TEST_RUN(setup, teardown, test) \
> + octeontx_test_run(setup, teardown, test, #test)
> +
> +static int total;
> +static int passed;
> +static int failed;
> +static int unsupported;
> +
> static int evdev;
> static struct rte_mempool *eventdev_test_mempool;
>
> @@ -79,11 +88,11 @@ static inline int
> seqn_list_update(int val)
> {
> if (seqn_list_index >= NUM_PACKETS)
> - return TEST_FAILED;
> + return -1;
>
> seqn_list[seqn_list_index++] = val;
> rte_smp_wmb();
> - return TEST_SUCCESS;
> + return 0;
> }
>
> static inline int
> @@ -93,11 +102,11 @@ seqn_list_check(int limit)
>
> for (i = 0; i < limit; i++) {
> if (seqn_list[i] != i) {
> - printf("Seqn mismatch %d %d\n", seqn_list[i], i);
> - return TEST_FAILED;
> + ssovf_log_dbg("Seqn mismatch %d %d", seqn_list[i], i);
> + return -1;
> }
> }
> - return TEST_SUCCESS;
> + return 0;
> }
>
> struct test_core_param {
> @@ -114,20 +123,21 @@ testsuite_setup(void)
>
> evdev = rte_event_dev_get_dev_id(eventdev_name);
> if (evdev < 0) {
> - printf("%d: Eventdev %s not found - creating.\n",
> + ssovf_log_dbg("%d: Eventdev %s not found - creating.",
> __LINE__, eventdev_name);
> if (rte_vdev_init(eventdev_name, NULL) < 0) {
> - printf("Error creating eventdev %s\n", eventdev_name);
> - return TEST_FAILED;
> + ssovf_log_dbg("Error creating eventdev %s",
> + eventdev_name);
> + return -1;
> }
> evdev = rte_event_dev_get_dev_id(eventdev_name);
> if (evdev < 0) {
> - printf("Error finding newly created eventdev\n");
> - return TEST_FAILED;
> + ssovf_log_dbg("Error finding newly created eventdev");
> + return -1;
> }
> }
>
> - return TEST_SUCCESS;
> + return 0;
> }
>
> static void
> @@ -177,31 +187,34 @@ _eventdev_setup(int mode)
> 512, /* Use very small mbufs */
> rte_socket_id());
> if (!eventdev_test_mempool) {
> - printf("ERROR creating mempool\n");
> - return TEST_FAILED;
> + ssovf_log_dbg("ERROR creating mempool");
> + return -1;
> }
>
> ret = rte_event_dev_info_get(evdev, &info);
> - TEST_ASSERT_SUCCESS(ret, "Failed to get event dev info");
> - TEST_ASSERT(info.max_num_events >= (int32_t)MAX_EVENTS,
> - "max_num_events=%d < max_events=%d",
> - info.max_num_events, MAX_EVENTS);
> + RTE_TEST_ASSERT_SUCCESS(ret, "Failed to get event dev info");
> + if (!(info.max_num_events >= (int32_t)MAX_EVENTS)) {
> + ssovf_log_dbg("ERROR max_num_events=%d < max_events=%d",
> + info.max_num_events, MAX_EVENTS);
> + return -1;
> + }
>
I'm not sure how any of this is particularly adventageous. You've replaced two
ASSERTION macros with one and an additional conditional. The assert macros are
just a flexible as their were previously (which is to say, not overly so). So
i'm not sure what the advantage of renaming them is.
Neil
next prev parent reply other threads:[~2017-12-26 14:12 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 19:27 [dpdk-dev] [PATCH 1/7] event/octeontx: move eventdev octeontx test to driver Pavan Nikhilesh
2017-12-12 19:27 ` [dpdk-dev] [PATCH 2/7] event/octeontx: modify octeontx eventdev test Pavan Nikhilesh
2017-12-12 19:27 ` [dpdk-dev] [PATCH 3/7] event/octeontx: add selftest to device arguments Pavan Nikhilesh
2017-12-12 19:27 ` [dpdk-dev] [PATCH 4/7] event/sw: move eventdev sw test to driver Pavan Nikhilesh
2017-12-13 10:22 ` Van Haaren, Harry
2017-12-12 19:27 ` [dpdk-dev] [PATCH 5/7] event/sw: modify eventdev sw test Pavan Nikhilesh
2017-12-12 19:27 ` [dpdk-dev] [PATCH 6/7] event/sw: add selftest to device arguments Pavan Nikhilesh
2017-12-12 19:27 ` [dpdk-dev] [PATCH 7/7] doc: update eventdev documentation Pavan Nikhilesh
2017-12-13 13:48 ` Kovacevic, Marko
2017-12-13 10:19 ` [dpdk-dev] [PATCH 1/7] event/octeontx: move eventdev octeontx test to driver Van Haaren, Harry
2017-12-13 10:34 ` Bruce Richardson
2017-12-13 11:24 ` Pavan Nikhilesh Bhagavatula
2017-12-13 11:39 ` Bruce Richardson
2017-12-13 11:19 ` Pavan Nikhilesh Bhagavatula
2017-12-13 11:41 ` Bruce Richardson
2017-12-13 15:50 ` Pavan Nikhilesh Bhagavatula
2017-12-14 15:01 ` [dpdk-dev] [PATCH v2 00/11] eventdev: move eventdev pmd specific tests into the pmd dir Pavan Nikhilesh
2017-12-14 15:01 ` [dpdk-dev] [PATCH v2 01/11] eal: add common test assert macros Pavan Nikhilesh
2017-12-14 18:43 ` Ananyev, Konstantin
2017-12-15 9:04 ` Pavan Nikhilesh Bhagavatula
2017-12-15 10:58 ` Ananyev, Konstantin
2017-12-15 11:32 ` Pavan Nikhilesh Bhagavatula
2018-01-10 19:16 ` Jerin Jacob
2018-01-10 20:18 ` Thomas Monjalon
2017-12-14 15:01 ` [dpdk-dev] [PATCH v2 02/11] eventdev: add API to perform self test Pavan Nikhilesh
2017-12-19 15:45 ` Van Haaren, Harry
2017-12-14 15:01 ` [dpdk-dev] [PATCH v2 03/11] event/octeontx: move eventdev octeontx test to driver Pavan Nikhilesh
2017-12-14 15:01 ` [dpdk-dev] [PATCH v2 04/11] event/octeontx: modify octeontx eventdev test Pavan Nikhilesh
2017-12-14 15:01 ` [dpdk-dev] [PATCH v2 05/11] event/octeontx: update octeontx eventdev selftest ops Pavan Nikhilesh
2017-12-14 15:01 ` [dpdk-dev] [PATCH v2 06/11] event/octeontx: add selftest to device arguments Pavan Nikhilesh
2017-12-14 15:01 ` [dpdk-dev] [PATCH v2 07/11] event/sw: move eventdev software test to driver Pavan Nikhilesh
2017-12-14 15:01 ` [dpdk-dev] [PATCH v2 08/11] event/sw: modify eventdev software test Pavan Nikhilesh
2017-12-19 15:44 ` Van Haaren, Harry
2017-12-14 15:01 ` [dpdk-dev] [PATCH v2 09/11] event/sw: update software eventdev selftest ops Pavan Nikhilesh
2017-12-19 15:46 ` Van Haaren, Harry
2017-12-14 15:01 ` [dpdk-dev] [PATCH v2 10/11] test: register eventdev selftest Pavan Nikhilesh
2017-12-19 15:27 ` Van Haaren, Harry
2017-12-19 18:44 ` Pavan Nikhilesh
2017-12-20 11:07 ` Van Haaren, Harry
2017-12-14 15:01 ` [dpdk-dev] [PATCH v2 11/11] doc: update eventdev documentation Pavan Nikhilesh
2017-12-25 19:17 ` [dpdk-dev] [PATCH v3 01/11] eal: add common test assert macros Pavan Nikhilesh
2017-12-25 19:17 ` [dpdk-dev] [PATCH v3 02/11] eventdev: add API to perform self test Pavan Nikhilesh
2018-01-08 9:56 ` Jerin Jacob
2018-01-08 10:34 ` Pavan Nikhilesh
2017-12-25 19:17 ` [dpdk-dev] [PATCH v3 03/11] event/octeontx: move eventdev octeontx test to driver Pavan Nikhilesh
2018-01-08 9:58 ` Jerin Jacob
2017-12-25 19:17 ` [dpdk-dev] [PATCH v3 04/11] event/octeontx: modify octeontx eventdev test Pavan Nikhilesh
2017-12-26 14:11 ` Neil Horman [this message]
2017-12-27 5:18 ` Pavan Nikhilesh
2017-12-25 19:17 ` [dpdk-dev] [PATCH v3 05/11] event/octeontx: update octeontx eventdev selftest ops Pavan Nikhilesh
2018-01-08 10:09 ` Jerin Jacob
2017-12-25 19:17 ` [dpdk-dev] [PATCH v3 06/11] event/octeontx: add selftest to device arguments Pavan Nikhilesh
2018-01-08 10:14 ` Jerin Jacob
2017-12-25 19:17 ` [dpdk-dev] [PATCH v3 07/11] event/sw: move eventdev software test to driver Pavan Nikhilesh
2017-12-25 19:17 ` [dpdk-dev] [PATCH v3 08/11] event/sw: modify eventdev software test Pavan Nikhilesh
2017-12-25 19:17 ` [dpdk-dev] [PATCH v3 09/11] event/sw: update software eventdev selftest ops Pavan Nikhilesh
2017-12-25 19:17 ` [dpdk-dev] [PATCH v3 10/11] test: register eventdev selftest Pavan Nikhilesh
2018-01-08 9:49 ` Jerin Jacob
2017-12-25 19:17 ` [dpdk-dev] [PATCH v3 11/11] doc: update eventdev documentation Pavan Nikhilesh
2018-01-08 11:17 ` [dpdk-dev] [PATCH v3 01/11] eal: add common test assert macros Jerin Jacob
2018-01-08 13:47 ` [dpdk-dev] [PATCH v4 " Pavan Nikhilesh
2018-01-08 13:47 ` [dpdk-dev] [PATCH v4 02/11] eventdev: add API to perform self test Pavan Nikhilesh
2018-01-08 13:47 ` [dpdk-dev] [PATCH v4 03/11] event/octeontx: move eventdev octeontx test to driver Pavan Nikhilesh
2018-01-08 13:47 ` [dpdk-dev] [PATCH v4 04/11] event/octeontx: modify octeontx eventdev test Pavan Nikhilesh
2018-01-08 13:47 ` [dpdk-dev] [PATCH v4 05/11] event/octeontx: update octeontx eventdev selftest ops Pavan Nikhilesh
2018-01-08 13:47 ` [dpdk-dev] [PATCH v4 06/11] event/octeontx: add selftest to device arguments Pavan Nikhilesh
2018-01-08 13:47 ` [dpdk-dev] [PATCH v4 07/11] event/sw: move eventdev software test to driver Pavan Nikhilesh
2018-01-08 13:47 ` [dpdk-dev] [PATCH v4 08/11] event/sw: modify eventdev software test Pavan Nikhilesh
2018-01-08 13:47 ` [dpdk-dev] [PATCH v4 09/11] event/sw: update software eventdev selftest ops Pavan Nikhilesh
2018-01-08 13:47 ` [dpdk-dev] [PATCH v4 10/11] test: register eventdev selftest Pavan Nikhilesh
2018-01-08 13:47 ` [dpdk-dev] [PATCH v4 11/11] doc: update eventdev documentation Pavan Nikhilesh
2018-01-10 20:20 ` [dpdk-dev] [PATCH v4 01/11] eal: add common test assert macros Thomas Monjalon
2018-01-11 7:11 ` Pavan Nikhilesh
2018-01-11 10:21 ` [dpdk-dev] [PATCH v5 " Pavan Nikhilesh
2018-01-11 10:21 ` [dpdk-dev] [PATCH v5 02/11] eventdev: add API to perform self test Pavan Nikhilesh
2018-01-11 10:21 ` [dpdk-dev] [PATCH v5 03/11] event/octeontx: move eventdev octeontx test to driver Pavan Nikhilesh
2018-01-11 10:21 ` [dpdk-dev] [PATCH v5 04/11] event/octeontx: modify octeontx eventdev test Pavan Nikhilesh
2018-01-11 10:21 ` [dpdk-dev] [PATCH v5 05/11] event/octeontx: update octeontx eventdev selftest ops Pavan Nikhilesh
2018-01-11 10:21 ` [dpdk-dev] [PATCH v5 06/11] event/octeontx: add selftest to device arguments Pavan Nikhilesh
2018-01-11 10:21 ` [dpdk-dev] [PATCH v5 07/11] event/sw: move eventdev software test to driver Pavan Nikhilesh
2018-01-11 10:21 ` [dpdk-dev] [PATCH v5 08/11] event/sw: modify eventdev software test Pavan Nikhilesh
2018-01-11 10:21 ` [dpdk-dev] [PATCH v5 09/11] event/sw: update software eventdev selftest ops Pavan Nikhilesh
2018-01-11 10:21 ` [dpdk-dev] [PATCH v5 10/11] test: register eventdev selftest Pavan Nikhilesh
2018-01-11 10:21 ` [dpdk-dev] [PATCH v5 11/11] doc: update eventdev documentation Pavan Nikhilesh
2018-01-11 11:27 ` Jerin Jacob
2018-01-11 10:29 ` [dpdk-dev] [PATCH v5 01/11] eal: add common test assert macros Pavan Nikhilesh
2018-01-11 10:44 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171226141156.GB15284@neilslaptop.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=liang.j.ma@intel.com \
--cc=pbhagavatula@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).