DPDK patches and discussions
 help / color / mirror / Atom feed
From: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
To: Qi Zhang <qi.z.zhang@intel.com>
Cc: adrien.mazarguil@6wind.com, dev@dpdk.org, declan.doherty@intel.com
Subject: Re: [dpdk-dev] [RFC 0/5] rte_flow extension for vSwitch acceleration
Date: Tue, 2 Jan 2018 09:12:55 +0100	[thread overview]
Message-ID: <20180102081255.fivvu5apxry6ntsx@laranjeiro-vm.dev.6wind.com> (raw)
In-Reply-To: <1513805689-28202-1-git-send-email-qi.z.zhang@intel.com>

Hi Zhang,

On Wed, Dec 20, 2017 at 04:34:44PM -0500, Qi Zhang wrote:
> This patch extend rte_flow API.
> The purpose is to provide comfortable programming interface for virtual switch
> software (such as OVS) to take advantage of incoming device's vSwitch acceleration
> capability when using DPDK as data plane.
> 
> Below is summary of changes:
> 
> 1. Support to specify flow's destination as an ethdev interface.
> 
> Add action RTE_FLOW_ACTION_TYPE_ETHDEV_PORT, use port_id as the identification
> of the destitation. A typical use case is, with a smart NIC used for vSwitch
> acceleration, flow is defined to redirect packet between switch port that is
> managed by a Port Representor.
> See patch for Port Representor: http://dpdk.org/dev/patchwork/patch/31458/
> 
> 2. Enhanced flow statistics query.
> Enhanced action RTE_FLOW_ACTION_COUNT by adding last hit timestamp tracking which is
> the requirement from OVS.

Seems this introduce a regression for drop flows and for hardware unable
to timestamp packets which are already using the count action.
Why not using the timestamp API in conjunction with the mark id action?

> 3. Add flow timeout support as the requirement from OVS
> Application is able to
> a) Setup the time duration of a flow, the flow is expected to be deleted automatically
> when timeout.
> b) Ping a flow to check if it is active or not.
> c) Register a callback function when a flow is deleted due to timeout.
> 
> 4. Add protocol headers which will be supported by incoming device.
> 
> New protocal headers include IPV4 ARP, IPV6 ICMP , IPV6 extent header.
> 
> 5. Add packet modification actions which will be supported by incoming device.
> 
> Add new actions that be used to modify packet content with generic semantic:
> 
> RTE_FLOW_ACTION_TYPE_FIELD_UPDATE: update specific field of packet
> RTE_FLWO_ACTION_TYPE_FIELD_INCREMENT: increament specific field of packet
> RTE_FLWO_ACTION_TYPE_FIELD_DECREMENT: decreament specific field of packet
> RTE_FLWO_ACTION_TYPE_FIELD_COPY: copy data from one field to another in packet.
> 
> All action use struct rte_flow_item parameter to match the pattern that going
> to be modified, if no pattern match, the action just be skipped.
> These action are non-terminating action. they will not impact the fate of the
> packets, since pattern match is expected to be performed before packet be modified.
> 
> Note:
> The RFC patch is based on v17.11.
> Testpmd command line support is not included. 
> 
> Qi Zhang (4):
>   ether: add flow action to redirect packet in a switch domain
>   ether: add flow last hit query support
>   ether: Add flow timeout support
>   ether: add packet modification aciton in rte_flow
> 
> Thomas Monjalon (1):
>   version: 17.11.0
> 
>  doc/guides/prog_guide/rte_flow.rst          | 148 +++++++++++++++++++++++++++
>  lib/librte_eal/common/include/rte_version.h |   4 +-
>  lib/librte_ether/rte_flow.c                 |  38 +++++++
>  lib/librte_ether/rte_flow.h                 | 149 +++++++++++++++++++++++++++-
>  lib/librte_ether/rte_flow_driver.h          |  12 +++
>  pkg/dpdk.spec                               |   2 +-
>  6 files changed, 349 insertions(+), 4 deletions(-)
> 
> -- 
> 2.7.4
> 

Regards,

-- 
Nélio Laranjeiro
6WIND

      parent reply	other threads:[~2018-01-02  8:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-20 21:34 Qi Zhang
2017-12-20 21:34 ` [dpdk-dev] [RFC 1/5] version: 17.11.0 Qi Zhang
2017-12-21  9:07   ` De Lara Guarch, Pablo
2017-12-21  9:13     ` Zhang, Qi Z
2017-12-20 21:34 ` [dpdk-dev] [RFC 2/5] ether: add flow action to redirect packet in a switch domain Qi Zhang
2017-12-20 21:34 ` [dpdk-dev] [RFC 3/5] ether: add flow last hit query support Qi Zhang
2017-12-20 21:34 ` [dpdk-dev] [RFC 4/5] ether: Add flow timeout support Qi Zhang
2017-12-20 21:34 ` [dpdk-dev] [RFC 5/5] ether: add packet modification aciton in rte_flow Qi Zhang
2018-01-02  8:12 ` Nelio Laranjeiro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180102081255.fivvu5apxry6ntsx@laranjeiro-vm.dev.6wind.com \
    --to=nelio.laranjeiro@6wind.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).