From: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: adrien.mazarguil@6wind.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix HW checksum offload for outer IP
Date: Wed, 3 Jan 2018 09:29:54 +0100 [thread overview]
Message-ID: <20180103082954.jit4h7ioblhnm5fq@laranjeiro-vm.dev.6wind.com> (raw)
In-Reply-To: <20180103080622.2063-1-yskoh@mellanox.com>
On Wed, Jan 03, 2018 at 12:06:22AM -0800, Yongseok Koh wrote:
> Checking HW checksum offload flag for outer IP is missing. If flag is set
> for only outer IP, this can't be set properly.
>
> Fixes: f5fde5205101 ("net/mlx5: add hardware checksum offload for tunnel packets")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
> drivers/net/mlx5/mlx5_rxtx.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h
> index e70d52361..90f129168 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.h
> +++ b/drivers/net/mlx5/mlx5_rxtx.h
> @@ -636,7 +636,8 @@ txq_ol_cksum_to_cs(struct mlx5_txq_data *txq_data, struct rte_mbuf *buf)
>
> /* Should we enable HW CKSUM offload */
> if (buf->ol_flags &
> - (PKT_TX_IP_CKSUM | PKT_TX_TCP_CKSUM | PKT_TX_UDP_CKSUM)) {
> + (PKT_TX_IP_CKSUM | PKT_TX_TCP_CKSUM | PKT_TX_UDP_CKSUM |
> + PKT_TX_OUTER_IP_CKSUM)) {
> if (txq_data->tunnel_en &&
> (buf->ol_flags &
> (PKT_TX_TUNNEL_GRE | PKT_TX_TUNNEL_VXLAN))) {
> --
> 2.11.0
>
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2018-01-03 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 8:06 Yongseok Koh
2018-01-03 8:29 ` Nelio Laranjeiro [this message]
2018-01-07 14:13 ` [dpdk-stable] [dpdk-dev] " Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103082954.jit4h7ioblhnm5fq@laranjeiro-vm.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).