From: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org,
Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH 0/2] mlx5: remove dependency on kernel version
Date: Wed, 3 Jan 2018 11:25:53 +0100 [thread overview]
Message-ID: <20180103102553.e2pa5qxtxlqwchj2@laranjeiro-vm.dev.6wind.com> (raw)
In-Reply-To: <20180102205310.3586-1-stephen@networkplumber.org>
On Tue, Jan 02, 2018 at 12:53:08PM -0800, Stephen Hemminger wrote:
> Trying to eliminate all runtime calls to look at kernel version
> to determine API because they are source of portablity problems
> in distributions.
>
> Stephen Hemminger (2):
> mlx5: don't pass unused argument to sub-functions
> mlx5: don't depend on kernel version
>
> drivers/net/mlx5/mlx5_ethdev.c | 118 +++++++++++++++++------------------------
> 1 file changed, 48 insertions(+), 70 deletions(-)
>
> --
> 2.15.1
Hi Stephen,
Thinking about one point, this PMD is able to work on current
distribution releases using large version of kernels. This code was
handling two points:
1. Compiling against a kernel before v4.5 is possible. As this
situation is supported by MLNX_OFED it should remain.
2. Between v4.5 up to v4.9 the new link status API is buggee causing a
wrong status. This was the main reason why the kernel version was
verified.
This series breaks those two requirements,
Thanks,
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2018-01-03 10:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 20:53 Stephen Hemminger
2018-01-02 20:53 ` [dpdk-dev] [PATCH 1/2] mlx5: don't pass unused argument to sub-functions Stephen Hemminger
2018-01-03 7:35 ` Nelio Laranjeiro
2018-01-03 15:21 ` Stephen Hemminger
2018-01-04 8:52 ` Nelio Laranjeiro
2018-01-02 20:53 ` [dpdk-dev] [PATCH 2/2] mlx5: don't depend on kernel version Stephen Hemminger
2018-01-03 7:33 ` Nelio Laranjeiro
2018-01-03 10:25 ` Nelio Laranjeiro [this message]
2018-01-03 15:21 ` [dpdk-dev] [PATCH 0/2] mlx5: remove dependency " Stephen Hemminger
2018-01-04 8:49 ` Nelio Laranjeiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103102553.e2pa5qxtxlqwchj2@laranjeiro-vm.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=stephen@networkplumber.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).