From: Olivier Matz <olivier.matz@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
John McNamara <john.mcnamara@intel.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 6/6] doc: add mbuf VLAN flag to PMD todo list
Date: Wed, 3 Jan 2018 15:14:00 +0100 [thread overview]
Message-ID: <20180103141358.tvgv72lmczngpmpb@platinum> (raw)
In-Reply-To: <20171229090925.4e29bf0b@xeon-e3>
On Fri, Dec 29, 2017 at 09:09:25AM -0800, Stephen Hemminger wrote:
> On Tue, 21 Nov 2017 01:42:41 +0000
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> > To track modification:
> > 380a7aab1ae2 ("mbuf: rename deprecated VLAN flags")
> >
> > Proposed deadline for PMDs is v18.02
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> > doc/guides/nics/todo.rst | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
> > index 61dd9cbc9..493a49ff2 100644
> > --- a/doc/guides/nics/todo.rst
> > +++ b/doc/guides/nics/todo.rst
> > @@ -83,3 +83,14 @@ This is the list for tracking required PMD changes triggered by library modifica
> > | | | thunderx, vhost, virtio, | | | |
> > | | | vmxnet3 | | | |
> > +-------------------+--------------------------------+----------+----------------+-----------------------------------+
> > + | | check new mbuf | | af_packet, ark, avp, bnx2x, | v18.02 | 380a7aab1ae2 | mbuf flag PKT_RX_VLAN_PKT renamed |
> > + | | VLAN flag | | bnxt, bonding, cxgbe, dpaa, | | | to PKT_RX_VLAN and its meaning |
> > + | | PKT_RX_VLAN | | dpaa2, e1000, ena, enic, | | | changed, confirm PMD uses new |
> > + | | | failsafe, fm10k, i40e, ixgbe,| | | flag correct. |
> > + | | | kni, liquidio, mlx4, mlx5, | | | |
> > + | | | mrvl, nfp, null, octeontx, | | | |
> > + | | | pcap, qede, ring, sfc, | | | |
> > + | | | softnic, szedata2, tap, | | | |
> > + | | | thunderx, vhost, virtio, | | | |
> > + | | | vmxnet3 | | | |
> > + +-------------------+--------------------------------+----------+----------------+-----------------------------------+
>
>
> NAK
> Fix the other drivers.
>
> This open source, if you introduce a new behavior it is the responsibility of the person adding
> the new stuff to fix every other driver.
Actually, no new behavior was introduced. The meaning of the vlan flags
has been clarified. The purpose of this note is to ask the maintainers
to ensure that the behavior of the PMDs matches the API. This operation
is not easy to do for someone that does not know the hardware, and
that cannot test it.
next prev parent reply other threads:[~2018-01-03 14:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 1:42 [dpdk-dev] [PATCH 1/6] doc: add empty PMDs " Ferruh Yigit
2017-11-21 1:42 ` [dpdk-dev] [PATCH 2/6] doc: add mbuf reorg to PMD " Ferruh Yigit
2017-12-11 14:00 ` Marko Kovacevic
2017-12-11 14:09 ` Mcnamara, John
2017-12-29 11:58 ` Andrew Rybchenko
2017-12-29 17:07 ` Stephen Hemminger
2018-01-03 14:00 ` Olivier Matz
2017-11-21 1:42 ` [dpdk-dev] [PATCH 3/6] doc: add dynamic logging " Ferruh Yigit
2017-12-08 5:12 ` Hemant Agrawal
2017-12-11 14:09 ` Mcnamara, John
2017-11-21 1:42 ` [dpdk-dev] [PATCH 4/6] doc: add descriptor status API " Ferruh Yigit
2017-12-11 14:11 ` Mcnamara, John
2017-11-21 1:42 ` [dpdk-dev] [PATCH 5/6] doc: add offload flag " Ferruh Yigit
2017-11-21 8:32 ` Shahaf Shuler
2017-11-21 18:02 ` Ferruh Yigit
2017-11-22 8:43 ` Shahaf Shuler
2017-11-22 8:54 ` Thomas Monjalon
2017-12-11 14:11 ` Mcnamara, John
2017-11-21 1:42 ` [dpdk-dev] [PATCH 6/6] doc: add mbuf VLAN " Ferruh Yigit
2017-11-21 1:53 ` Ferruh Yigit
2017-12-06 9:24 ` Hemant Agrawal
2017-12-11 14:16 ` Mcnamara, John
2017-12-29 11:50 ` Andrew Rybchenko
2017-12-29 17:09 ` Stephen Hemminger
2018-01-03 14:14 ` Olivier Matz [this message]
2017-12-11 11:52 ` [dpdk-dev] [PATCH 1/6] doc: add empty PMDs " Mcnamara, John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103141358.tvgv72lmczngpmpb@platinum \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).