From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dev@dpdk.org, thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH 9/9] tools: use SPDX tag for Cavium copyright files
Date: Mon, 8 Jan 2018 10:46:03 +0530 [thread overview]
Message-ID: <20180108051602.GA6997@jerin> (raw)
In-Reply-To: <7d835c29-7400-0b52-287e-6a3d2562c3d0@nxp.com>
-----Original Message-----
> Date: Sun, 7 Jan 2018 14:24:11 +0530
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, dev@dpdk.org
> CC: thomas@monjalon.net
> Subject: Re: [PATCH 9/9] tools: use SPDX tag for Cavium copyright files
> User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
> Thunderbird/45.8.0
>
> On 1/6/2018 5:50 PM, Jerin Jacob wrote:
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> > devtools/build-tags.sh | 30 ++----------------------------
> > 1 file changed, 2 insertions(+), 28 deletions(-)
> >
> > diff --git a/devtools/build-tags.sh b/devtools/build-tags.sh
> > index 942da2bae..d775b17e9 100755
> > --- a/devtools/build-tags.sh
> > +++ b/devtools/build-tags.sh
> > @@ -1,35 +1,9 @@
> > #!/bin/sh -e
> > # Generate tags or gtags or cscope or etags files
> > #
> > -# BSD LICENSE
> > +# SPDX-License-Identifier: BSD-3-Clause
> > +# Copyright(c) 2017 Cavium, Inc
>
> Hi Jerin,
> All your patches are ok except this one.
> It is not aligned with the policy.
> SPDX tag shall be in 1st or 2nd line (for !/bin/sh) scripts.
>
> you can move the comments ("Generate tags...") after the copyrights.
Thanks Hemant. I will move the comments and send the v2.
>
> Regards,
> Hemant
next prev parent reply other threads:[~2018-01-08 5:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-06 12:19 [dpdk-dev] [PATCH 1/9] test: " Jerin Jacob
2018-01-06 12:19 ` [dpdk-dev] [PATCH 2/9] mk: " Jerin Jacob
2018-01-06 12:19 ` [dpdk-dev] [PATCH 3/9] lib: " Jerin Jacob
2018-01-06 12:20 ` [dpdk-dev] [PATCH 4/9] examples: " Jerin Jacob
2018-01-06 12:20 ` [dpdk-dev] [PATCH 5/9] drivers: " Jerin Jacob
2018-01-06 12:20 ` [dpdk-dev] [PATCH 6/9] app: " Jerin Jacob
2018-01-06 12:20 ` [dpdk-dev] [PATCH 7/9] doc: " Jerin Jacob
2018-01-06 12:20 ` [dpdk-dev] [PATCH 8/9] config: " Jerin Jacob
2018-01-06 12:20 ` [dpdk-dev] [PATCH 9/9] tools: " Jerin Jacob
2018-01-07 8:54 ` Hemant Agrawal
2018-01-08 5:16 ` Jerin Jacob [this message]
2018-01-08 5:25 ` [dpdk-dev] [PATCH v2 1/9] test: " Jerin Jacob
2018-01-08 5:25 ` [dpdk-dev] [PATCH v2 2/9] mk: " Jerin Jacob
2018-01-08 5:25 ` [dpdk-dev] [PATCH v2 3/9] lib: " Jerin Jacob
2018-01-08 5:25 ` [dpdk-dev] [PATCH v2 4/9] examples: " Jerin Jacob
2018-01-08 5:25 ` [dpdk-dev] [PATCH v2 5/9] drivers: " Jerin Jacob
2018-01-08 5:25 ` [dpdk-dev] [PATCH v2 6/9] app: " Jerin Jacob
2018-01-08 5:25 ` [dpdk-dev] [PATCH v2 7/9] doc: " Jerin Jacob
2018-01-08 5:25 ` [dpdk-dev] [PATCH v2 8/9] config: " Jerin Jacob
2018-01-08 5:25 ` [dpdk-dev] [PATCH v2 9/9] tools: " Jerin Jacob
2018-01-09 7:56 ` [dpdk-dev] [PATCH v2 1/9] test: " Hemant Agrawal
2018-01-09 15:20 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108051602.GA6997@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).