DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Liang Ma <liang.j.ma@intel.com>
Cc: dev@dpdk.org, harry.van.haaren@intel.com,
	bruce.richardson@intel.com, deepak.k.jain@intel.com,
	john.geary@intel.com, peter.mccarthy@intel.com, seanbh@gmail.com
Subject: Re: [dpdk-dev] [PATCH v4 4/8] lib/librte_eventdev: extend the eventdev capability flags
Date: Mon, 8 Jan 2018 12:02:09 +0530	[thread overview]
Message-ID: <20180108063208.GA19071@jerin> (raw)
In-Reply-To: <1513941830-186503-5-git-send-email-liang.j.ma@intel.com>

-----Original Message-----
> Date: Fri, 22 Dec 2017 11:23:46 +0000
> From: Liang Ma <liang.j.ma@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, harry.van.haaren@intel.com, bruce.richardson@intel.com,
>  deepak.k.jain@intel.com, john.geary@intel.com, peter.mccarthy@intel.com,
>  seanbh@gmail.com
> Subject: [PATCH v4 4/8] lib/librte_eventdev: extend the eventdev capability

1) eventdev patches subject should start with eventdev:

2) Please check the rendered doxygen HTML output.
Command to generate doxygen documentation:
make doc-api-html


>  flags
> X-Mailer: git-send-email 2.7.5
> 
> this commitd add three new eventdev capability flags

How about change to,

Add new capability flags to express the opdl PMD limitations.

> 
> RTE_EVENT_DEV_CAP_NONSEQ_MODE
> 
> Event device is capable of operating in none sequential mode. The path
> of the event is not necessary to be sequential. Application can change
> the path of event at runtime.if the flag is not set, then event each event
> will follow a path from queue 0 to queue 1 to queue 2 etc. If the flag is
> set, events may be sent to queues in any order.If the flag is not set, the
> eventdev will return an error when the application enqueues an event for a
> qid which is not the next in the sequence.
> 
> RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK
> 
> Event device is capable of configuring the queue/port link at runtime.
> if the flag is not set, the eventdev queue/port linkis only can be

s/linkis/link is

> configured during  initialization.
> 
> RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT
> 
> Event device is capable of setting up the link between multiple queue
> with single port. if  the flag is not set, the eventdev can only map a

Additional space between "if" and "the"

> single queue to each port or map a signle queue to many port.

s/signle/single

> 
> Signed-off-by: Liang Ma <liang.j.ma@intel.com>
> Signed-off-by: Peter Mccarthy <peter.mccarthy@intel.com>
> ---
>  lib/librte_eventdev/rte_eventdev.h | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h
> index 1bbea57..91fd4ef 100644
> --- a/lib/librte_eventdev/rte_eventdev.h
> +++ b/lib/librte_eventdev/rte_eventdev.h
> @@ -293,6 +293,28 @@ struct rte_mbuf; /* we just use mbuf pointers; no need to include rte_mbuf.h */
>   * @see rte_event_dequeue_burst() rte_event_enqueue_burst()
>   */
>  
> +#define RTE_EVENT_DEV_CAP_NONSEQ_MODE         (1ULL << 6)
> +/**< Event device is capable of operating in none sequential mode. The path
> + * of the event is not necessary to be sequential. Application can change
> + * the path of event at runtime.if the flag is not set, then event each event
> + * will follow a path from queue 0 to queue 1 to queue 2 etc. If the flag is
> + * set, events may be sent to queues in any order.If the flag is not set, the
> + * eventdev will return an error when the application enqueues an event for a
> + * qid which is not the next in the sequence.
> + */
> +
> +#define RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK   (1ULL << 7)
> +/**< Event device is capable of configuring the queue/port link at runtime.
> + * if the flag is not set, the eventdev queue/port link is only can be
> + * configured during  initialization.
> + */
> +
> +#define RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT (1ULL << 8)
> +/**< Event device is capable of setting up the link between multiple queue
> + * with single port. if  the flag is not set, the eventdev can only map a

Additional space between "if" and "the"

> + * single queue to each port or map a signle queue to many port.

s/signle/single

> + */
> +
>  /* Event device priority levels */
>  #define RTE_EVENT_DEV_PRIORITY_HIGHEST   0
>  /**< Highest priority expressed across eventdev subsystem
> -- 
> 2.7.5

With above changes:
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

  reply	other threads:[~2018-01-08  6:32 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-22 11:23 [dpdk-dev] [RFC v4 PATCH 0/8] event: eventdev OPDL PMD Liang Ma
2017-12-22 11:23 ` [dpdk-dev] [PATCH v4 1/8] event/opdl: add the opdl ring infrastructure library Liang Ma
2017-12-22 16:02   ` Sean Harte
2018-01-08  6:46     ` Jerin Jacob
2018-01-08 11:19       ` Liang, Ma
2018-01-08 11:23         ` Jerin Jacob
2017-12-22 11:23 ` [dpdk-dev] [PATCH v4 2/8] event/opdl: add the opdl pmd main body and helper function Liang Ma
2017-12-22 11:23 ` [dpdk-dev] [PATCH v4 3/8] eventdev/opdl: opdl eventdev pmd unit test function Liang Ma
2017-12-22 11:23 ` [dpdk-dev] [PATCH v4 4/8] lib/librte_eventdev: extend the eventdev capability flags Liang Ma
2018-01-08  6:32   ` Jerin Jacob [this message]
2017-12-22 11:23 ` [dpdk-dev] [PATCH v4 5/8] event/*: apply the three new capability flags for sw/dppa2/octeontx Liang Ma
2017-12-22 11:23 ` [dpdk-dev] [PATCH v4 6/8] maintainers: add the opdl pmd maintainer information Liang Ma
2017-12-23 15:05   ` Thomas Monjalon
2017-12-22 11:23 ` [dpdk-dev] [PATCH v4 7/8] doc:update 18.02 release notes Liang Ma
2017-12-22 11:23 ` [dpdk-dev] [PATCH v4 8/8] doc: add eventdev opdl pmd docuement Liang Ma
2017-12-23 15:06 ` [dpdk-dev] [RFC v4 PATCH 0/8] event: eventdev OPDL PMD Thomas Monjalon
2018-01-09 12:20 ` [dpdk-dev] [RFC v5 PATCH 00/12] " Liang Ma
2018-01-09 12:20   ` [dpdk-dev] [PATCH v5 01/12] event/opdl: add the opdl ring infrastructure library Liang Ma
2018-01-09 12:20   ` [dpdk-dev] [PATCH v5 02/12] event/opdl: add opdl PMD main body and helper function Liang Ma
2018-01-09 12:20   ` [dpdk-dev] [PATCH v5 03/12] event/opdl: add event queue config get/set support Liang Ma
2018-01-09 12:20   ` [dpdk-dev] [PATCH v5 04/12] event/opdl: add event port " Liang Ma
2018-01-09 12:20   ` [dpdk-dev] [PATCH v5 05/12] event/opdl: add eventdev enqueue/dequeue support Liang Ma
2018-01-09 12:20   ` [dpdk-dev] [PATCH v5 06/12] event/opdl: opdl eventdev PMD unit test function Liang Ma
2018-01-09 12:20   ` [dpdk-dev] [PATCH v5 07/12] lib/librte_eventdev: extend the eventdev capability flags Liang Ma
2018-01-09 12:27     ` Jerin Jacob
2018-01-09 12:20   ` [dpdk-dev] [PATCH v5 08/12] event/dpaa2: apply the three new " Liang Ma
2018-01-09 12:20   ` [dpdk-dev] [PATCH v5 09/12] event/octeontx: " Liang Ma
2018-01-09 12:20   ` [dpdk-dev] [PATCH v5 10/12] event/sw: " Liang Ma
2018-01-09 12:20   ` [dpdk-dev] [PATCH v5 11/12] doc: update 18.02 release notes and maintainers info Liang Ma
2018-01-09 12:20   ` [dpdk-dev] [PATCH v5 12/12] doc: add eventdev opdl PMD guide Liang Ma
2018-01-09 14:18   ` [dpdk-dev] [RFC v6 PATCH 00/12] event: eventdev OPDL PMD Liang Ma
2018-01-09 14:18     ` [dpdk-dev] [PATCH v6 01/12] event/opdl: add the opdl ring infrastructure library Liang Ma
2018-01-10 10:00       ` Sean Harte
2018-01-09 14:18     ` [dpdk-dev] [PATCH v6 02/12] event/opdl: add opdl PMD main body and helper function Liang Ma
2018-01-09 14:18     ` [dpdk-dev] [PATCH v6 03/12] event/opdl: add event queue config get/set support Liang Ma
2018-01-09 14:18     ` [dpdk-dev] [PATCH v6 04/12] event/opdl: add event port " Liang Ma
2018-01-09 14:18     ` [dpdk-dev] [PATCH v6 05/12] event/opdl: add eventdev enqueue/dequeue support Liang Ma
2018-01-09 14:18     ` [dpdk-dev] [PATCH v6 06/12] event/opdl: opdl eventdev PMD unit test function Liang Ma
2018-01-09 14:18     ` [dpdk-dev] [PATCH v6 07/12] event/opdl: extend the eventdev capability flags Liang Ma
2018-01-09 14:18     ` [dpdk-dev] [PATCH v6 08/12] event/dpaa2: apply the three new " Liang Ma
2018-01-09 14:18     ` [dpdk-dev] [PATCH v6 09/12] event/octeontx: " Liang Ma
2018-01-09 14:18     ` [dpdk-dev] [PATCH v6 10/12] event/sw: " Liang Ma
2018-01-09 14:19     ` [dpdk-dev] [PATCH v6 11/12] doc: update 18.02 release notes and maintainers info Liang Ma
2018-01-10 10:38       ` Kovacevic, Marko
2018-01-09 14:19     ` [dpdk-dev] [PATCH v6 12/12] doc: add eventdev opdl PMD guide Liang Ma
2018-01-09 17:13     ` [dpdk-dev] [RFC v6 PATCH 00/12] event: eventdev OPDL PMD Van Haaren, Harry
2018-01-10 14:45     ` [dpdk-dev] [RFC v7 " Liang Ma
2018-01-10 14:46       ` [dpdk-dev] [PATCH v7 01/12] event/opdl: add the opdl ring infrastructure library Liang Ma
2018-01-10 14:46       ` [dpdk-dev] [PATCH v7 02/12] event/opdl: add opdl PMD main body and helper function Liang Ma
2018-01-10 14:46       ` [dpdk-dev] [PATCH v7 03/12] event/opdl: add event queue config get/set support Liang Ma
2018-01-10 14:46       ` [dpdk-dev] [PATCH v7 04/12] event/opdl: add event port " Liang Ma
2018-01-10 14:46       ` [dpdk-dev] [PATCH v7 05/12] event/opdl: add eventdev enqueue/dequeue support Liang Ma
2018-01-10 14:46       ` [dpdk-dev] [PATCH v7 06/12] event/opdl: opdl eventdev PMD unit test function Liang Ma
2018-01-10 14:46       ` [dpdk-dev] [PATCH v7 07/12] event/opdl: extend the eventdev capability flags Liang Ma
2018-01-10 14:46       ` [dpdk-dev] [PATCH v7 08/12] event/dpaa2: apply the three new " Liang Ma
2018-01-10 14:46       ` [dpdk-dev] [PATCH v7 09/12] event/octeontx: " Liang Ma
2018-01-10 14:46       ` [dpdk-dev] [PATCH v7 10/12] event/sw: " Liang Ma
2018-01-10 14:46       ` [dpdk-dev] [PATCH v7 11/12] doc: update 18.02 release notes and maintainers info Liang Ma
2018-01-10 15:01         ` Kovacevic, Marko
2018-01-10 14:46       ` [dpdk-dev] [PATCH v7 12/12] doc: add eventdev opdl PMD guide Liang Ma
2018-01-10 15:01         ` Jerin Jacob
2018-01-10 15:08           ` Liang, Ma
2018-01-10 18:17             ` Jerin Jacob
2018-01-10 15:04         ` Kovacevic, Marko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180108063208.GA19071@jerin \
    --to=jerin.jacob@caviumnetworks.com \
    --cc=bruce.richardson@intel.com \
    --cc=deepak.k.jain@intel.com \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    --cc=john.geary@intel.com \
    --cc=liang.j.ma@intel.com \
    --cc=peter.mccarthy@intel.com \
    --cc=seanbh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).