From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Sean Harte <seanbh@gmail.com>
Cc: Liang Ma <liang.j.ma@intel.com>,
dev@dpdk.org, harry.van.haaren@intel.com,
Bruce Richardson <bruce.richardson@intel.com>,
deepak.k.jain@intel.com, john.geary@intel.com, "Mccarthy,
Peter" <peter.mccarthy@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 1/8] event/opdl: add the opdl ring infrastructure library
Date: Mon, 8 Jan 2018 12:16:45 +0530 [thread overview]
Message-ID: <20180108064644.GB19071@jerin> (raw)
In-Reply-To: <CACA5i9ZJYO1sXWcBPi=vdk_C3MYrFvFdEhZd8gsnWQYu+eTLjg@mail.gmail.com>
-----Original Message-----
> Date: Fri, 22 Dec 2017 16:02:42 +0000
> From: Sean Harte <seanbh@gmail.com>
> To: Liang Ma <liang.j.ma@intel.com>
> Cc: jerin.jacob@caviumnetworks.com, dev@dpdk.org,
> harry.van.haaren@intel.com, Bruce Richardson <bruce.richardson@intel.com>,
> deepak.k.jain@intel.com, john.geary@intel.com, "Mccarthy, Peter"
> <peter.mccarthy@intel.com>
> Subject: Re: [PATCH v4 1/8] event/opdl: add the opdl ring infrastructure
> library
>
> On 22 December 2017 at 11:23, Liang Ma <liang.j.ma@intel.com> wrote:
> >
> > OPDL ring is the core infrastructure of OPDL PMD. OPDL ring library
> > provide the core data structure and core helper function set. The Ring
> > implements a single ring multi-port/stage pipelined packet distribution
> > mechanism. This mechanism has the following characteristics:
> >
> > • No multiple queue cost, therefore, latency is significant reduced.
> > • Fixed dependencies between queue/ports is more suitable for complex.
> > fixed pipelines of stateless packet processing (static pipeline).
> > • Has decentralized distribution (no scheduling core).
> > • Packets remain in order (no reorder core(s)).
> > * Update build system to enable compilation.
> >
> > Signed-off-by: Liang Ma <liang.j.ma@intel.com>
> > Signed-off-by: Peter Mccarthy <peter.mccarthy@intel.com>
> > ---
> > config/common_base | 6 +
> > drivers/event/Makefile | 1 +
> > drivers/event/opdl/Makefile | 62 +
> > drivers/event/opdl/opdl_log.h | 59 +
> > drivers/event/opdl/opdl_ring.c | 1252 +++++++++++++++++++++
> > drivers/event/opdl/opdl_ring.h | 628 +++++++++++
> > drivers/event/opdl/rte_pmd_evdev_opdl_version.map | 3 +
> > mk/rte.app.mk | 1 +
> > mk/toolchain/gcc/rte.toolchain-compat.mk | 6 +
> > mk/toolchain/icc/rte.toolchain-compat.mk | 6 +
> > 10 files changed, 2024 insertions(+)
> > create mode 100644 drivers/event/opdl/Makefile
> > create mode 100644 drivers/event/opdl/opdl_log.h
> > create mode 100644 drivers/event/opdl/opdl_ring.c
> > create mode 100644 drivers/event/opdl/opdl_ring.h
> > create mode 100644 drivers/event/opdl/rte_pmd_evdev_opdl_version.map
>
> [...]
>
> Reviewed-by: Seán Harte <seanbh@gmail.com>
I think, the series is not addressed all the v3 comments. I think, the
missing ones are
1) Use dynamic logging
2) Split the patches based on eventdev ops:
example:
See the example from latest dpaa eventdev driver:
http://dpdk.org/dev/patchwork/project/dpdk/list/?submitter=Sunil
3) Fix check-patch and check-git-log.sh errors.
Wrong headline format:
doc:update 18.02 release notes
Wrong headline prefix:
eventdev/opdl: opdl eventdev pmd unit test function
event/*: apply the three new capability flags for
sw/dppa2/octeontx
Wrong headline lowercase:
event/opdl: add the opdl pmd main body and helper function
eventdev/opdl: opdl eventdev pmd unit test function
event/*: apply the three new capability flags for
sw/dppa2/octeontx
maintainers: add the opdl pmd maintainer information
doc: add eventdev opdl pmd docuement
Headline too long:
event/*: apply the three new capability flags for
sw/dppa2/octeontx
### event/opdl: add the opdl ring infrastructure library
WARNING:LONG_LINE: line over 80 characters
#451: FILE: drivers/event/opdl/opdl_ring.c:260:
+ PMD_DRV_LOG(ERR, "%u entries is more than max (%u)", n,
s->num_slots);
WARNING:LONG_LINE: line over 80 characters
#1202: FILE: drivers/event/opdl/opdl_ring.c:1011:
+ ev_orig = (struct rte_event *)get_slot(t,
s->shadow_head+i);
WARNING:LONG_LINE: line over 80 characters
#1203: FILE: drivers/event/opdl/opdl_ring.c:1012:
+ if ((ev_orig->flow_id%s->nb_instance) ==
s->instance_id) {
WARNING:LONG_LINE: line over 80 characters
#1206: FILE: drivers/event/opdl/opdl_ring.c:1015:
+ if
((ev_orig->event&OPDL_EVENT_MASK) != ev_temp) {
total: 0 errors, 4 warnings, 2049 lines checked
### event/opdl: add the opdl pmd main body and helper function
WARNING:LONG_LINE: line over 80 characters
#1489: FILE: drivers/event/opdl/opdl_evdev_init.c:301:
+ opdl_ring_cas_slot(p->enq_stage_inst, &ev[i], i,
p->atomic_claim);
WARNING:LONG_LINE: line over 80 characters
#2027: FILE: drivers/event/opdl/opdl_evdev_init.c:839:
+
opdl_pmd_dev_id(port->opdl),
WARNING:LONG_LINE: line over 80 characters
#2056: FILE: drivers/event/opdl/opdl_evdev_init.c:868:
+
opdl_pmd_dev_id(port->opdl),
total: 0 errors, 3 warnings, 2309 lines checked
### eventdev/opdl: opdl eventdev pmd unit test function
WARNING:LONG_LINE: line over 80 characters
#247: FILE: drivers/event/opdl/opdl_test.c:189:
+ PMD_DRV_LOG(ERR, "%d: error creating qid %d\n ",
__LINE__, i);
WARNING:LONG_LINE: line over 80 characters
#314: FILE: drivers/event/opdl/opdl_test.c:256:
+ PMD_DRV_LOG(ERR, "%d: error mapping lb qid\n",
__LINE__);
WARNING:LONG_LINE: line over 80 characters
#451: FILE: drivers/event/opdl/opdl_test.c:393:
+ PMD_DRV_LOG(ERR, "%d: error mapping lb qid\n",
__LINE__);
WARNING:LONG_LINE: line over 80 characters
#505: FILE: drivers/event/opdl/opdl_test.c:447:
+ PMD_DRV_LOG(ERR, "%d: deq none zero
!\n", __LINE__);
total: 0 errors, 4 warnings, 1102 lines checked
next prev parent reply other threads:[~2018-01-08 6:47 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 11:23 [dpdk-dev] [RFC v4 PATCH 0/8] event: eventdev OPDL PMD Liang Ma
2017-12-22 11:23 ` [dpdk-dev] [PATCH v4 1/8] event/opdl: add the opdl ring infrastructure library Liang Ma
2017-12-22 16:02 ` Sean Harte
2018-01-08 6:46 ` Jerin Jacob [this message]
2018-01-08 11:19 ` Liang, Ma
2018-01-08 11:23 ` Jerin Jacob
2017-12-22 11:23 ` [dpdk-dev] [PATCH v4 2/8] event/opdl: add the opdl pmd main body and helper function Liang Ma
2017-12-22 11:23 ` [dpdk-dev] [PATCH v4 3/8] eventdev/opdl: opdl eventdev pmd unit test function Liang Ma
2017-12-22 11:23 ` [dpdk-dev] [PATCH v4 4/8] lib/librte_eventdev: extend the eventdev capability flags Liang Ma
2018-01-08 6:32 ` Jerin Jacob
2017-12-22 11:23 ` [dpdk-dev] [PATCH v4 5/8] event/*: apply the three new capability flags for sw/dppa2/octeontx Liang Ma
2017-12-22 11:23 ` [dpdk-dev] [PATCH v4 6/8] maintainers: add the opdl pmd maintainer information Liang Ma
2017-12-23 15:05 ` Thomas Monjalon
2017-12-22 11:23 ` [dpdk-dev] [PATCH v4 7/8] doc:update 18.02 release notes Liang Ma
2017-12-22 11:23 ` [dpdk-dev] [PATCH v4 8/8] doc: add eventdev opdl pmd docuement Liang Ma
2017-12-23 15:06 ` [dpdk-dev] [RFC v4 PATCH 0/8] event: eventdev OPDL PMD Thomas Monjalon
2018-01-09 12:20 ` [dpdk-dev] [RFC v5 PATCH 00/12] " Liang Ma
2018-01-09 12:20 ` [dpdk-dev] [PATCH v5 01/12] event/opdl: add the opdl ring infrastructure library Liang Ma
2018-01-09 12:20 ` [dpdk-dev] [PATCH v5 02/12] event/opdl: add opdl PMD main body and helper function Liang Ma
2018-01-09 12:20 ` [dpdk-dev] [PATCH v5 03/12] event/opdl: add event queue config get/set support Liang Ma
2018-01-09 12:20 ` [dpdk-dev] [PATCH v5 04/12] event/opdl: add event port " Liang Ma
2018-01-09 12:20 ` [dpdk-dev] [PATCH v5 05/12] event/opdl: add eventdev enqueue/dequeue support Liang Ma
2018-01-09 12:20 ` [dpdk-dev] [PATCH v5 06/12] event/opdl: opdl eventdev PMD unit test function Liang Ma
2018-01-09 12:20 ` [dpdk-dev] [PATCH v5 07/12] lib/librte_eventdev: extend the eventdev capability flags Liang Ma
2018-01-09 12:27 ` Jerin Jacob
2018-01-09 12:20 ` [dpdk-dev] [PATCH v5 08/12] event/dpaa2: apply the three new " Liang Ma
2018-01-09 12:20 ` [dpdk-dev] [PATCH v5 09/12] event/octeontx: " Liang Ma
2018-01-09 12:20 ` [dpdk-dev] [PATCH v5 10/12] event/sw: " Liang Ma
2018-01-09 12:20 ` [dpdk-dev] [PATCH v5 11/12] doc: update 18.02 release notes and maintainers info Liang Ma
2018-01-09 12:20 ` [dpdk-dev] [PATCH v5 12/12] doc: add eventdev opdl PMD guide Liang Ma
2018-01-09 14:18 ` [dpdk-dev] [RFC v6 PATCH 00/12] event: eventdev OPDL PMD Liang Ma
2018-01-09 14:18 ` [dpdk-dev] [PATCH v6 01/12] event/opdl: add the opdl ring infrastructure library Liang Ma
2018-01-10 10:00 ` Sean Harte
2018-01-09 14:18 ` [dpdk-dev] [PATCH v6 02/12] event/opdl: add opdl PMD main body and helper function Liang Ma
2018-01-09 14:18 ` [dpdk-dev] [PATCH v6 03/12] event/opdl: add event queue config get/set support Liang Ma
2018-01-09 14:18 ` [dpdk-dev] [PATCH v6 04/12] event/opdl: add event port " Liang Ma
2018-01-09 14:18 ` [dpdk-dev] [PATCH v6 05/12] event/opdl: add eventdev enqueue/dequeue support Liang Ma
2018-01-09 14:18 ` [dpdk-dev] [PATCH v6 06/12] event/opdl: opdl eventdev PMD unit test function Liang Ma
2018-01-09 14:18 ` [dpdk-dev] [PATCH v6 07/12] event/opdl: extend the eventdev capability flags Liang Ma
2018-01-09 14:18 ` [dpdk-dev] [PATCH v6 08/12] event/dpaa2: apply the three new " Liang Ma
2018-01-09 14:18 ` [dpdk-dev] [PATCH v6 09/12] event/octeontx: " Liang Ma
2018-01-09 14:18 ` [dpdk-dev] [PATCH v6 10/12] event/sw: " Liang Ma
2018-01-09 14:19 ` [dpdk-dev] [PATCH v6 11/12] doc: update 18.02 release notes and maintainers info Liang Ma
2018-01-10 10:38 ` Kovacevic, Marko
2018-01-09 14:19 ` [dpdk-dev] [PATCH v6 12/12] doc: add eventdev opdl PMD guide Liang Ma
2018-01-09 17:13 ` [dpdk-dev] [RFC v6 PATCH 00/12] event: eventdev OPDL PMD Van Haaren, Harry
2018-01-10 14:45 ` [dpdk-dev] [RFC v7 " Liang Ma
2018-01-10 14:46 ` [dpdk-dev] [PATCH v7 01/12] event/opdl: add the opdl ring infrastructure library Liang Ma
2018-01-10 14:46 ` [dpdk-dev] [PATCH v7 02/12] event/opdl: add opdl PMD main body and helper function Liang Ma
2018-01-10 14:46 ` [dpdk-dev] [PATCH v7 03/12] event/opdl: add event queue config get/set support Liang Ma
2018-01-10 14:46 ` [dpdk-dev] [PATCH v7 04/12] event/opdl: add event port " Liang Ma
2018-01-10 14:46 ` [dpdk-dev] [PATCH v7 05/12] event/opdl: add eventdev enqueue/dequeue support Liang Ma
2018-01-10 14:46 ` [dpdk-dev] [PATCH v7 06/12] event/opdl: opdl eventdev PMD unit test function Liang Ma
2018-01-10 14:46 ` [dpdk-dev] [PATCH v7 07/12] event/opdl: extend the eventdev capability flags Liang Ma
2018-01-10 14:46 ` [dpdk-dev] [PATCH v7 08/12] event/dpaa2: apply the three new " Liang Ma
2018-01-10 14:46 ` [dpdk-dev] [PATCH v7 09/12] event/octeontx: " Liang Ma
2018-01-10 14:46 ` [dpdk-dev] [PATCH v7 10/12] event/sw: " Liang Ma
2018-01-10 14:46 ` [dpdk-dev] [PATCH v7 11/12] doc: update 18.02 release notes and maintainers info Liang Ma
2018-01-10 15:01 ` Kovacevic, Marko
2018-01-10 14:46 ` [dpdk-dev] [PATCH v7 12/12] doc: add eventdev opdl PMD guide Liang Ma
2018-01-10 15:01 ` Jerin Jacob
2018-01-10 15:08 ` Liang, Ma
2018-01-10 18:17 ` Jerin Jacob
2018-01-10 15:04 ` Kovacevic, Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108064644.GB19071@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=bruce.richardson@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=john.geary@intel.com \
--cc=liang.j.ma@intel.com \
--cc=peter.mccarthy@intel.com \
--cc=seanbh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).