From: Bruce Richardson <bruce.richardson@intel.com>
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Cc: dev@dpdk.org, bluca@debian.org, john.mcnamara@intel.com,
harry.van.haaren@intel.com, marko.kovacevic@intel.com,
thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH] doc: add instructions on build using meson
Date: Tue, 9 Jan 2018 15:40:29 +0000 [thread overview]
Message-ID: <20180109154029.GA8000@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <417cb993-de79-2f8f-02a7-5649299946c5@nxp.com>
On Fri, Dec 22, 2017 at 10:46:34AM +0530, Shreyansh Jain wrote:
> Hi Bruce,
>
> some trivial comments inline...
>
> On Thursday 21 December 2017 09:42 PM, Bruce Richardson wrote:
> > Add a document describing how to configure, build and install DPDK using
> > meson and ninja. Document includes references to official installation docs
> > using make, and points out the experimental nature of the build.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > INSTALL.meson | 177 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>
> Just out of curiosity, why not make it a rst file, as part of standard DPDK
> documentation? Or, maybe until meson is experimental this readme can suffice
> - but, we should have rst eventually - isn't it.
>
Eventually this should be merged into the GSG doc, once it's more
complete and less experimental. However, for V2, I will move this doc
into the "doc/" subdirectory where there is a "build-sdk-quick.txt" doc,
and rename this as "build-sdk-meson.txt".
As for the other comments, they will be fixed in V2.
Thanks for the good review.
/Bruce
next prev parent reply other threads:[~2018-01-09 15:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 16:12 Bruce Richardson
2017-12-22 5:16 ` Shreyansh Jain
2018-01-09 15:40 ` Bruce Richardson [this message]
2018-01-09 15:47 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2018-01-10 12:02 ` Kovacevic, Marko
2018-01-10 13:24 ` Luca Boccassi
2018-01-10 15:24 ` [dpdk-dev] [PATCH v3] " Bruce Richardson
2018-01-10 15:57 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109154029.GA8000@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=shreyansh.jain@nxp.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).