From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
harry.van.haaren@intel.com, jerin.jacob@caviumnetworks.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/4] drivers/mempool: add octeontx mempool driver to meson build
Date: Thu, 11 Jan 2018 19:43:46 +0530 [thread overview]
Message-ID: <20180111141345.337ieawxy4w2sxgj@Pavan-LT> (raw)
In-Reply-To: <20180109174123.GD6508@bricha3-MOBL3.ger.corp.intel.com>
On Tue, Jan 09, 2018 at 05:41:23PM +0000, Bruce Richardson wrote:
> On Sun, Dec 31, 2017 at 05:32:00AM +0530, Pavan Nikhilesh wrote:
> > Add octeontx hardware mempool driver to meson build.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
>
> On the set as a whole, it looks good to me, just the few minor nits pointed
> out in other emails. Can you do a V2 with those fixed? Also, I notice
> that you are missing License tags on the new files created, those should
> probably be added too in V2.
At the time of sending the patchset we didnt have approval for SPDX licence
tags so, left them bare will update the tags in v2.
>
> Thanks,
> /Bruce
Thanks,
Pavan.
next prev parent reply other threads:[~2018-01-11 14:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-31 0:02 Pavan Nikhilesh
2017-12-31 0:02 ` [dpdk-dev] [PATCH 2/4] drivers/net: add drivers for Cavium NICs " Pavan Nikhilesh
2018-01-09 17:29 ` Bruce Richardson
2018-01-11 12:42 ` Pavan Nikhilesh
2017-12-31 0:02 ` [dpdk-dev] [PATCH 3/4] event/octeontx: add octeontx event device " Pavan Nikhilesh
2018-01-09 17:34 ` Bruce Richardson
2018-01-11 13:15 ` Pavan Nikhilesh
2017-12-31 0:02 ` [dpdk-dev] [PATCH 4/4] app/test-eventdev: add test-eventdev " Pavan Nikhilesh
2018-01-09 17:35 ` [dpdk-dev] [PATCH 1/4] drivers/mempool: add octeontx mempool driver " Bruce Richardson
2018-01-11 13:38 ` Pavan Nikhilesh
2018-01-11 13:44 ` Pavan Nikhilesh
2018-01-09 17:41 ` Bruce Richardson
2018-01-11 14:13 ` Pavan Nikhilesh [this message]
2018-01-14 13:28 ` [dpdk-dev] [PATCH v2 " Pavan Nikhilesh
2018-01-14 13:28 ` [dpdk-dev] [PATCH v2 2/4] drivers/net: add drivers for Cavium NICs " Pavan Nikhilesh
2018-01-14 13:28 ` [dpdk-dev] [PATCH v2 3/4] event/octeontx: add octeontx event device " Pavan Nikhilesh
2018-01-14 13:28 ` [dpdk-dev] [PATCH v2 4/4] app/test-eventdev: add test-eventdev " Pavan Nikhilesh
2018-01-19 13:12 ` [dpdk-dev] [PATCH v3 1/4] drivers/mempool: add octeontx mempool driver " Pavan Nikhilesh
2018-01-19 13:12 ` [dpdk-dev] [PATCH v3 2/4] drivers/net: add drivers for Cavium NICs " Pavan Nikhilesh
2018-01-19 17:16 ` Bruce Richardson
2018-01-19 17:29 ` Pavan Nikhilesh
2018-01-19 13:12 ` [dpdk-dev] [PATCH v3 3/4] event: add octeontx event device " Pavan Nikhilesh
2018-01-19 17:19 ` Bruce Richardson
2018-01-19 13:12 ` [dpdk-dev] [PATCH v3 4/4] app/test-eventdev: add test-eventdev " Pavan Nikhilesh
2018-01-19 17:26 ` Bruce Richardson
2018-01-19 16:48 ` [dpdk-dev] [PATCH v3 1/4] drivers/mempool: add octeontx mempool driver " Bruce Richardson
2018-01-19 18:15 ` [dpdk-dev] [PATCH v4 " Pavan Nikhilesh
2018-01-19 18:15 ` [dpdk-dev] [PATCH v4 2/4] drivers/net: add drivers for Cavium NICs " Pavan Nikhilesh
2018-01-22 14:35 ` Bruce Richardson
2018-01-19 18:15 ` [dpdk-dev] [PATCH v4 3/4] event: add octeontx event device " Pavan Nikhilesh
2018-01-19 18:15 ` [dpdk-dev] [PATCH v4 4/4] app/test-eventdev: add test-eventdev " Pavan Nikhilesh
2018-01-22 14:37 ` [dpdk-dev] [PATCH v4 1/4] drivers/mempool: add octeontx mempool driver " Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111141345.337ieawxy4w2sxgj@Pavan-LT \
--to=pbhagavatula@caviumnetworks.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).