From: Tomasz Duszynski <tdu@semihalf.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Tomasz Duszynski <tdu@semihalf.com>,
dev@dpdk.org, jck@semihalf.com, mw@semihalf.com,
dima@marvell.com, nsamsono@marvell.com, Jianbo.liu@arm.com
Subject: Re: [dpdk-dev] [PATCH 2/5] net/mrvl: fix hif objects allocation
Date: Mon, 15 Jan 2018 07:53:06 +0100 [thread overview]
Message-ID: <20180115065306.GA17023@sh.semihalf.local> (raw)
In-Reply-To: <7902c50d-59b2-2f9f-510b-a9ec2000e98d@intel.com>
On Fri, Jan 12, 2018 at 07:13:22PM +0000, Ferruh Yigit wrote:
> On 1/11/2018 3:35 PM, Tomasz Duszynski wrote:
> > From: Natalie Samsonov <nsamsono@marvell.com>
>
> Commit title updated to [1] assuming hif is an abbreviation (btw, what is hif?)
Thanks for fixing that. HIF stands for host-interface. You want to allocate
it per lcore so that couple of lcores can use MUSDK library simultaneously.
>
> [1]
> net/mrvl: fix HIF objects allocation
>
> >
> > 1. Add checking for non-EAL threads.
> >
> > 2. Create hif objects on first use since sometimes on probe not all
> > lcores are initialized and can be added later.
> > In this case the hif objects for later cores were not created and
> > this caused system crash.
> >
> > Fixes: 0ddc9b8 ("net/mrvl: add net PMD skeleton")
>
> Fixes: 0ddc9b815b11 ("net/mrvl: add net PMD skeleton")
> Cc: stable@dpdk.org
>
> >
> > Signed-off-by: Natalie Samsonov <nsamsono@marvell.com>
>
> <...>
>
--
- Tomasz Duszyński
next prev parent reply other threads:[~2018-01-15 6:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 15:35 [dpdk-dev] [PATCH 0/5] net/mrvl: fix recently found pmd issues Tomasz Duszynski
2018-01-11 15:35 ` [dpdk-dev] [PATCH 1/5] net/mrvl: fix multiple probe issue Tomasz Duszynski
2018-01-11 15:35 ` [dpdk-dev] [PATCH 2/5] net/mrvl: fix hif objects allocation Tomasz Duszynski
2018-01-12 19:13 ` Ferruh Yigit
2018-01-15 6:53 ` Tomasz Duszynski [this message]
2018-01-11 15:35 ` [dpdk-dev] [PATCH 3/5] net/mrvl: fix oversize bpool handling Tomasz Duszynski
2018-01-11 15:35 ` [dpdk-dev] [PATCH 4/5] net/mrvl: fix shadow queue tail and size calculations Tomasz Duszynski
2018-01-11 15:35 ` [dpdk-dev] [PATCH 5/5] net/mrvl: keep shadow txqs inside pmd txq Tomasz Duszynski
2018-01-12 19:13 ` [dpdk-dev] [PATCH 0/5] net/mrvl: fix recently found pmd issues Ferruh Yigit
2018-01-15 7:35 ` Tomasz Duszynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115065306.GA17023@sh.semihalf.local \
--to=tdu@semihalf.com \
--cc=Jianbo.liu@arm.com \
--cc=dev@dpdk.org \
--cc=dima@marvell.com \
--cc=ferruh.yigit@intel.com \
--cc=jck@semihalf.com \
--cc=mw@semihalf.com \
--cc=nsamsono@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).