From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, borisp@mellanox.com
Subject: Re: [dpdk-dev] [PATCH 1/2] net: fix ESP header byte ordering definition
Date: Tue, 16 Jan 2018 16:52:01 +0100 [thread overview]
Message-ID: <20180116155201.zz6frinsqyjlxdqo@laranjeiro-vm.dev.6wind.com> (raw)
In-Reply-To: <20180116142409.yazvskvhlgsrzuib@platinum>
On Tue, Jan 16, 2018 at 03:24:09PM +0100, Olivier Matz wrote:
> On Thu, Jan 11, 2018 at 10:15:58AM +0100, Nelio Laranjeiro wrote:
> > ESP header is defined in the RFC2406 [1] as Big Endian fields it should use
> > the corresponding types in DPDK as well.
> >
> > Fixes: d4b684f7197a ("net: add ESP header to generic flow steering")
>
> I wonder if we should really mark this as a fix.
I also agree, the point is some examples application have started using
it as CPU order instead of Network order, this patch also needs to be
applied in stable branch before fixing the code using it.
> > Cc: borisp@mellanox.com
> >
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> >
> > [1] https://tools.ietf.org/html/rfc2406
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2018-01-16 15:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 9:15 Nelio Laranjeiro
2018-01-11 9:15 ` [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix SPI byte order in flow item Nelio Laranjeiro
2018-01-11 9:53 ` Akhil Goyal
2018-01-19 9:34 ` De Lara Guarch, Pablo
2018-01-16 14:24 ` [dpdk-dev] [PATCH 1/2] net: fix ESP header byte ordering definition Olivier Matz
2018-01-16 15:52 ` Nélio Laranjeiro [this message]
2018-01-19 9:33 ` De Lara Guarch, Pablo
2018-01-19 9:34 ` De Lara Guarch, Pablo
2018-01-19 9:35 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116155201.zz6frinsqyjlxdqo@laranjeiro-vm.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=borisp@mellanox.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).