From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 2/4] drivers/net: add drivers for Cavium NICs to meson build
Date: Fri, 19 Jan 2018 22:59:28 +0530 [thread overview]
Message-ID: <20180119172927.zkzi4d6nejsjrvro@Pavan-LT> (raw)
In-Reply-To: <20180119171630.GE16980@bricha3-MOBL3.ger.corp.intel.com>
On Fri, Jan 19, 2018 at 05:16:30PM +0000, Bruce Richardson wrote:
> On Fri, Jan 19, 2018 at 06:42:02PM +0530, Pavan Nikhilesh wrote:
> > Add Cavium octeontx and thunder nicvf to meson build infrastructure.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
> > drivers/net/meson.build | 3 ++-
> > drivers/net/octeontx/base/meson.build | 21 +++++++++++++++++++++
> > drivers/net/octeontx/meson.build | 13 +++++++++++++
> > drivers/net/thunderx/Makefile | 2 +-
> > drivers/net/thunderx/base/meson.build | 14 ++++++++++++++
> > drivers/net/thunderx/meson.build | 14 ++++++++++++++
> > ...cvf_version.map => rte_pmd_thunderx_version.map} | 0
> > 7 files changed, 65 insertions(+), 2 deletions(-)
> > create mode 100644 drivers/net/octeontx/base/meson.build
> > create mode 100644 drivers/net/octeontx/meson.build
> > create mode 100644 drivers/net/thunderx/base/meson.build
> > create mode 100644 drivers/net/thunderx/meson.build
> > rename drivers/net/thunderx/{rte_pmd_thunderx_nicvf_version.map => rte_pmd_thunderx_version.map} (100%)
> >
> <snip>
> > diff --git a/drivers/net/thunderx/meson.build b/drivers/net/thunderx/meson.build
> > new file mode 100644
> > index 000000000..7333738de
> > --- /dev/null
> > +++ b/drivers/net/thunderx/meson.build
> > @@ -0,0 +1,14 @@
> > +# SPDX-License-Identifier: BSD-3-Clause
> > +# Copyright(c) 2017 Cavium, Inc
> > +
> > +subdir('base')
> > +objs = [base_objs]
> > +
> > +sources = files('nicvf_rxtx.c',
> > + 'nicvf_ethdev.c',
> > + 'nicvf_svf.c'
> > + )
> > +
> > +cflags += '-fno-prefetch-loop-arrays'
> > +
>
> This flag doesn't work with clang (at least with 5.0.0), so needs to
> be:
>
> if cc.has_argument('-fno-prefetch-loop-arrays')
> cflags += '-fno-prefetch-loop-arrays'
> endif
>
> I'm also getting errors with gcc builds due to maybe-uninitialized
> variables, so I also had to add:
>
> if cc.has_argument('-Wno-maybe-uninitialized')
> cflags += '-Wno-maybe-uninitialized'
> endif
Will send out v4 adressing these.
>
> Regards,
> /Bruce
Thanks,
Pavan
next prev parent reply other threads:[~2018-01-19 17:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-31 0:02 [dpdk-dev] [PATCH 1/4] drivers/mempool: add octeontx mempool driver " Pavan Nikhilesh
2017-12-31 0:02 ` [dpdk-dev] [PATCH 2/4] drivers/net: add drivers for Cavium NICs " Pavan Nikhilesh
2018-01-09 17:29 ` Bruce Richardson
2018-01-11 12:42 ` Pavan Nikhilesh
2017-12-31 0:02 ` [dpdk-dev] [PATCH 3/4] event/octeontx: add octeontx event device " Pavan Nikhilesh
2018-01-09 17:34 ` Bruce Richardson
2018-01-11 13:15 ` Pavan Nikhilesh
2017-12-31 0:02 ` [dpdk-dev] [PATCH 4/4] app/test-eventdev: add test-eventdev " Pavan Nikhilesh
2018-01-09 17:35 ` [dpdk-dev] [PATCH 1/4] drivers/mempool: add octeontx mempool driver " Bruce Richardson
2018-01-11 13:38 ` Pavan Nikhilesh
2018-01-11 13:44 ` Pavan Nikhilesh
2018-01-09 17:41 ` Bruce Richardson
2018-01-11 14:13 ` Pavan Nikhilesh
2018-01-14 13:28 ` [dpdk-dev] [PATCH v2 " Pavan Nikhilesh
2018-01-14 13:28 ` [dpdk-dev] [PATCH v2 2/4] drivers/net: add drivers for Cavium NICs " Pavan Nikhilesh
2018-01-14 13:28 ` [dpdk-dev] [PATCH v2 3/4] event/octeontx: add octeontx event device " Pavan Nikhilesh
2018-01-14 13:28 ` [dpdk-dev] [PATCH v2 4/4] app/test-eventdev: add test-eventdev " Pavan Nikhilesh
2018-01-19 13:12 ` [dpdk-dev] [PATCH v3 1/4] drivers/mempool: add octeontx mempool driver " Pavan Nikhilesh
2018-01-19 13:12 ` [dpdk-dev] [PATCH v3 2/4] drivers/net: add drivers for Cavium NICs " Pavan Nikhilesh
2018-01-19 17:16 ` Bruce Richardson
2018-01-19 17:29 ` Pavan Nikhilesh [this message]
2018-01-19 13:12 ` [dpdk-dev] [PATCH v3 3/4] event: add octeontx event device " Pavan Nikhilesh
2018-01-19 17:19 ` Bruce Richardson
2018-01-19 13:12 ` [dpdk-dev] [PATCH v3 4/4] app/test-eventdev: add test-eventdev " Pavan Nikhilesh
2018-01-19 17:26 ` Bruce Richardson
2018-01-19 16:48 ` [dpdk-dev] [PATCH v3 1/4] drivers/mempool: add octeontx mempool driver " Bruce Richardson
2018-01-19 18:15 ` [dpdk-dev] [PATCH v4 " Pavan Nikhilesh
2018-01-19 18:15 ` [dpdk-dev] [PATCH v4 2/4] drivers/net: add drivers for Cavium NICs " Pavan Nikhilesh
2018-01-22 14:35 ` Bruce Richardson
2018-01-19 18:15 ` [dpdk-dev] [PATCH v4 3/4] event: add octeontx event device " Pavan Nikhilesh
2018-01-19 18:15 ` [dpdk-dev] [PATCH v4 4/4] app/test-eventdev: add test-eventdev " Pavan Nikhilesh
2018-01-22 14:37 ` [dpdk-dev] [PATCH v4 1/4] drivers/mempool: add octeontx mempool driver " Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119172927.zkzi4d6nejsjrvro@Pavan-LT \
--to=pbhagavatula@caviumnetworks.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).