From: Bruce Richardson <bruce.richardson@intel.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com,
herbert.guan@arm.com, hemant.agrawal@nxp.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 2/2] build: add support for detecting march on ARM
Date: Mon, 22 Jan 2018 14:09:28 +0000 [thread overview]
Message-ID: <20180122140927.GA9108@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <20180122123717.7ku5z6yr5dz6mit3@Pavan-LT>
On Mon, Jan 22, 2018 at 06:07:18PM +0530, Pavan Nikhilesh wrote:
> On Mon, Jan 22, 2018 at 12:30:53PM +0000, Bruce Richardson wrote:
> > On Mon, Jan 22, 2018 at 05:16:49PM +0530, Pavan Nikhilesh wrote:
> > > Added support for detecting march and mcpu by reading midr_el1
> > > register. The implementer, primary part number values read can be
> > > used to figure out the underlying arm cpu.
> > >
> > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > > --- app/test-pmd/meson.build | 2 +-
> > > config/arm/armv8_machine.py | 18 +++++++++ config/arm/meson.build
> > > | 95 +++++++++++++++++++++++++++++++++++++++++----
> > > config/meson.build | 19 ++++----- drivers/meson.build
> > > | 2 +- examples/meson.build | 2 +- lib/meson.build
> > > | 2 +- meson.build | 2 +- test/test/meson.build
> > > | 2 +- 9 files changed, 121 insertions(+), 23 deletions(-) create
> > > mode 100755 config/arm/armv8_machine.py
> > >
> <snip>
> > > + + if machine == 'generic' + machine =
> > > impl_generic + cmd_output = cmd_generic + endif +
> > > + message('Implementer : ' + machine[0])
> >
> > When cross-compiling for arm I get an error at this line:
> >
> > Meson encountered an error in file config/arm/meson.build, line
> > 69, column 1: Index 0 out of bounds of array of size 0.
> >
> Will be sending v2 of the cross patch soon(once directory structure
> and file name is fininlized) that would resolve this issue.
>
So is there an expected patch ordering here? I believe the set for
adding Octeon drivers to build is ok to merge, though there is a small
change for renaming machine_arg to machine_args in it if these patches
are not applied first. Will I take that set, if my recent rebase on top
of mainline has not broken it, and you can rebase these to take account
of that extra driver?
/Bruce
next prev parent reply other threads:[~2018-01-22 14:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 10:53 [dpdk-dev] [RFC PATCH] RFC build: prototype support for ARM builds Bruce Richardson
2017-12-19 13:27 ` Luca Boccassi
2017-12-19 14:17 ` Bruce Richardson
2018-01-19 13:05 ` [dpdk-dev] [PATCH v2 1/2] build: add " Pavan Nikhilesh
2018-01-19 13:05 ` [dpdk-dev] [PATCH v2 2/2] build: add support for detecting march on ARM Pavan Nikhilesh
2018-01-19 13:52 ` [dpdk-dev] [PATCH v3 1/2] build: add support for ARM builds Pavan Nikhilesh
2018-01-19 13:52 ` [dpdk-dev] [PATCH v3 2/2] build: add support for detecting march on ARM Pavan Nikhilesh
2018-01-19 16:17 ` Bruce Richardson
2018-01-19 17:13 ` Pavan Nikhilesh
2018-01-19 17:30 ` Bruce Richardson
2018-01-19 16:24 ` [dpdk-dev] [PATCH v3 1/2] build: add support for ARM builds Bruce Richardson
2018-01-19 16:49 ` Hemant Agrawal
2018-01-19 17:33 ` Bruce Richardson
2018-01-19 18:23 ` [dpdk-dev] [PATCH v4 " Pavan Nikhilesh
2018-01-19 18:23 ` [dpdk-dev] [PATCH v4 2/2] build: add support for detecting march on ARM Pavan Nikhilesh
2018-01-22 5:52 ` Herbert Guan
2018-01-22 7:16 ` Pavan Nikhilesh
2018-01-22 11:46 ` [dpdk-dev] [PATCH v5 1/2] build: add support for ARM builds Pavan Nikhilesh
2018-01-22 11:46 ` [dpdk-dev] [PATCH v5 2/2] build: add support for detecting march on ARM Pavan Nikhilesh
2018-01-22 12:30 ` Bruce Richardson
2018-01-22 12:37 ` Pavan Nikhilesh
2018-01-22 14:09 ` Bruce Richardson [this message]
2018-01-22 14:44 ` Pavan Nikhilesh
2018-01-22 15:26 ` [dpdk-dev] [PATCH v6 1/4] build: add support for ARM builds Pavan Nikhilesh
2018-01-22 15:26 ` [dpdk-dev] [PATCH v6 2/4] build: add support for detecting march on ARM Pavan Nikhilesh
2018-01-22 15:26 ` [dpdk-dev] [PATCH v6 3/4] build: add support for vendor specific ARM cross builds Pavan Nikhilesh
2018-01-22 15:26 ` [dpdk-dev] [PATCH v6 4/4] doc: add instructions to cross compile using meson Pavan Nikhilesh
2018-01-22 16:10 ` [dpdk-dev] [PATCH v6 1/4] build: add support for ARM builds Bruce Richardson
2018-01-22 16:20 ` Jerin Jacob
2018-01-22 16:26 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180122140927.GA9108@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=herbert.guan@arm.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=pbhagavatula@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).