From: Bruce Richardson <bruce.richardson@intel.com>
To: Elza Mathew <elza.mathew@intel.com>
Cc: jasvinder.singh@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/3] net: run-time function selection
Date: Mon, 22 Jan 2018 17:36:34 +0000 [thread overview]
Message-ID: <20180122173634.GA7528@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <20171211153116.GA12544@bricha3-MOBL3.ger.corp.intel.com>
On Mon, Dec 11, 2017 at 03:31:16PM +0000, Bruce Richardson wrote:
> On Mon, Nov 06, 2017 at 10:05:43AM -0800, Elza Mathew wrote:
> > Compile-time function selection can potentially lead to
> > lower performance on generic builds done by distros.
> > Replaced compile time flag checks with run-time
> > function selection.
> >
> > Signed-off-by: Elza Mathew <elza.mathew@intel.com>
> > ---
> > lib/librte_net/rte_net_crc.c | 22 +++++++++++++---------
> > 1 file changed, 13 insertions(+), 9 deletions(-)
> >
> Patch looks good to me, but unfortunately the compilation testing shows
> an issue with clang compliation on FreeBSD 10. I've also tested with gcc
> on both BSD 10 and 11 and saw no issues, and BSD 11 clang compilation is
> also fine.
>
> The compilation error is due to missing _mm_clmulepi64_si128 instrinsic:
> In file included from /home/patchWorkOrg/compilation/lib/librte_net/rte_net_crc.c:43:
> /home/patchWorkOrg/compilation/lib/librte_net/net_crc_sse.h:81:17: error: implicit declaration of function '_mm_clmulepi64_si128' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
> __m128i tmp0 = _mm_clmulepi64_si128(fold, precomp, 0x01);
>
> /Bruce
Checking with latest images for 10.3 or 10.4 no longer shows this
problem. I think the patch can be merged as-is.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Thomas, do you need a resubmit to appear as a new patch in patchwork?
prev parent reply other threads:[~2018-01-22 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 18:05 Elza Mathew
2017-12-11 15:31 ` Bruce Richardson
2018-01-18 23:43 ` Thomas Monjalon
2018-01-19 9:20 ` Bruce Richardson
2018-01-22 17:36 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180122173634.GA7528@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=elza.mathew@intel.com \
--cc=jasvinder.singh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).