From: "Liang, Ma" <liang.j.ma@intel.com>
To: Zhiyong Yang <zhiyong.yang@intel.com>
Cc: dev@dpdk.org, peter.mccarthy@intel.com, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH] event/opdl: fix ICC fails at compile time
Date: Thu, 25 Jan 2018 11:03:40 +0000 [thread overview]
Message-ID: <20180125110340.GC9466@sivswdev01.ir.intel.com> (raw)
In-Reply-To: <20180125070350.14735-1-zhiyong.yang@intel.com>
On 25 Jan 15:03, Zhiyong Yang wrote:
> ICC reports the issue at compile time as follows.
> error #592: variable "i" is used before its value is set
> RTE_SET_USED(i);
>
> The patch is to fix it. GCC and CLANG has been tested as well.
>
> Fixes: d548ef513cd7 ("event/opdl: add unit tests")
> Cc: liang.j.ma@intel.com
> Cc: peter.mccarthy@intel.com
> Cc: ferruh.yigit@intel.com
>
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> ---
> drivers/event/opdl/opdl_test.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/event/opdl/opdl_test.c b/drivers/event/opdl/opdl_test.c
> index 13d4f6b45..39c6cf8cf 100644
> --- a/drivers/event/opdl/opdl_test.c
> +++ b/drivers/event/opdl/opdl_test.c
> @@ -562,7 +562,6 @@ single_link_w_stats(struct test *t)
> uint32_t deq_pkts;
> struct rte_mbuf *mbufs[3];
> RTE_SET_USED(mbufs);
> - RTE_SET_USED(i);
>
> /* Create instance with 3 ports */
> if (init(t, 2, tx_port + 1) < 0 ||
> @@ -702,10 +701,8 @@ single_link(struct test *t)
> /* const uint8_t w3_port = 3; */
> const uint8_t tx_port = 2;
> int err;
> - int i;
> struct rte_mbuf *mbufs[3];
> RTE_SET_USED(mbufs);
> - RTE_SET_USED(i);
>
> /* Create instance with 5 ports */
> if (init(t, 2, tx_port+1) < 0 ||
> --
> 2.13.3
>
Many thanks Zhi Yong.
Acked-by: Liang Ma <liang.j.ma@intel.com>
next prev parent reply other threads:[~2018-01-25 11:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 7:03 Zhiyong Yang
2018-01-25 11:03 ` Liang, Ma [this message]
2018-01-25 16:15 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180125110340.GC9466@sivswdev01.ir.intel.com \
--to=liang.j.ma@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=peter.mccarthy@intel.com \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).