From: Yuanhan Liu <yliu@fridaylinux.org>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [dpdk-dev] [PATCH 0/2] vhost: fix VIRTIO_NET_F_MQ vhost_scsi breakage
Date: Thu, 1 Feb 2018 22:46:48 +0800 [thread overview]
Message-ID: <20180201144648.GQ29540@yliu-mob> (raw)
In-Reply-To: <20180131174651.6386-1-stefanha@redhat.com>
On Wed, Jan 31, 2018 at 05:46:49PM +0000, Stefan Hajnoczi wrote:
> These patches fix a recent regression in librte_vhost that breaks the
> vhost_scsi example application. vhost_user.c assumes all devices are vhost net
> backends when handling the VIRTIO_NET_F_MQ feature bit. The code is triggered
> by vhost scsi devices and causes virtqueues to be removed. See Patch 2 for
> details.
>
> Patch 1 puts the infrastructure in place to distinguish between the built-in
> virtio_net.c driver and generic vhost device backend usage.
>
> Patch 2 fixes the regression by handling VIRTIO_NET_F_MQ only when the built-in
> virtio_net.c driver is in use.
>
> Stefan Hajnoczi (2):
> vhost: add flag for built-in virtio_net.c driver
> vhost: only drop vqs with built-in virtio_net.c driver
Series Acked-by: Yuanhan Liu <yliu@fridaylinux.org>
Thanks.
--yliu
>
> lib/librte_vhost/vhost.h | 3 +++
> lib/librte_vhost/socket.c | 15 +++++++++++++++
> lib/librte_vhost/vhost.c | 17 ++++++++++++++++-
> lib/librte_vhost/vhost_user.c | 3 ++-
> lib/librte_vhost/virtio_net.c | 14 ++++++++++++++
> 5 files changed, 50 insertions(+), 2 deletions(-)
>
> --
> 2.14.3
prev parent reply other threads:[~2018-02-01 14:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 17:46 Stefan Hajnoczi
2018-01-31 17:46 ` [dpdk-dev] [PATCH 1/2] vhost: add flag for built-in virtio_net.c driver Stefan Hajnoczi
2018-02-01 14:46 ` Yuanhan Liu
2018-01-31 17:46 ` [dpdk-dev] [PATCH 2/2] vhost: only drop vqs with " Stefan Hajnoczi
2018-01-31 18:07 ` Maxime Coquelin
[not found] ` <20180201102428.GA5783@stefanha-x1.localdomain>
2018-02-01 12:49 ` Maxime Coquelin
2018-02-01 12:58 ` [dpdk-dev] [PATCH 0/2] vhost: fix VIRTIO_NET_F_MQ vhost_scsi breakage Maxime Coquelin
2018-02-05 14:20 ` Ferruh Yigit
2018-02-01 14:46 ` Yuanhan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180201144648.GQ29540@yliu-mob \
--to=yliu@fridaylinux.org \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).