From: Bruce Richardson <bruce.richardson@intel.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: jerin.jacob@caviumnetworks.com,
santosh.shukla@caviumnetworks.com, ferruh.yigit@intel.com,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net/octeontx: register fpa as platform HW mempool
Date: Mon, 5 Feb 2018 11:44:29 +0000 [thread overview]
Message-ID: <20180205114428.GA19776@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <20180204153309.17312-1-pbhagavatula@caviumnetworks.com>
On Sun, Feb 04, 2018 at 09:03:09PM +0530, Pavan Nikhilesh wrote:
> Register octeontx-fpavf as platform HW mempool when net/octeontx pmd is
> used.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
>
> v2 Changes:
> - fixed compilation issues caused by using experimental API in both meson and
> make.
>
> drivers/net/octeontx/Makefile | 2 ++
> drivers/net/octeontx/meson.build | 2 ++
> drivers/net/octeontx/octeontx_ethdev.c | 2 ++
> 3 files changed, 6 insertions(+)
>
> diff --git a/drivers/net/octeontx/Makefile b/drivers/net/octeontx/Makefile
> index b47bf7a40..3e4a10662 100644
> --- a/drivers/net/octeontx/Makefile
> +++ b/drivers/net/octeontx/Makefile
> @@ -43,6 +43,8 @@ else
> CFLAGS_octeontx_rxtx.o += -O3 -Ofast
> endif
>
> +CFLAGS_octeontx_ethdev.o += -DALLOW_EXPERIMENTAL_API
> +
> LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
> LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
> LDLIBS += -lrte_mempool_octeontx
> diff --git a/drivers/net/octeontx/meson.build b/drivers/net/octeontx/meson.build
> index ef789eaa9..135e63e2f 100644
> --- a/drivers/net/octeontx/meson.build
> +++ b/drivers/net/octeontx/meson.build
> @@ -8,6 +8,8 @@ sources = files('octeontx_rxtx.c',
> 'octeontx_ethdev.c'
> )
>
> +cflags += '-DALLOW_EXPERIMENTAL_API'
> +
Rather than having each driver modify cflags, I've set up the variable
"allow_experimental_apis" in the top-level meson.build file. So just put
allow_experimental_apis = true
in your driver file.
/Bruce
next prev parent reply other threads:[~2018-02-05 11:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 15:45 [dpdk-dev] [PATCH] " Pavan Nikhilesh
2018-01-31 19:51 ` Ferruh Yigit
2018-02-04 15:33 ` [dpdk-dev] [PATCH v2] " Pavan Nikhilesh
2018-02-05 5:41 ` santosh
2018-02-05 10:34 ` Ferruh Yigit
2018-02-05 10:44 ` Pavan Nikhilesh
2018-02-05 11:46 ` Bruce Richardson
2018-02-05 18:55 ` Ferruh Yigit
2018-02-05 11:44 ` Bruce Richardson [this message]
2018-02-05 10:55 ` [dpdk-dev] [PATCH v3] " Pavan Nikhilesh
2018-02-05 16:14 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180205114428.GA19776@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=pbhagavatula@caviumnetworks.com \
--cc=santosh.shukla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).