From: Bruce Richardson <bruce.richardson@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: dev@dpdk.org, Ivan Malov <ivan.malov@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/sfc: add support for meson build
Date: Mon, 5 Feb 2018 14:00:41 +0000 [thread overview]
Message-ID: <20180205140040.GA20884@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <e93cd403-0a4d-094f-0db0-3901619a53e3@solarflare.com>
On Mon, Feb 05, 2018 at 03:33:54PM +0300, Andrew Rybchenko wrote:
> On 02/05/2018 03:30 PM, Bruce Richardson wrote:
> > On Sat, Feb 03, 2018 at 01:46:34PM +0000, Andrew Rybchenko wrote:
> > > From: Ivan Malov <ivan.malov@oktetlabs.ru>
> > >
> > > Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> > > Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> > > ---
> > > v2:
> > > - use includes to extend include directories set
> > > - limit to x86 architecture
> > > - specify include directories in base driver build
> > > - remove unnecessary optimization level set and driver dir from includes
> > >
> > > drivers/net/meson.build | 2 +-
> > > drivers/net/sfc/base/meson.build | 70 ++++++++++++++++++++++++++++++++++++++++
> > > drivers/net/sfc/meson.build | 64 ++++++++++++++++++++++++++++++++++++
> > > 3 files changed, 135 insertions(+), 1 deletion(-)
> > > create mode 100644 drivers/net/sfc/base/meson.build
> > > create mode 100644 drivers/net/sfc/meson.build
> > >
> > Thanks, this looks a lot better.
> >
> > Unfortunately, it still doesn't compile on ARM, though that is more an
> > issue with the drivers/meson.build file, than a bug with your driver
> > specifically. :-( Right now, the base code libraries are still compiled
> > even when build = "false" because those targets are provided in the
> > per-driver meson.build files, rather than managed at the top level one.
> > To properly fix this, in 18.05 I think we should add support at the
> > top-level driver file for base directories, since so many drivers use
> > them. That will move the building of base code to the protection of
> > "build" flag.
> >
> > However, since this set doesn't affect any other components, I'd like to
> > get this into 18.02. To fix it, the following changes need to be made to
> > your patch. If you are ok with these, I can add these changes on apply.
>
> Yes, these changes are OK for us. Thanks.
>
> Andrew.
>
Applied to dpdk-next-build with suggested changes.
/Bruce
prev parent reply other threads:[~2018-02-05 14:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 12:43 [dpdk-dev] [PATCH 1/2] net/sfc: rename version map file Andrew Rybchenko
2018-02-02 12:43 ` [dpdk-dev] [PATCH 2/2] net/sfc: add support for meson build Andrew Rybchenko
2018-02-02 16:18 ` Bruce Richardson
2018-02-03 15:33 ` Andrew Rybchenko
2018-02-05 10:06 ` Bruce Richardson
2018-02-02 16:19 ` [dpdk-dev] [PATCH 1/2] net/sfc: rename version map file Bruce Richardson
2018-02-03 13:46 ` [dpdk-dev] [PATCH v2 " Andrew Rybchenko
2018-02-03 13:46 ` [dpdk-dev] [PATCH v2 2/2] net/sfc: add support for meson build Andrew Rybchenko
2018-02-05 12:30 ` Bruce Richardson
2018-02-05 12:33 ` Andrew Rybchenko
2018-02-05 14:00 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180205140040.GA20884@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ivan.malov@oktetlabs.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).