From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
dev@dpdk.org, Luca Boccassi <bluca@debian.org>,
Christian Ehrhardt <christian.ehrhardt@canonical.com>
Subject: Re: [dpdk-dev] [RFC] config: remove RTE_NEXT_ABI
Date: Thu, 8 Mar 2018 14:40:39 -0500 [thread overview]
Message-ID: <20180308194039.GB32578@hmswarspite.think-freely.org> (raw)
In-Reply-To: <4097404.y7j9CXhnSi@xps>
On Thu, Mar 08, 2018 at 05:04:01PM +0100, Thomas Monjalon wrote:
> 08/03/2018 16:35, Neil Horman:
> > On Thu, Mar 08, 2018 at 04:17:00PM +0100, Thomas Monjalon wrote:
> > > 08/03/2018 12:43, Ferruh Yigit:
> > > > On 3/8/2018 8:05 AM, Thomas Monjalon wrote:
> > > > > 07/03/2018 18:44, Ferruh Yigit:
> > > > >> After experimental API process defined do we still need RTE_NEXT_ABI
> > > > >> config and process which has similar targets?
> > > > >
> > > > > They are different targets.
> > > > > Experimental API is always enabled but may be avoided by applications.
> > > > > Next ABI can be used to break ABI without notice and disabled to keep
> > > > > old ABI compatibility. It is almost never used because it is preferred
> > > > > to keep ABI compatibility with rte_compat macros, or wait a deprecation
> > > > > period after notice.
> > > >
> > > > OK, I see.
> > > >
> > > > Shouldn't we disable it by default at least? Otherwise who is not paying
> > > > attention to this config option will get and ABI/API break.
> > >
> > > Yes I think you are right, it can be disabled by default.
> > >
> > I would agree, there seems to be overlap here, and the experimental tagging can
> > cover what the NEXT_API flag is meant to do. It can be removed I think.
>
> It is not NEXT_API but NEXT_ABI.
Sorry, typo, though I'm sure you got that, since the former doesn't exist,
right?
> Why do you think it overlaps experimental API tagging?
I assert that because the compat lib has macros to map common symbols to version
specific ones. That is to say, if you change a data structure, you can setup
the API calls that use said structure such that version 1 or the symbol maps to
an internal function that uses the old structure, while version 2 maps to an
internal function that uses the new symbol
That is to say, if you're planning on introducing ABI changes, the experimental
API tagging can be used to implement what the NEXT_ABI macro does.
Neil
>
>
>
next prev parent reply other threads:[~2018-03-08 19:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 17:44 Ferruh Yigit
2018-03-07 18:06 ` Luca Boccassi
2018-03-08 8:05 ` Thomas Monjalon
2018-03-08 11:43 ` Ferruh Yigit
2018-03-08 15:17 ` Thomas Monjalon
2018-03-08 15:35 ` Neil Horman
2018-03-08 16:04 ` Thomas Monjalon
2018-03-08 19:40 ` Neil Horman [this message]
2018-03-08 21:34 ` Thomas Monjalon
2018-03-09 0:18 ` Neil Horman
2018-10-04 15:43 ` [dpdk-dev] [PATCH] config: disable RTE_NEXT_ABI by default Ferruh Yigit
2018-10-04 14:49 ` Luca Boccassi
2018-10-04 15:48 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2018-10-04 15:10 ` Thomas Monjalon
2018-10-04 15:28 ` Ferruh Yigit
2018-10-04 15:55 ` Thomas Monjalon
2018-10-05 9:13 ` Bruce Richardson
2018-10-05 10:17 ` Ferruh Yigit
2018-10-05 11:30 ` Neil Horman
2018-10-05 12:35 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308194039.GB32578@hmswarspite.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=bluca@debian.org \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).