From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Pascal Mazon <pascal.mazon@6wind.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] lib: move Netlink code into a common library
Date: Tue, 13 Mar 2018 15:58:54 +0100 [thread overview]
Message-ID: <20180313145854.zrltyfs3xzm7usyx@laranjeiro-vm.dev.6wind.com> (raw)
In-Reply-To: <20180313135828.GA4612@bricha3-MOBL3.ger.corp.intel.com>
On Tue, Mar 13, 2018 at 01:58:28PM +0000, Bruce Richardson wrote:
> On Tue, Mar 13, 2018 at 01:28:26PM +0100, Nelio Laranjeiro wrote:
> > Moves TAP PMD generic Netlink library into lib directory to let other PMD
> > use Netlink to communicate with kernel.
> >
> > As this library uses a socket to communicate with Netlink it does not bring
> > any dependency on the libnl.
> >
> > Cc: Pascal Mazon <pascal.mazon@6wind.com>
> >
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> > ---
> > MAINTAINERS | 3 +
> > config/common_base | 6 ++
> > config/common_linuxapp | 1 +
> > drivers/net/tap/Makefile | 3 +-
> > drivers/net/tap/rte_eth_tap.c | 16 +--
> > drivers/net/tap/tap_flow.c | 118 ++++++++++-----------
> > drivers/net/tap/tap_netlink.h | 42 --------
> > drivers/net/tap/tap_tcmsgs.c | 28 ++---
> > drivers/net/tap/tap_tcmsgs.h | 2 +-
> > lib/Makefile | 2 +
> > lib/librte_netlink/Makefile | 26 +++++
> > lib/librte_netlink/meson.build | 13 +++
> > .../librte_netlink/rte_netlink.c | 42 ++++----
> > lib/librte_netlink/rte_netlink.h | 42 ++++++++
> > lib/librte_netlink/rte_netlink_version.map | 17 +++
> > lib/meson.build | 2 +-
> > mk/rte.app.mk | 1 +
> > 17 files changed, 216 insertions(+), 148 deletions(-)
> > delete mode 100644 drivers/net/tap/tap_netlink.h
> > create mode 100644 lib/librte_netlink/Makefile
> > create mode 100644 lib/librte_netlink/meson.build
> > rename drivers/net/tap/tap_netlink.c => lib/librte_netlink/rte_netlink.c (88%)
> > create mode 100644 lib/librte_netlink/rte_netlink.h
> > create mode 100644 lib/librte_netlink/rte_netlink_version.map
> >
>
> <snip>
>
> > diff --git a/lib/librte_netlink/meson.build b/lib/librte_netlink/meson.build
> > new file mode 100644
> > index 000000000..77592c7d4
> > --- /dev/null
> > +++ b/lib/librte_netlink/meson.build
> > @@ -0,0 +1,13 @@
> > +# SPDX-License-Identifier: BSD-3-Clause
> > +# Copyright 2018 6WIND S.A.
> > +# Copyright 2018 Mellanox Technologies, Ltd.
> > +
> > +
> > +name = 'netlink'
> > +version = 1
>
> Not a big issue, but the above two lines are unnecessary, and can be
> omitted. I'd rather than the name of the lib *not* be explicitly called
> out, to prevent the temptation of giving the library a different name to
> the name of the directory it is in.
>
> > +allow_experimental_apis = true
> > +sources = files('rte_netlink.c',)
> > +
> > +headers = files('rte_netlink.h')
> > +
> > +deps += ['net']
>
> <snip>
>
> > diff --git a/lib/meson.build b/lib/meson.build
> > index ef6159170..873a39785 100644
> > --- a/lib/meson.build
> > +++ b/lib/meson.build
> > @@ -23,7 +23,7 @@ libraries = [ 'compat', # just a header, used for versioning
> > # add pkt framework libs which use other libs from above
> > 'port', 'table', 'pipeline',
> > # flow_classify lib depends on pkt framework table lib
> > - 'flow_classify']
> > + 'flow_classify', 'netlink']
>
> Given that this doesn't depend on anything apart from the core libs,
> I think it should be placed earlier in the list, where the majority of
> the libs are in alphabetical order. [Yes, I should have put a comment
> just before the "acl" lib entry calling out the fact that it was meant
> to be an alphabetical list - I forgot, sorry! :-)]
>
> /Bruce
Hi Bruce,
I will modify it for the v2.
Thanks,
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2018-03-13 15:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 12:28 [dpdk-dev] [PATCH 0/2] lib: move Netlink wrapper to lib Nelio Laranjeiro
2018-03-13 12:28 ` [dpdk-dev] [PATCH 1/2] lib: move Netlink code into a common library Nelio Laranjeiro
2018-03-13 13:58 ` Bruce Richardson
2018-03-13 14:58 ` Nélio Laranjeiro [this message]
2018-03-13 12:28 ` [dpdk-dev] [PATCH 2/2] lib: add request Netlink messages Nelio Laranjeiro
2018-03-13 21:20 ` [dpdk-dev] [PATCH 0/2] lib: move Netlink wrapper to lib Stephen Hemminger
2018-03-14 12:08 ` Nélio Laranjeiro
2018-03-14 15:17 ` Stephen Hemminger
2018-03-15 15:39 ` Thomas Monjalon
2018-03-15 16:19 ` Nélio Laranjeiro
2018-03-15 16:26 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313145854.zrltyfs3xzm7usyx@laranjeiro-vm.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=pascal.mazon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).