From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
To: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,
jerin.jacob@caviumnetworks.com, nipun.gupta@nxp.com,
hemant.agrawal@nxp.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v7 5/7] test: add event timer adapter auto-test
Date: Wed, 14 Mar 2018 19:01:04 +0530 [thread overview]
Message-ID: <20180314133103.GB27234@ltp-pvn> (raw)
In-Reply-To: <1520546046-6973-6-git-send-email-erik.g.carrillo@intel.com>
Hi Gabriel,
Please make sure that the unit tests are generic, I could see that some places
it is verifying whether event port is used or service cores are used, but
doesn't verify if actually event port/service core are needed i.e.
INTERNAL_PORT capability.
On Thu, Mar 08, 2018 at 03:54:04PM -0600, Erik Gabriel Carrillo wrote:
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---
> test/test/Makefile | 1 +
> test/test/test_event_timer_adapter.c | 1234 ++++++++++++++++++++++++++++++++++
> 2 files changed, 1235 insertions(+)
> create mode 100644 test/test/test_event_timer_adapter.c
>
<snip>
> +
> +/* This port conf callback is used by the max adapter instance creation test.
> + * Because that test may be limited by the number of ports available in the
> + * event device, this callback allocates just one port and returns it each
> + * time a port is requested.
> + */
> +static int
> +test_port_conf_cb(uint16_t id, uint8_t event_dev_id, uint8_t *event_port_id,
> + void *conf_arg)
> +{
> + struct rte_eventdev *dev;
> + struct rte_event_dev_config dev_conf;
> + struct rte_event_port_conf *port_conf, def_port_conf = {0};
> + int started;
> + static int port_allocated;
> + static uint8_t port_id;
> + uint8_t dev_id;
> + int ret;
> +
> + if (port_allocated) {
> + *event_port_id = port_id;
> + return 0;
> + }
> +
> + RTE_SET_USED(id);
> +
> + dev = &rte_eventdevs[event_dev_id];
I don't think this is the correct way of accessing event dev information i.e.
accessing the global rte_eventdevs structure from a application.
> + dev_id = dev->data->dev_id;
> + dev_conf = dev->data->dev_conf;
> +
> + started = dev->data->dev_started;
> + if (started)
> + rte_event_dev_stop(dev_id);
> +
> + port_id = dev_conf.nb_event_ports;
> + dev_conf.nb_event_ports += 1;
> + ret = rte_event_dev_configure(dev_id, &dev_conf);
> + if (ret < 0) {
> + if (started)
> + rte_event_dev_start(dev_id);
Shouldn't this be !started ?. The same pattern repeats a few places.
> +
> + return ret;
> + }
> +
> + if (conf_arg != NULL)
> + port_conf = conf_arg;
> + else {
> + port_conf = &def_port_conf;
> + ret = rte_event_port_default_conf_get(dev_id, port_id,
> + port_conf);
> + if (ret < 0)
> + return ret;
> + }
> +
> + ret = rte_event_port_setup(dev_id, port_id, port_conf);
> + if (ret < 0)
> + return ret;
> +
> + *event_port_id = port_id;
> +
> + if (started)
> + rte_event_dev_start(dev_id);
> +
> + port_allocated = 1;
> +
> + return 0;
> +}
<snip>
Thanks,
Pavan.
next prev parent reply other threads:[~2018-03-14 13:31 UTC|newest]
Thread overview: 133+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1511890148-22295-1-git-send-email-erik.g.carrillo@intel.com>
2017-12-01 20:00 ` [dpdk-dev] [RFC PATCH v5 0/5] eventtimer: introduce event timer adapter Erik Gabriel Carrillo
2017-12-01 20:00 ` [dpdk-dev] [RFC PATCH v5 1/5] " Erik Gabriel Carrillo
2017-12-06 15:17 ` Jerin Jacob
2017-12-06 16:23 ` Carrillo, Erik G
2017-12-01 20:00 ` [dpdk-dev] [RFC PATCH v5 2/5] eventtimer: add common code Erik Gabriel Carrillo
2017-12-06 15:35 ` Jerin Jacob
2017-12-01 20:00 ` [dpdk-dev] [RFC PATCH v5 3/5] eventtimer: add config variable for adapter Erik Gabriel Carrillo
2017-12-06 15:41 ` Jerin Jacob
2017-12-06 20:01 ` Carrillo, Erik G
2017-12-01 20:00 ` [dpdk-dev] [RFC PATCH v5 4/5] eventtimer: add default software implementation stub Erik Gabriel Carrillo
2017-12-01 20:00 ` [dpdk-dev] [RFC PATCH v5 5/5] test: add event timer adapter auto-test Erik Gabriel Carrillo
2018-01-11 0:20 ` [dpdk-dev] [PATCH v6 00/23] eventtimer: introduce event timer adapter Erik Gabriel Carrillo
2018-01-11 0:20 ` [dpdk-dev] [PATCH v6 01/23] eventtimer: add event timer adapter API Erik Gabriel Carrillo
2018-01-11 11:10 ` Pavan Nikhilesh
2018-01-11 16:56 ` Carrillo, Erik G
2018-01-11 17:31 ` Pavan Nikhilesh
2018-01-11 0:20 ` [dpdk-dev] [PATCH v6 02/23] eventtimer: add common code Erik Gabriel Carrillo
2018-01-11 0:20 ` [dpdk-dev] [PATCH v6 03/23] eventtimer: add default software driver stub Erik Gabriel Carrillo
2018-01-11 0:20 ` [dpdk-dev] [PATCH v6 04/23] test: add event timer adapter auto-test Erik Gabriel Carrillo
2018-01-11 0:20 ` [dpdk-dev] [PATCH v6 05/23] eventtimer: add adapter allocation definitions Erik Gabriel Carrillo
2018-01-11 11:18 ` Pavan Nikhilesh
2018-01-11 0:20 ` [dpdk-dev] [PATCH v6 06/23] test: exercise event timer adapter allocation functions Erik Gabriel Carrillo
2018-01-11 0:20 ` [dpdk-dev] [PATCH v6 07/23] eventtimer: add adapter get info function definition Erik Gabriel Carrillo
2018-01-11 0:20 ` [dpdk-dev] [PATCH v6 08/23] eventtimer: add adapter start/stop definitions Erik Gabriel Carrillo
2018-01-11 17:28 ` Pavan Nikhilesh
2018-01-18 23:57 ` Carrillo, Erik G
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 09/23] eventtimer: add API to get service id Erik Gabriel Carrillo
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 10/23] eventtimer: remove service id entry from info structure Erik Gabriel Carrillo
2018-01-11 11:34 ` Pavan Nikhilesh
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 11/23] test: exercise event timer adapter start/stop functions Erik Gabriel Carrillo
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 12/23] eventtimer: add event timer arm/cancel function definitions Erik Gabriel Carrillo
2018-01-11 11:38 ` Pavan Nikhilesh
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 13/23] eventtimer: add adapter service definition Erik Gabriel Carrillo
2018-01-11 12:03 ` Pavan Nikhilesh
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 14/23] eventtimer: add event timer initializer function Erik Gabriel Carrillo
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 15/23] eventtimer: add buffering of timer expiry events Erik Gabriel Carrillo
2018-01-11 12:18 ` Pavan Nikhilesh
2018-01-18 23:07 ` Carrillo, Erik G
2018-01-20 8:55 ` Pavan Nikhilesh
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 16/23] eventtimer: add stats to API Erik Gabriel Carrillo
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 17/23] eventtimer: add support for single-producer put mode Erik Gabriel Carrillo
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 18/23] eventtimer: add non-blocking mode for event timer operations Erik Gabriel Carrillo
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 19/23] test: exercise event timer arm and expiry Erik Gabriel Carrillo
2018-01-11 12:26 ` Pavan Nikhilesh
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 20/23] maintainers: add event timer adapter section Erik Gabriel Carrillo
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 21/23] doc: add event timer adapter to API index Erik Gabriel Carrillo
2018-01-12 11:12 ` Kovacevic, Marko
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 22/23] doc: add event timer adapter section to programmer's guide Erik Gabriel Carrillo
2018-01-11 15:26 ` Kovacevic, Marko
2018-01-11 0:21 ` [dpdk-dev] [PATCH v6 23/23] doc: add event timer adapter to release notes Erik Gabriel Carrillo
2018-01-12 10:48 ` Kovacevic, Marko
2018-03-08 21:53 ` [dpdk-dev] [PATCH v7 0/7] eventtimer: introduce event timer adapter Erik Gabriel Carrillo
2018-03-08 21:54 ` [dpdk-dev] [PATCH v7 1/7] eventtimer: add event timer adapter API Erik Gabriel Carrillo
2018-03-12 7:53 ` Jerin Jacob
2018-03-12 16:22 ` Carrillo, Erik G
2018-03-08 21:54 ` [dpdk-dev] [PATCH v7 2/7] eventtimer: add common code Erik Gabriel Carrillo
2018-03-12 8:11 ` Jerin Jacob
2018-03-08 21:54 ` [dpdk-dev] [PATCH v7 3/7] eventtimer: add default software driver Erik Gabriel Carrillo
2018-03-12 8:45 ` Jerin Jacob
2018-03-12 21:20 ` Carrillo, Erik G
2018-03-08 21:54 ` [dpdk-dev] [PATCH v7 4/7] eventtimer: add support for meson build system Erik Gabriel Carrillo
2018-03-08 21:54 ` [dpdk-dev] [PATCH v7 5/7] test: add event timer adapter auto-test Erik Gabriel Carrillo
2018-03-14 12:52 ` Pavan Nikhilesh
2018-03-14 21:42 ` Carrillo, Erik G
2018-03-14 13:31 ` Pavan Nikhilesh [this message]
2018-03-14 21:40 ` Carrillo, Erik G
2018-03-08 21:54 ` [dpdk-dev] [PATCH v7 6/7] doc: add event timer adapter section to programmer's guide Erik Gabriel Carrillo
2018-03-12 11:21 ` Jerin Jacob
2018-03-12 22:02 ` Carrillo, Erik G
2018-03-08 21:54 ` [dpdk-dev] [PATCH v7 7/7] doc: add event timer adapter documentation Erik Gabriel Carrillo
2018-03-12 11:28 ` Jerin Jacob
2018-03-29 21:27 ` [dpdk-dev] [PATCH v8 0/9] eventtimer: introduce event timer adapter Erik Gabriel Carrillo
2018-03-29 21:27 ` [dpdk-dev] [PATCH v8 1/9] " Erik Gabriel Carrillo
2018-03-29 21:27 ` [dpdk-dev] [PATCH v8 2/9] eventdev: convert to SPDX license tag in header Erik Gabriel Carrillo
2018-04-02 8:12 ` Jerin Jacob
2018-04-02 9:16 ` Hemant Agrawal
2018-03-29 21:27 ` [dpdk-dev] [PATCH v8 3/9] eventtimer: add common code Erik Gabriel Carrillo
2018-03-29 21:27 ` [dpdk-dev] [PATCH v8 4/9] mk: update library order in static build Erik Gabriel Carrillo
2018-03-29 21:27 ` [dpdk-dev] [PATCH v8 5/9] eventtimer: add default software driver Erik Gabriel Carrillo
2018-04-02 8:42 ` Jerin Jacob
2018-03-29 21:27 ` [dpdk-dev] [PATCH v8 6/9] eventtimer: add support for meson build system Erik Gabriel Carrillo
2018-03-29 21:27 ` [dpdk-dev] [PATCH v8 7/9] test: add event timer adapter auto-test Erik Gabriel Carrillo
2018-03-30 15:48 ` Bhagavatula, Pavan
2018-03-30 18:47 ` Carrillo, Erik G
2018-03-29 21:27 ` [dpdk-dev] [PATCH v8 8/9] doc: add event timer adapter section to programmer's guide Erik Gabriel Carrillo
2018-03-29 21:27 ` [dpdk-dev] [PATCH v8 9/9] doc: add event timer adapter documentation Erik Gabriel Carrillo
2018-04-02 19:39 ` [dpdk-dev] [PATCH v9 0/9] eventtimer: introduce event timer adapter Erik Gabriel Carrillo
2018-04-02 19:39 ` [dpdk-dev] [PATCH v9 1/9] " Erik Gabriel Carrillo
2018-04-02 23:25 ` Jerin Jacob
2018-04-02 19:39 ` [dpdk-dev] [PATCH v9 2/9] eventdev: convert to SPDX license tag in header Erik Gabriel Carrillo
2018-04-02 23:27 ` Jerin Jacob
2018-04-02 19:39 ` [dpdk-dev] [PATCH v9 3/9] eventtimer: add common code Erik Gabriel Carrillo
2018-04-02 23:35 ` Jerin Jacob
2018-04-03 18:38 ` Carrillo, Erik G
2018-04-02 19:39 ` [dpdk-dev] [PATCH v9 4/9] mk: update library order in static build Erik Gabriel Carrillo
2018-04-02 23:36 ` Jerin Jacob
2018-04-02 19:39 ` [dpdk-dev] [PATCH v9 5/9] eventtimer: add default software driver Erik Gabriel Carrillo
2018-04-03 9:59 ` Pavan Nikhilesh
2018-04-02 19:39 ` [dpdk-dev] [PATCH v9 6/9] eventtimer: add support for meson build system Erik Gabriel Carrillo
2018-04-02 19:39 ` [dpdk-dev] [PATCH v9 7/9] test: add event timer adapter auto-test Erik Gabriel Carrillo
2018-04-03 9:52 ` Pavan Nikhilesh
2018-04-02 19:39 ` [dpdk-dev] [PATCH v9 8/9] doc: add event timer adapter section to programmer's guide Erik Gabriel Carrillo
2018-04-03 0:00 ` Jerin Jacob
2018-04-02 19:39 ` [dpdk-dev] [PATCH v9 9/9] doc: add event timer adapter documentation Erik Gabriel Carrillo
2018-04-02 23:42 ` Jerin Jacob
2018-04-02 23:19 ` [dpdk-dev] [PATCH v9 0/9] eventtimer: introduce event timer adapter Jerin Jacob
2018-04-03 14:09 ` Carrillo, Erik G
2018-04-03 14:15 ` Jerin Jacob
2018-04-03 18:32 ` Carrillo, Erik G
2018-04-03 21:44 ` [dpdk-dev] [PATCH v10 " Erik Gabriel Carrillo
2018-04-03 21:44 ` [dpdk-dev] [PATCH v10 1/9] " Erik Gabriel Carrillo
2018-04-03 21:44 ` [dpdk-dev] [PATCH v10 2/9] eventdev: convert to SPDX license tag in header Erik Gabriel Carrillo
2018-04-03 21:44 ` [dpdk-dev] [PATCH v10 3/9] eventtimer: add common code Erik Gabriel Carrillo
2018-04-04 16:50 ` Pavan Nikhilesh
2018-04-03 21:44 ` [dpdk-dev] [PATCH v10 4/9] mk: update library order in static build Erik Gabriel Carrillo
2018-04-03 21:44 ` [dpdk-dev] [PATCH v10 5/9] eventtimer: add default software driver Erik Gabriel Carrillo
2018-04-03 21:44 ` [dpdk-dev] [PATCH v10 6/9] eventtimer: add support for meson build system Erik Gabriel Carrillo
2018-04-04 16:51 ` Pavan Nikhilesh
2018-04-03 21:44 ` [dpdk-dev] [PATCH v10 7/9] test: add event timer adapter auto-test Erik Gabriel Carrillo
2018-04-03 21:44 ` [dpdk-dev] [PATCH v10 8/9] doc: add event timer adapter section to programmer's guide Erik Gabriel Carrillo
2018-04-03 21:44 ` [dpdk-dev] [PATCH v10 9/9] doc: add event timer adapter documentation Erik Gabriel Carrillo
2018-04-04 2:31 ` [dpdk-dev] [PATCH v10 0/9] eventtimer: introduce event timer adapter Jerin Jacob
2018-04-04 21:51 ` [dpdk-dev] [PATCH v11 " Erik Gabriel Carrillo
2018-04-04 21:51 ` [dpdk-dev] [PATCH v11 1/9] " Erik Gabriel Carrillo
2018-04-04 21:51 ` [dpdk-dev] [PATCH v11 2/9] eventdev: convert to SPDX license tag in header Erik Gabriel Carrillo
2018-04-04 21:51 ` [dpdk-dev] [PATCH v11 3/9] eventtimer: add common code Erik Gabriel Carrillo
2018-04-04 21:51 ` [dpdk-dev] [PATCH v11 4/9] mk: update library order in static build Erik Gabriel Carrillo
2018-04-04 21:51 ` [dpdk-dev] [PATCH v11 5/9] eventtimer: add default software driver Erik Gabriel Carrillo
2018-04-04 21:51 ` [dpdk-dev] [PATCH v11 6/9] eventtimer: add support for meson build system Erik Gabriel Carrillo
2018-04-04 21:51 ` [dpdk-dev] [PATCH v11 7/9] test: add event timer adapter auto-test Erik Gabriel Carrillo
2018-04-04 21:51 ` [dpdk-dev] [PATCH v11 8/9] doc: add event timer adapter section to programmer's guide Erik Gabriel Carrillo
2018-04-04 21:51 ` [dpdk-dev] [PATCH v11 9/9] doc: add event timer adapter documentation Erik Gabriel Carrillo
2018-04-05 3:31 ` [dpdk-dev] [PATCH v11 0/9] eventtimer: introduce event timer adapter Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314133103.GB27234@ltp-pvn \
--to=pbhagavatula@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=nipun.gupta@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).