From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Xueming Li <xuemingl@mellanox.com>
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Shahaf Shuler <shahafs@mellanox.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix existing file remove
Date: Fri, 16 Mar 2018 11:57:18 +0100 [thread overview]
Message-ID: <20180316105718.cwbyod5k534uklru@laranjeiro-vm.dev.6wind.com> (raw)
In-Reply-To: <20180316102748.10864-1-xuemingl@mellanox.com>
On Fri, Mar 16, 2018 at 06:27:48PM +0800, Xueming Li wrote:
> Remove file detection before removing existing file.
>
The explanation can induce some misunderstandings, the fact is there is
no guarantee that the file won't be removed by an external
user/application in between the stat() and remove() syscalls.
As it cannot be done atomically there is no need to need to make such
verification, remove() will fail if the file does not exists anymore.
> Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file descriptor")
>
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
Unless the commit log which can explain why this move is made,
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
> drivers/net/mlx5/mlx5_socket.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_socket.c b/drivers/net/mlx5/mlx5_socket.c
> index 61c1a4a..fb80fb3 100644
> --- a/drivers/net/mlx5/mlx5_socket.c
> +++ b/drivers/net/mlx5/mlx5_socket.c
> @@ -32,7 +32,6 @@
> };
> int ret;
> int flags;
> - struct stat file_stat;
>
> /*
> * Initialise the socket to communicate with the secondary
> @@ -52,9 +51,7 @@
> goto out;
> snprintf(sun.sun_path, sizeof(sun.sun_path), "/var/tmp/%s_%d",
> MLX5_DRIVER_NAME, priv->primary_socket);
> - ret = stat(sun.sun_path, &file_stat);
> - if (!ret)
> - claim_zero(remove(sun.sun_path));
> + remove(sun.sun_path);
> ret = bind(priv->primary_socket, (const struct sockaddr *)&sun,
> sizeof(sun));
> if (ret < 0) {
> --
> 1.8.3.1
>
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2018-03-16 10:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 10:27 Xueming Li
2018-03-16 10:57 ` Nélio Laranjeiro [this message]
2018-03-16 15:22 ` [dpdk-dev] [PATCH v1] net/mlx5: fix existing file removal Xueming Li
2018-03-16 15:37 ` Nélio Laranjeiro
2018-03-19 9:13 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316105718.cwbyod5k534uklru@laranjeiro-vm.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=xuemingl@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).