From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH 2/2] net/mlx5: fix RSS key len query
Date: Mon, 26 Mar 2018 13:33:42 +0200 [thread overview]
Message-ID: <20180326113342.t673b6tgzy5qjuqu@laranjeiro-vm.dev.6wind.com> (raw)
In-Reply-To: <20180326101219.91229-2-shahafs@mellanox.com>
On Mon, Mar 26, 2018 at 01:12:19PM +0300, Shahaf Shuler wrote:
> The RSS key length returned by rte_eth_dev_info_get command was taken
> from the
> PMD private structure. This structure initialization was done only after
> the port configuration.
>
> Considering Mellanox device supports only 40B long RSS key, reporting
> the fixed number instead.
>
> Fixes: 29c1d8bb3e79 ("net/mlx5: handle a single RSS hash key for all protocols")
> Cc: stable@dpdk.org
> Cc: nelio.laranjeiro@6wind.com
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
> index 365101af9..b6f5101cf 100644
> --- a/drivers/net/mlx5/mlx5_ethdev.c
> +++ b/drivers/net/mlx5/mlx5_ethdev.c
> @@ -428,7 +428,7 @@ mlx5_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info)
> info->if_index = if_nametoindex(ifname);
> info->reta_size = priv->reta_idx_n ?
> priv->reta_idx_n : config->ind_table_max_size;
> - info->hash_key_size = priv->rss_conf.rss_key_len;
> + info->hash_key_size = rss_hash_default_key_len;
> info->speed_capa = priv->link_speed_capa;
> info->flow_type_rss_offloads = ~MLX5_RSS_HF_MASK;
> }
> --
> 2.12.0
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Regards,
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2018-03-26 11:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 10:12 [dpdk-stable] [PATCH 1/2] net/mlx5: enforce RSS key length limitation Shahaf Shuler
2018-03-26 10:12 ` [dpdk-stable] [PATCH 2/2] net/mlx5: fix RSS key len query Shahaf Shuler
2018-03-26 11:33 ` Nélio Laranjeiro [this message]
2018-03-26 11:17 ` [dpdk-stable] [PATCH 1/2] net/mlx5: enforce RSS key length limitation Nélio Laranjeiro
2018-03-27 5:55 ` Shahaf Shuler
2018-03-27 7:15 ` Nélio Laranjeiro
2018-03-28 6:08 ` [dpdk-stable] [dpdk-dev] " Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180326113342.t673b6tgzy5qjuqu@laranjeiro-vm.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).