From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 01/13] net/bonding: fix library version in meson build
Date: Tue, 27 Mar 2018 21:26:12 +0100 [thread overview]
Message-ID: <20180327202611.GA16780@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <1793816.7vs2QY3WLW@xps>
On Tue, Mar 27, 2018 at 06:43:48PM +0200, Thomas Monjalon wrote:
> > --- a/drivers/net/bonding/meson.build
> > +++ b/drivers/net/bonding/meson.build
> > @@ -2,6 +2,7 @@
> > # Copyright(c) 2017 Intel Corporation
> >
> > name = 'bond' #, james bond :-)
>
> Ah ah ah, I had missed this important comment!
>
> Unfortunately I think the real name is "bonding".
> Does it mean the full name should be james bonding?
>
Nope, the name of the driver when built is "bond", according to the old
build system anyway. The name of the directory is "bonding", hence the
override here.
ls x86_64-native-linuxapp-gcc/lib/librte_pmd_bond*
x86_64-native-linuxapp-gcc/lib/librte_pmd_bond.a
Ideally, I'd like to be able to get rid of that "name" parameter entirely,
if we can just rename all directories to match the driver names exactly. In
this case, if we do want the driver to be called librte_pmd_bonding.a/.so,
then we just remove this override.
/Bruce
next prev parent reply other threads:[~2018-03-27 20:26 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 11:26 [dpdk-dev] [PATCH 00/13] build: " Andrew Rybchenko
2018-03-20 11:26 ` [dpdk-dev] [PATCH 01/13] net/bonding: " Andrew Rybchenko
2018-03-23 21:31 ` Bruce Richardson
2018-03-27 16:43 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-03-27 20:26 ` Bruce Richardson [this message]
2018-03-20 11:26 ` [dpdk-dev] [PATCH 02/13] net/i40e: " Andrew Rybchenko
2018-03-23 21:32 ` Bruce Richardson
2018-03-20 11:26 ` [dpdk-dev] [PATCH 03/13] net/ixgbe: " Andrew Rybchenko
2018-03-23 21:37 ` Bruce Richardson
2018-03-20 11:26 ` [dpdk-dev] [PATCH 04/13] net/null: " Andrew Rybchenko
2018-03-23 21:37 ` Bruce Richardson
2018-03-20 11:26 ` [dpdk-dev] [PATCH 05/13] net/ring: " Andrew Rybchenko
2018-03-23 21:38 ` Bruce Richardson
2018-03-20 11:26 ` [dpdk-dev] [PATCH 06/13] bitratestats: " Andrew Rybchenko
2018-03-23 21:39 ` Bruce Richardson
2018-03-20 11:26 ` [dpdk-dev] [PATCH 07/13] cryptodev: " Andrew Rybchenko
2018-03-23 21:40 ` Bruce Richardson
2018-03-20 11:26 ` [dpdk-dev] [PATCH 08/13] eventdev: " Andrew Rybchenko
2018-03-23 21:40 ` Bruce Richardson
2018-03-20 11:26 ` [dpdk-dev] [PATCH 09/13] mempool: " Andrew Rybchenko
2018-03-23 21:41 ` Bruce Richardson
2018-03-20 11:26 ` [dpdk-dev] [PATCH 10/13] pdump: " Andrew Rybchenko
2018-03-23 21:42 ` Bruce Richardson
2018-03-20 11:26 ` [dpdk-dev] [PATCH 11/13] table: " Andrew Rybchenko
2018-03-23 21:42 ` Bruce Richardson
2018-03-20 11:26 ` [dpdk-dev] [PATCH 12/13] ethdev: " Andrew Rybchenko
2018-03-23 21:46 ` Bruce Richardson
2018-04-05 17:33 ` Ferruh Yigit
2018-03-20 11:26 ` [dpdk-dev] [PATCH 13/13] meter: " Andrew Rybchenko
2018-03-23 21:48 ` Bruce Richardson
2018-03-23 21:50 ` [dpdk-dev] [PATCH 00/13] build: " Bruce Richardson
2018-03-27 22:08 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327202611.GA16780@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).