DPDK patches and discussions
 help / color / mirror / Atom feed
From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>, Kumar A S <kumaras@chelsio.com>,
	Nirranjan Kirubaharan <nirranjan@chelsio.com>,
	Indranil Choudhury <indranil@chelsio.com>
Subject: Re: [dpdk-dev] [PATCH 00/13] cxgbe: add CXGBE VF PMD and updates
Date: Wed, 28 Mar 2018 13:09:34 +0530	[thread overview]
Message-ID: <20180328073933.GA19600@chelsio.com> (raw)
In-Reply-To: <DB7PR05MB44262EF3F2DD367CB0CD2D2DC3A30@DB7PR05MB4426.eurprd05.prod.outlook.com>

On Wednesday, March 03/28/18, 2018 at 10:19:17 +0530, Shahaf Shuler wrote:
> Tuesday, March 27, 2018 10:02 AM, Rahul Lakkireddy:
> 
> [...]
> 
> > > >
> > > > Patch 13 adds compile time option to keep outer vlan tag in Q-in-Q
> > > > packet.
> > >
> > > We are trying to reduce the config options, is it possible to provide
> > > this functionality with a runtime option (devargs) ?
> > >
> > 
> > Thank you for pointing to this. It seems like a good option.
> > 
> > > Or there is already an offload option DEV_RX_OFFLOAD_QINQ_STRIP, I
> > > guess this is different (is it?), if so does it make sense to have
> > > another offload option to cover your case?
> > >
> > >
> > 
> > Yes, this is different. Here, its about stripping or preserving Outer-VLAN tag
> > from double-vlan in Rx. We have few customers who need this for their use-
> > case. So, adding another offload option would also help. Let us know which is
> > preferred - either one, devargs OR another offload, seems fine.
> 
> What exactly is the offload you try to expose? To strip the inner VLAN while keeping the outer one? 
> 

Sorry about that, I should have provided more details on this earlier.
Chelsio hardware supports below for double-vlans:
1) Dropping Outer VLAN in hw; inner vlan is stripped and available as
packet metadata.
2) Preserving Outer VLAN so, Outer VLAN is stripped and available as
packet metadata. Inner VLAN is available as part of packet itself.

So, the configurability here is with respect to Outer VLAN and
subsequently what is available as part of packet metadata (outer or
inner vlan).  Inner VLAN gets retained in both cases.  However, based
on how Outer VLAN is configured, Inner VLAN will be available either
as packet metadata or as part of packet itself.

We are not very sure if DEV_RX_OFFLOAD_QINQ_STRIP could be used here.
If it holds the same meaning then we will use the same.

Thanks,
Rahul

  reply	other threads:[~2018-03-28  7:40 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-10 22:48 Rahul Lakkireddy
2018-03-10 22:48 ` [dpdk-dev] [PATCH 01/13] cxgbe: add skeleton VF driver Rahul Lakkireddy
2018-03-10 22:48 ` [dpdk-dev] [PATCH 02/13] cxgbe: add VF firmware mailbox support Rahul Lakkireddy
2018-03-10 22:48 ` [dpdk-dev] [PATCH 03/13] cxgbe: add base for enabling VF ports Rahul Lakkireddy
2018-03-10 22:48 ` [dpdk-dev] [PATCH 04/13] cxgbe: add probe to initialize VF devices Rahul Lakkireddy
2018-03-10 22:48 ` [dpdk-dev] [PATCH 05/13] cxgbe: initialize SGE and queues for VF Rahul Lakkireddy
2018-03-10 22:48 ` [dpdk-dev] [PATCH 06/13] cxgbe: enable RSS " Rahul Lakkireddy
2018-03-10 22:48 ` [dpdk-dev] [PATCH 07/13] cxgbe: update TX and RX path " Rahul Lakkireddy
2018-03-10 22:48 ` [dpdk-dev] [PATCH 08/13] cxgbe: add VF port statistics Rahul Lakkireddy
2018-03-10 22:48 ` [dpdk-dev] [PATCH 09/13] cxgbe: add support to set mac address Rahul Lakkireddy
2018-03-10 22:48 ` [dpdk-dev] [PATCH 10/13] cxgbe: fix check to close other ports properly Rahul Lakkireddy
2018-03-28 17:24   ` Ferruh Yigit
2018-03-10 22:48 ` [dpdk-dev] [PATCH 11/13] cxgbe: export supported RSS hash functions Rahul Lakkireddy
2018-03-28 17:25   ` Ferruh Yigit
2018-03-10 22:48 ` [dpdk-dev] [PATCH 12/13] cxgbe: convert to SPDX license tags Rahul Lakkireddy
2018-03-10 22:48 ` [dpdk-dev] [PATCH 13/13] cxgbe: add option to keep outer VLAN tag in Q-in-Q Rahul Lakkireddy
2018-03-26 20:51 ` [dpdk-dev] [PATCH 00/13] cxgbe: add CXGBE VF PMD and updates Ferruh Yigit
2018-03-27  7:01   ` Rahul Lakkireddy
2018-03-27 17:26     ` Ferruh Yigit
2018-03-28  7:44       ` Rahul Lakkireddy
2018-03-28  4:49     ` Shahaf Shuler
2018-03-28  7:39       ` Rahul Lakkireddy [this message]
2018-03-28  8:30         ` Shahaf Shuler
2018-03-28  9:29           ` Rahul Lakkireddy
2018-03-28 14:06             ` Ferruh Yigit
2018-03-28 17:25 ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180328073933.GA19600@chelsio.com \
    --to=rahul.lakkireddy@chelsio.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=indranil@chelsio.com \
    --cc=kumaras@chelsio.com \
    --cc=nirranjan@chelsio.com \
    --cc=shahafs@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).