From: Olivier Matz <olivier.matz@6wind.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 4/4] eal: set affinity for control threads
Date: Fri, 30 Mar 2018 09:30:01 +0200 [thread overview]
Message-ID: <20180330073001.c73c42dvtqq5lc6g@platinum> (raw)
In-Reply-To: <73aaaffb-053d-b8d1-623b-a1dfdc67adc2@intel.com>
On Thu, Mar 29, 2018 at 09:04:52AM +0100, Burakov, Anatoly wrote:
> On 27-Feb-18 2:46 PM, Olivier Matz wrote:
> > The management threads must not bother the dataplane or service cores.
> > Set the affinity of these threads accordingly.
> >
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > ---
>
> <...>
>
> > + set_affinity = 0;
> > + CPU_ZERO(&cpuset);
> > + for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
> > + if (eal_cpu_detected(lcore_id) &&
> > + rte_lcore_has_role(lcore_id, ROLE_OFF)) {
> > + CPU_SET(lcore_id, &cpuset);
> > + set_affinity = 1;
> > + }
> > + }
> > + if (set_affinity) {
> > + ret = pthread_setaffinity_np(*thread, sizeof(cpuset), &cpuset);
> > + if (ret < 0)
> > + goto fail;
> > + }
>
> Hi Olivier,
>
> Please correct me if i'm wrong here, but if all detected cores are busy
> doing something (such as would be the case if DPDK is run without a coremask
> specified), affinity is not set? Maybe set it to master lcore instead
> (perhaps unconditionally - we usually recommend not using master lcore for
> anything important - perhaps setting it to master core always would be
> better, instead of trying to find unused lcores)?
Good point and good idea, I will update the patchset.
Thanks,
Olivier
next prev parent reply other threads:[~2018-03-30 7:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 10:26 [dpdk-dev] [RFC 0/4] new function to create " Olivier Matz
2017-12-08 10:26 ` [dpdk-dev] [RFC 1/4] eal: use sizeof to avoid a double use of a define Olivier Matz
2017-12-08 10:26 ` [dpdk-dev] [RFC 2/4] eal: new function to create control threads Olivier Matz
2017-12-08 10:26 ` [dpdk-dev] [RFC 3/4] eal: set name when creating a control thread Olivier Matz
2017-12-08 10:26 ` [dpdk-dev] [RFC 4/4] eal: set affinity for control threads Olivier Matz
2018-02-27 14:46 ` [dpdk-dev] [PATCH 0/4] fix control thread affinities Olivier Matz
2018-02-27 14:46 ` [dpdk-dev] [PATCH 1/4] eal: use sizeof to avoid a double use of a define Olivier Matz
2018-02-27 14:46 ` [dpdk-dev] [PATCH 2/4] eal: new function to create control threads Olivier Matz
2018-02-27 14:46 ` [dpdk-dev] [PATCH 3/4] eal: set name when creating a control thread Olivier Matz
2018-02-27 14:46 ` [dpdk-dev] [PATCH 4/4] eal: set affinity for control threads Olivier Matz
2018-03-29 8:04 ` Burakov, Anatoly
2018-03-30 7:30 ` Olivier Matz [this message]
2018-03-28 12:54 ` [dpdk-dev] [PATCH 0/4] fix control thread affinities Olivier Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180330073001.c73c42dvtqq5lc6g@platinum \
--to=olivier.matz@6wind.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).