From: Neil Horman <nhorman@tuxdriver.com>
To: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
Cc: Tonghao Zhang <xiangxia.m.yue@gmail.com>,
Timothy Redaelli <tredaelli@redhat.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] Build is broken in dpdk-next-net
Date: Sat, 31 Mar 2018 11:27:55 -0400 [thread overview]
Message-ID: <20180331152755.GA3261@neilslaptop.think-freely.org> (raw)
In-Reply-To: <20180331150947.5ob35sxk2iw4f4fq@bidouze.vm.6wind.com>
On Sat, Mar 31, 2018 at 05:09:47PM +0200, Gaëtan Rivet wrote:
> On Sat, Mar 31, 2018 at 09:33:43AM -0400, Neil Horman wrote:
> > On Fri, Mar 30, 2018 at 10:47:09PM +0800, Tonghao Zhang wrote:
> > > I rebuild it on ubuntu 17.10 and cash it. I use the 'RTE_SET_USED' to fix it.
> > >
> > >
> > > diff --git a/lib/librte_vhost/fd_man.c b/lib/librte_vhost/fd_man.c
> > > index 771675718..f11803191 100644
> > > --- a/lib/librte_vhost/fd_man.c
> > > +++ b/lib/librte_vhost/fd_man.c
> > > @@ -279,7 +279,8 @@ fdset_pipe_read_cb(int readfd, void *dat __rte_unused,
> > > int *remove __rte_unused)
> > > {
> > > char charbuf[16];
> > > - read(readfd, charbuf, sizeof(charbuf));
> > > + int r = read(readfd, charbuf, sizeof(charbuf));
> > > + RTE_SET_USED(r);
> > > }
> > >
> > > void
> > > @@ -319,5 +320,6 @@ fdset_pipe_init(struct fdset *fdset)
> > > void
> > > fdset_pipe_notify(struct fdset *fdset)
> > > {
> > > - write(fdset->u.writefd, "1", 1);
> > > + int r = write(fdset->u.writefd, "1", 1);
> > > + RTE_SET_USED(r);
> > > }
> > >
> >
> > A better option might be to use _Pragma
> >
> > Something like this perhaps
> >
> > #define ALLOW_UNUSED(x) \
> > _Pragma(push) \
> > _Pragma(diagnostic ignored "-Wunused-result") \
> > #x;\
> > _Pragma(pop)
> >
> > This is of course untested, so it probably needs some tweaking, but this method
> > avoids the need to declare an additional stack variable, which i don't think can
> > be eliminated due to the cast. I believe that this method should also work
> > accross compilers (the gcc and clang compilers support this, and i think the
> > intel compiler should as well)
> >
> > Neil
> >
>
> It would be nice to avoid the definition of a useless variable.
> An alternative could be
>
> if (read() < 0) {
> /* Failure here is acceptable for such and such reason. */
> }
>
> to ensure all-around compatibility, and the definition or another macro.
> Just a suggestion.
>
That would be a good alternative, but I think its effectiveness is dependent on
when the compiler does with the return value check. Without any code inside the
conditional, the compiler may optimize the check out, meaning the warning will
still be asserted. If it doesn't optimize the check out, then you have a
useless compare and jump instruction left in the code path.
Best
Neil
next prev parent reply other threads:[~2018-03-31 15:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 13:18 Andrew Rybchenko
2018-03-30 13:27 ` Maxime Coquelin
2018-03-30 14:13 ` Ferruh Yigit
2018-03-30 14:16 ` Tonghao Zhang
2018-03-30 14:17 ` Maxime Coquelin
2018-03-30 14:28 ` Timothy Redaelli
2018-03-30 14:47 ` Tonghao Zhang
2018-03-30 14:59 ` Maxime Coquelin
2018-03-30 15:02 ` Tonghao Zhang
2018-03-31 13:33 ` Neil Horman
2018-03-31 15:09 ` Gaëtan Rivet
2018-03-31 15:27 ` Neil Horman [this message]
2018-03-31 16:21 ` Gaëtan Rivet
2018-03-31 18:48 ` Neil Horman
2018-04-02 16:25 ` Stephen Hemminger
2018-04-03 8:31 ` Maxime Coquelin
2018-04-03 10:13 ` Thomas Monjalon
2018-04-03 10:41 ` Neil Horman
2018-04-03 13:14 ` Wiles, Keith
2018-03-30 14:55 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180331152755.GA3261@neilslaptop.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=maxime.coquelin@redhat.com \
--cc=thomas@monjalon.net \
--cc=tredaelli@redhat.com \
--cc=xiangxia.m.yue@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).