From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: "Mattias Rönnblom" <hofors@lysator.liu.se>
Cc: dev@dpdk.org, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH] eventdev: fix incorrect MP/MC tail updates in rte_event_ring
Date: Wed, 4 Apr 2018 06:22:26 +0530 [thread overview]
Message-ID: <20180404005225.GB3031@jerin> (raw)
In-Reply-To: <1522743543-7974-1-git-send-email-hofors@lysator.liu.se>
-----Original Message-----
> Date: Tue, 3 Apr 2018 10:19:03 +0200
> From: Mattias Rönnblom <hofors@lysator.liu.se>
> To: dev@dpdk.org
> CC: jerin.jacob@caviumnetworks.com, Mattias Rönnblom
> <hofors@lysator.liu.se>, bruce.richardson@intel.com
> Subject: [PATCH] eventdev: fix incorrect MP/MC tail updates in
> rte_event_ring
> X-Mailer: git-send-email 2.7.4
>
> rte_event_ring enqueue and dequeue tail updates were hardcoded for a
> SC/SP configuration.
>
> Fixes: dc39e2f359b5 ("eventdev: add ring structure for events")
> Cc: bruce.richardson@intel.com
Bruce,
As an original author of this file, Can you review this change?
>
> Signed-off-by: Mattias Rönnblom <hofors@lysator.liu.se>
>
> v2:
> * Fixed issue with update_tail() parameter order.
> ---
> lib/librte_eventdev/rte_event_ring.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_eventdev/rte_event_ring.h b/lib/librte_eventdev/rte_event_ring.h
> index 29d4228..827a320 100644
> --- a/lib/librte_eventdev/rte_event_ring.h
> +++ b/lib/librte_eventdev/rte_event_ring.h
> @@ -99,7 +99,7 @@ rte_event_ring_enqueue_burst(struct rte_event_ring *r,
>
> ENQUEUE_PTRS(&r->r, &r[1], prod_head, events, n, struct rte_event);
>
> - update_tail(&r->r.prod, prod_head, prod_next, 1, 1);
> + update_tail(&r->r.prod, prod_head, prod_next, r->r.prod.single, 1);
> end:
> if (free_space != NULL)
> *free_space = free_entries - n;
> @@ -140,7 +140,7 @@ rte_event_ring_dequeue_burst(struct rte_event_ring *r,
>
> DEQUEUE_PTRS(&r->r, &r[1], cons_head, events, n, struct rte_event);
>
> - update_tail(&r->r.cons, cons_head, cons_next, 1, 0);
> + update_tail(&r->r.cons, cons_head, cons_next, r->r.cons.single, 0);
>
> end:
> if (available != NULL)
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-04-04 0:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 9:16 Mattias Rönnblom
2018-03-29 12:38 ` Van Haaren, Harry
2018-04-02 2:55 ` Jerin Jacob
2018-04-03 8:14 ` Mattias Rönnblom
2018-04-03 8:19 ` Mattias Rönnblom
2018-04-04 0:52 ` Jerin Jacob [this message]
2018-04-04 8:52 ` Bruce Richardson
2018-04-04 9:46 ` Jerin Jacob
2018-04-04 10:36 ` Van Haaren, Harry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180404005225.GB3031@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hofors@lysator.liu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).