From: Hyong Youb Kim <hyonkim@cisco.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: John Daley <johndale@cisco.com>,
dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] net/enic: enable overlay offload for VXLAN and GENEVE
Date: Sat, 7 Apr 2018 11:40:23 +0900 [thread overview]
Message-ID: <20180407024022.GA13524@HYONKIM-FTCPE.cisco.com> (raw)
In-Reply-To: <d8a16fa3-d19a-341b-909e-ffb54b9b2b3c@intel.com>
On Fri, Apr 06, 2018 at 05:15:40PM +0100, Ferruh Yigit wrote:
> On 4/5/2018 12:54 AM, John Daley wrote:
> > From: Hyong Youb Kim <hyonkim@cisco.com>
> >
> > Recent NIC models support overlay offload. The overlay offload
> > feature enables the following on the NIC.
> > - Rx/Tx checksum offloads for both inner and outer packets.
> > - Rx inner packet type classification.
> > - TSO.
> > - Inner RSS.
> >
> > TX descriptors do not require any changes, except the header length
> > for TSO. The NIC parses outer/inner packets and performs offloads on
> > them as necessary. The header length for tunneled TSO includes both
> > inner and outer headers.
> >
> > The NIC actually parses and performs the above for NVGRE as well. DPDK
> > currently has no offload flags for NVGRE, and the hardware has no
> > controls to individually enable tunnel types either. So do nothing for
> > now.
> >
> > Add a config flag to enable overlay offload by default. To disable it,
> > the user should set it to 'n'.
> >
> > CONFIG_RTE_LIBRTE_ENIC_ENABLE_OVERLAY_OFFLOAD=y
> >
> > Also update the enic guide doc.
> >
> > Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
> > Reviewed-by: John Daley <johndale@cisco.com>
> > ---
> > config/common_base | 1 +
> > doc/guides/nics/enic.rst | 52 ++++++++++++++++++
> > drivers/net/enic/base/vnic_dev.c | 33 ++++++++++++
> > drivers/net/enic/base/vnic_dev.h | 5 +-
> > drivers/net/enic/base/vnic_devcmd.h | 12 +++++
> > drivers/net/enic/base/vnic_wq.h | 1 +
> > drivers/net/enic/enic.h | 6 +++
> > drivers/net/enic/enic_ethdev.c | 21 ++------
> > drivers/net/enic/enic_main.c | 25 +++++++++
> > drivers/net/enic/enic_res.c | 23 ++++++++
> > drivers/net/enic/enic_rxtx.c | 104 ++++++++++++++++++++++++++++--------
> > 11 files changed, 241 insertions(+), 42 deletions(-)
> >
> > diff --git a/config/common_base b/config/common_base
> > index c09c7cf88..964e37b6e 100644
> > --- a/config/common_base
> > +++ b/config/common_base
> > @@ -205,6 +205,7 @@ CONFIG_RTE_LIBRTE_ENA_COM_DEBUG=n
> > # Compile burst-oriented Cisco ENIC PMD driver
> > #
> > CONFIG_RTE_LIBRTE_ENIC_PMD=y
> > +CONFIG_RTE_LIBRTE_ENIC_ENABLE_OVERLAY_OFFLOAD=y
>
> Hi John,
>
> We are trying to reduce config options we have, is overlay offload enabling can
> be done via runtime argument or dedicated offload flag?
Hi,
Would you accept a devarg? We would enable overlay offload by default,
and disable it when the app specifies that devarg. This overlay
offload is a bunch of things under one roof, and it does not play
nicely with DPDK offload flags.
Thanks.
-Hyong
next prev parent reply other threads:[~2018-04-07 2:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 23:54 [dpdk-dev] [PATCH] net/enic: do not flush descriptor cache when opening vNIC John Daley
2018-04-04 23:54 ` [dpdk-dev] [PATCH] net/enic: enable overlay offload for VXLAN and GENEVE John Daley
2018-04-06 16:15 ` Ferruh Yigit
2018-04-07 2:40 ` Hyong Youb Kim [this message]
2018-04-09 12:52 ` Ferruh Yigit
2018-04-16 21:49 ` [dpdk-dev] [PATCH v2] " John Daley
2018-04-17 18:05 ` Ferruh Yigit
2018-04-04 23:54 ` [dpdk-dev] [PATCH] net/enic: support UDP RSS on 1400 series adapters John Daley
2018-04-06 16:41 ` Ferruh Yigit
2018-04-04 23:54 ` [dpdk-dev] [PATCH] net/enic: fix seg fault on MTU update with non-setup queues John Daley
2018-04-06 16:41 ` Ferruh Yigit
2018-04-04 23:54 ` [dpdk-dev] [PATCH] net/enic: support the drop flow action John Daley
2018-04-06 16:41 ` Ferruh Yigit
2018-04-04 23:54 ` [dpdk-dev] [PATCH] doc: update the enic guide and features John Daley
2018-04-06 16:42 ` Ferruh Yigit
2018-04-06 16:40 ` [dpdk-dev] [PATCH] net/enic: do not flush descriptor cache when opening vNIC Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180407024022.GA13524@HYONKIM-FTCPE.cisco.com \
--to=hyonkim@cisco.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=johndale@cisco.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).