From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: ferruh.yigit@intel.com, thomas@monjalon.net, dev@dpdk.org,
stable@dpdk.org, stephen@networkplumber.org
Subject: Re: [dpdk-stable] [PATCH] ethdev: fix link status query
Date: Tue, 10 Apr 2018 10:20:51 +0200 [thread overview]
Message-ID: <20180410082051.vhumihdzc3qhy7wy@laranjeiro-vm.dev.6wind.com> (raw)
In-Reply-To: <20180410061631.50301-1-shahafs@mellanox.com>
On Tue, Apr 10, 2018 at 09:16:31AM +0300, Shahaf Shuler wrote:
> When application works with LSC interrupts the ethdev layer skips
> the PMD callback and update according to the link status exists on
> device data. It is because it assumes the link status on the device data
> is the correct one since any link change is processed by the application.
>
> As multiple PMDs install the link status interrupt handler only on port
> start and uninstall it on port stop, the link status may be incorrect in
> case the query is called after port stop or before port start.
It seems also logical to not process interrupts from stopped device,
for them accessing to the link status should always end by calling the
devop function.
This patch is the result of discussion on thread [1].
> Fixing the query implementation to use the PMD callback for such cases.
>
> Fixes: b77d21cc2364 ("ethdev: add link status get/set helper functions")
> Cc: stable@dpdk.org
> Cc: stephen@networkplumber.org
> Cc: nelio.laranjeiro@6wind.com
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
> lib/librte_ether/rte_ethdev.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> index 2c74f7e049..0857670ebe 100644
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -1789,7 +1789,8 @@ rte_eth_link_get(uint16_t port_id, struct rte_eth_link *eth_link)
> RTE_ETH_VALID_PORTID_OR_RET(port_id);
> dev = &rte_eth_devices[port_id];
>
> - if (dev->data->dev_conf.intr_conf.lsc)
> + if (dev->data->dev_conf.intr_conf.lsc &&
> + dev->data->dev_started)
> rte_eth_linkstatus_get(dev, eth_link);
> else {
> RTE_FUNC_PTR_OR_RET(*dev->dev_ops->link_update);
> @@ -1806,7 +1807,8 @@ rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *eth_link)
> RTE_ETH_VALID_PORTID_OR_RET(port_id);
> dev = &rte_eth_devices[port_id];
>
> - if (dev->data->dev_conf.intr_conf.lsc)
> + if (dev->data->dev_conf.intr_conf.lsc &&
> + dev->data->dev_started)
> rte_eth_linkstatus_get(dev, eth_link);
> else {
> RTE_FUNC_PTR_OR_RET(*dev->dev_ops->link_update);
> --
> 2.12.0
>
Thanks,
[1] https://dpdk.org/ml/archives/dev/2018-April/094788.html
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2018-04-10 8:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 6:16 Shahaf Shuler
2018-04-10 8:20 ` Nélio Laranjeiro [this message]
2018-04-10 8:29 ` Thomas Monjalon
2018-04-10 18:34 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410082051.vhumihdzc3qhy7wy@laranjeiro-vm.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).