From: Bruce Richardson <bruce.richardson@intel.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: "herbert.guan@arm.com" <herbert.guan@arm.com>,
Shreyansh Jain <shreyansh.jain@nxp.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"pbhagavatula@caviumnetworks.com"
<pbhagavatula@caviumnetworks.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] build: fix default arm64 build instruction level support
Date: Fri, 13 Apr 2018 16:42:54 +0100 [thread overview]
Message-ID: <20180413154253.GA37024@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <c29da7cc-b068-b26d-85f6-b3d5585f2f92@nxp.com>
On Wed, Apr 11, 2018 at 12:30:07PM +0530, Hemant Agrawal wrote:
>
>
> On 4/10/2018 7:49 PM, Richardson, Bruce wrote:
> > Resend, fixing "To" recipients.
> >
> > > -----Original Message-----
> > > From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> > > Sent: Tuesday, April 10, 2018 3:17 PM
> > > To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > Cc: dev@dpdk.org; herbert.guan@arm.com; pbhagavatula@caviumnetworks.com;
> > > hemant.agrawal@nxp.com; stable@dpdk.org; jerin.jacob@caviumnetworks.com
> > > Subject: Re: [dpdk-dev] [PATCH] build: fix default arm64 build instruction
> > > level support
> > >
> > > On Mon, Apr 09, 2018 at 08:09:46PM +0530, Jerin Jacob wrote:
> > > > The make based build system has crc+crypto instruction support for the
> > > > default arm64 build.
> > > > http://dpdk.org/browse/dpdk/tree/mk/machine/armv8a/rte.vars.mk#n31
> > > >
> > > > This patch fixes the disparity with meson build flags for armv8.
> > > > As a bonus, This patch fixes the following errors with ip_pipeline
> > > > example application.
> > > >
> > > > Assembler messages:
> > > > Error: selected processor does not support `crc32cx w3,w3,x0'
> > > >
> > > > Fixes: c6e536e38437 ("build: add more implementers IDs and PNs for
> > > > ARM")
> > > >
> > > > Cc: herbert.guan@arm.com
> > > > Cc: pbhagavatula@caviumnetworks.com
> > > > Cc: bruce.richardson@intel.com
> > > > Cc: hemant.agrawal@nxp.com
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > > ---
> > >
> > > Hemant, Shreyansh, Herbert,
> > >
> > > any issues with this patch on your side? Can one of you please ack it. It
> > > allows use of "-Dexamples=all" when doing cross-builds for all the
> > > different arm targets in the config dir. Without it, ip_pipeline fails to
> > > build for many of the targets.
> > >
> > > /Bruce
> >
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Applied to dpdk-next-build.
Thanks,
/Bruce
prev parent reply other threads:[~2018-04-13 15:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 14:39 Jerin Jacob
2018-04-09 15:42 ` Bruce Richardson
2018-04-10 14:16 ` Bruce Richardson
2018-04-10 14:19 ` Richardson, Bruce
2018-04-11 7:00 ` Hemant Agrawal
2018-04-13 15:42 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180413154253.GA37024@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=herbert.guan@arm.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=pbhagavatula@caviumnetworks.com \
--cc=shreyansh.jain@nxp.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).