From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: anatoly.burakov@intel.com, bruce.richardson@intel.com, jia.guo@intel.com
Subject: [dpdk-dev] [PATCH] eal/linux: use strlcpy in uevent parsing
Date: Tue, 17 Apr 2018 13:57:57 +0200 [thread overview]
Message-ID: <20180417115757.17633-1-thomas@monjalon.net> (raw)
Support of strlcpy has recently been added to DPDK.
This replacement has been generated by the coccinelle script:
devtools/cocci.sh devtools/cocci/strlcpy.cocci
Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process")
Cc: jia.guo@intel.com
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
lib/librte_eal/linuxapp/eal/eal_dev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_dev.c b/lib/librte_eal/linuxapp/eal/eal_dev.c
index 9478a39a5..d02bba11e 100644
--- a/lib/librte_eal/linuxapp/eal/eal_dev.c
+++ b/lib/librte_eal/linuxapp/eal/eal_dev.c
@@ -94,15 +94,15 @@ dev_uev_parse(const char *buf, struct rte_dev_event *event, int length)
if (!strncmp(buf, "ACTION=", 7)) {
buf += 7;
i += 7;
- snprintf(action, sizeof(action), "%s", buf);
+ strlcpy(action, buf, sizeof(action));
} else if (!strncmp(buf, "SUBSYSTEM=", 10)) {
buf += 10;
i += 10;
- snprintf(subsystem, sizeof(subsystem), "%s", buf);
+ strlcpy(subsystem, buf, sizeof(subsystem));
} else if (!strncmp(buf, "PCI_SLOT_NAME=", 14)) {
buf += 14;
i += 14;
- snprintf(pci_slot_name, sizeof(subsystem), "%s", buf);
+ strlcpy(pci_slot_name, buf, sizeof(subsystem));
event->devname = strdup(pci_slot_name);
}
for (; i < length; i++) {
--
2.16.2
next reply other threads:[~2018-04-17 11:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 11:57 Thomas Monjalon [this message]
2018-04-17 12:23 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2018-04-23 14:15 ` Bruce Richardson
2018-04-23 14:23 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180417115757.17633-1-thomas@monjalon.net \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).