From: Tomasz Duszynski <tdu@semihalf.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Tomasz Duszynski <tdu@semihalf.com>,
dev@dpdk.org, dima@marvell.com, nsamsono@marvell.com
Subject: Re: [dpdk-dev] [PATCH] net/mvpp2: get MUSDK library path from a meson option
Date: Thu, 19 Apr 2018 14:06:12 +0200 [thread overview]
Message-ID: <20180419120612.GA14506@sh> (raw)
In-Reply-To: <20180419120511.GA11352@bricha3-MOBL.ger.corp.intel.com>
On Thu, Apr 19, 2018 at 01:05:11PM +0100, Bruce Richardson wrote:
> On Thu, Apr 19, 2018 at 11:45:38AM +0200, Tomasz Duszynski wrote:
> > Since not cluttering environment and keeping all relevant
> > settings local to the cross build is reasonable get
> > MUSDK library installation path from a meson option.
> >
> > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> > ---
> > drivers/net/mvpp2/meson.build | 2 +-
> > meson_options.txt | 2 ++
> > 2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/mvpp2/meson.build b/drivers/net/mvpp2/meson.build
> > index 6ea13ee..e139889 100644
> > --- a/drivers/net/mvpp2/meson.build
> > +++ b/drivers/net/mvpp2/meson.build
> > @@ -3,7 +3,7 @@
> > # Copyright(c) 2018 Semihalf.
> > # All rights reserved.
> >
> > -path = run_command('printenv', 'LIBMUSDK_PATH').stdout().strip()
> > +path = get_option('lib_musdk_dir')
> > lib_dir = path + '/lib'
> > inc_dir = path + '/include'
> >
> > diff --git a/meson_options.txt b/meson_options.txt
> > index 1a674aa..c843278 100644
> > --- a/meson_options.txt
> > +++ b/meson_options.txt
> > @@ -8,6 +8,8 @@ option('include_subdir_arch', type: 'string', value: '',
> > description: 'subdirectory where to install arch-dependent headers')
> > option('kernel_dir', type: 'string', value: '',
> > description: 'path to the kernel for building kernel modules')
> > +option('lib_musdk_dir', type: 'string', value: '',
> > + description: 'path to the MUSDK library installation directory')
> > option('machine', type: 'string', value: 'native',
> > description: 'set the target machine type')
> > option('max_lcores', type: 'string', value: '128',
> > --
> > 2.7.4
>
> Looks good. Are you ok with me just squashing this into the original commit?
>
> /Bruce
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Sure, thanks.
--
- Tomasz Duszyński
next prev parent reply other threads:[~2018-04-19 12:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 9:45 Tomasz Duszynski
2018-04-19 12:05 ` Bruce Richardson
2018-04-19 12:06 ` Tomasz Duszynski [this message]
2018-04-19 12:15 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419120612.GA14506@sh \
--to=tdu@semihalf.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dima@marvell.com \
--cc=nsamsono@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).