From: Tomasz Duszynski <tdu@semihalf.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, nsamsono@marvell.com, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/mvpp2: fix build
Date: Fri, 20 Apr 2018 07:26:10 +0200 [thread overview]
Message-ID: <20180420052610.GA30666@sh> (raw)
In-Reply-To: <20180419160934.24577-1-thomas@monjalon.net>
On Thu, Apr 19, 2018 at 06:09:34PM +0200, Thomas Monjalon wrote:
> The iterator RTE_ETH_FOREACH_DEV (added in below commit)
> requires to enable experimental APIs.
>
> Fixing also the config option rename in the build test.
>
> Fixes: 8728ccf37615 ("fix ethdev ports enumeration")
> Fixes: fe93968722af ("net/mrvl: rename PMD as mvpp2")
>
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> devtools/test-build.sh | 2 +-
> drivers/net/mvpp2/Makefile | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/devtools/test-build.sh b/devtools/test-build.sh
> index 3362edcc5..28e032417 100755
> --- a/devtools/test-build.sh
> +++ b/devtools/test-build.sh
> @@ -202,7 +202,7 @@ config () # <directory> <target> <options>
> test -z "$LIBMUSDK_PATH" || \
> sed -ri 's,(PMD_MRVL_CRYPTO=)n,\1y,' $1/.config
> test -z "$LIBMUSDK_PATH" || \
> - sed -ri 's,(MRVL_PMD=)n,\1y,' $1/.config
> + sed -ri 's,(MVPP2_PMD=)n,\1y,' $1/.config
> build_config_hook $1 $2 $3
>
> # Explicit enabler/disabler (uppercase)
> diff --git a/drivers/net/mvpp2/Makefile b/drivers/net/mvpp2/Makefile
> index 2383ec18c..db4576f9c 100644
> --- a/drivers/net/mvpp2/Makefile
> +++ b/drivers/net/mvpp2/Makefile
> @@ -27,6 +27,7 @@ CFLAGS += -I$(LIBMUSDK_PATH)/include
> CFLAGS += -DMVCONF_TYPES_PUBLIC
> CFLAGS += -DMVCONF_DMA_PHYS_ADDR_T_PUBLIC
> CFLAGS += $(WERROR_FLAGS)
> +CFLAGS += -DALLOW_EXPERIMENTAL_API
> CFLAGS += -O3
> LDLIBS += -L$(LIBMUSDK_PATH)/lib
> LDLIBS += -lmusdk
> --
> 2.16.2
>
Looks good:
Acked-by: Tomasz Duszynski <tdu@semihalf.com>
--
- Tomasz Duszyński
prev parent reply other threads:[~2018-04-20 5:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 16:09 Thomas Monjalon
2018-04-19 20:52 ` Ferruh Yigit
2018-04-20 9:10 ` Thomas Monjalon
2018-04-20 5:26 ` Tomasz Duszynski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420052610.GA30666@sh \
--to=tdu@semihalf.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=nsamsono@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).