From: Olivier Matz <olivier.matz@6wind.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: thomas@monjalon.net, jerin.jacob@caviumnetworks.com,
hemant.agrawal@nxp.com, beilei.xing@intel.com,
rasesh.mody@cavium.com, harish.patil@cavium.com,
jianbo.liu@arm.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] drivers: cleanup unnecessary global variables
Date: Mon, 23 Apr 2018 11:00:09 +0200 [thread overview]
Message-ID: <20180423090009.vpzv74r3uknh4jnx@platinum> (raw)
In-Reply-To: <20180419185159.11266-1-pbhagavatula@caviumnetworks.com>
On Fri, Apr 20, 2018 at 12:21:59AM +0530, Pavan Nikhilesh wrote:
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
> drivers/bus/dpaa/base/fman/netcfg_layer.c | 5 -----
> drivers/bus/dpaa/base/qbman/bman_driver.c | 4 ++--
> drivers/bus/dpaa/base/qbman/qman.c | 2 +-
> drivers/bus/dpaa/base/qbman/qman_driver.c | 4 ++--
> drivers/bus/dpaa/base/qbman/qman_priv.h | 1 -
> drivers/bus/dpaa/dpaa_bus.c | 2 +-
> drivers/bus/fslmc/qbman/qbman_portal.c | 3 +--
> drivers/bus/fslmc/qbman/qbman_portal.h | 1 -
> drivers/net/i40e/i40e_flow.c | 2 +-
> drivers/net/qede/base/bcm_osal.c | 2 +-
> drivers/raw/skeleton_rawdev/skeleton_rawdev.c | 2 +-
> lib/librte_net/net_crc_neon.h | 4 ++--
> 12 files changed, 12 insertions(+), 20 deletions(-)
[...]
> diff --git a/lib/librte_net/net_crc_neon.h b/lib/librte_net/net_crc_neon.h
> index 63fa1d4a1..cb3da72ed 100644
> --- a/lib/librte_net/net_crc_neon.h
> +++ b/lib/librte_net/net_crc_neon.h
> @@ -21,8 +21,8 @@ struct crc_pmull_ctx {
> uint64x2_t rk7_rk8;
> };
>
> -struct crc_pmull_ctx crc32_eth_pmull __rte_aligned(16);
> -struct crc_pmull_ctx crc16_ccitt_pmull __rte_aligned(16);
> +static struct crc_pmull_ctx crc32_eth_pmull __rte_aligned(16);
> +static struct crc_pmull_ctx crc16_ccitt_pmull __rte_aligned(16);
>
> /**
Not sure it will still work after that.
>From what I see, these global variables are initialized once in
rte_net_crc_neon_init, and used as a const parameter in
crc32_eth_calc_pmull().
Changing them to static will create an instance of these variables for
each included file, which is not what we want.
I think that the proper way to solve it would be to add the definition
in a new .c file, and only have a declaration in the .h.
An even better way would be to make variable const and initialize it
with its content. It could even enhance performance. Something like:
net_crc_neon.h:
static const struct crc_pmull_ctx crc32_eth_pmull = {
<values...>
} __rte_aligned(16);
static const struct crc_pmull_ctx crc16_ccitt_pmull = {
<values...>
} __rte_aligned(16);
next prev parent reply other threads:[~2018-04-23 9:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 18:51 Pavan Nikhilesh
2018-04-19 21:18 ` Ferruh Yigit
2018-04-20 6:50 ` Shreyansh Jain
2018-04-23 9:00 ` Olivier Matz [this message]
2018-04-25 15:52 ` Pavan Nikhilesh
2018-04-26 8:29 ` Olivier Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180423090009.vpzv74r3uknh4jnx@platinum \
--to=olivier.matz@6wind.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=harish.patil@cavium.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jianbo.liu@arm.com \
--cc=pbhagavatula@caviumnetworks.com \
--cc=rasesh.mody@cavium.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).