From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] devtools: add test script for meson builds
Date: Mon, 28 May 2018 14:20:23 +0100 [thread overview]
Message-ID: <20180528132023.GB8752@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <1832507.I1aXYWBlau@xps>
On Mon, May 28, 2018 at 12:26:24PM +0200, Thomas Monjalon wrote:
> 28/05/2018 11:33, Bruce Richardson:
> > On Sat, May 26, 2018 at 11:32:53AM +0200, Thomas Monjalon wrote:
> > > 25/05/2018 17:18, Bruce Richardson:
> > > > On Fri, May 25, 2018 at 04:51:58PM +0200, Thomas Monjalon wrote:
> > > > > +cd $(dirname $(readlink -m $0))/..
> > > > > +
> > > > I don't think we should force the builds to be always put into the base
> > > > directory. Instead of using cd, I think we should instead capture the base
> > > > directory path and pass that to meson.
> > >
> > > OK to not force the directory.
> > > You want to build in the current directory?
> > > If yes, we can just remove this "cd" and no need to pass a base directory
> > > to meson.
> >
> > We would need to pass the base to meson, because otherwise meson assumes
> > the top-level meson.build file is in the current directory, i.e. calling
> > "meson build-dir" is the same as "meson . build-dir". If we want to allow
> > using this script from other places on filesystem, we need to either "cd"
> > to the base dir as you do now, or else explicitly pass in the basedir. The
> > latter I think is a better option as it would allow building from any
> > location on the filesystem.
>
> I agree.
>
> I don't understand the meson syntax:
> meson [ options ] [ source directory ] [ build directory ]
> If there is only one argument, it is the build directory?
>
> I could send a v5 to add the source directory in the meson command.
> It would be:
> srcdir=$(dirname $(readlink -m $0))/..
> $MESON $options $srcdir $builddir
>
Yes, exactly.
>
> > > > > +load_config () +{ + reset_env + . $(dirname $(readlink -e
> > > > > $0))/load-devel-config + MESON=${MESON:-meson} +}
> > > > Why does this need to be done each time?
> > >
> > > Because the config could be different for each build (see above).
> > >
> > How would it be different, it's the same command called with the same
> > environment each time?
>
> No, the idea is to adapt the environment to the build target. As an
> example, the dependencies can be different for 32-bit and 64-bit.
>
I would hope that dependency detection should solve that, but since you
already have support for that in existing build script via environment
vars, I have no objection to leveraging that in the meson scripts. Overall,
though, I'd prefer to ensure that the detection works so that everyone only
needs one environment setup in order to get all builds working
simultaneously.
/Bruce
next prev parent reply other threads:[~2018-05-28 13:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 12:32 [dpdk-dev] [PATCH] " Bruce Richardson
2018-04-24 14:36 ` Bruce Richardson
2018-04-24 14:38 ` Bruce Richardson
2018-05-25 14:51 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2018-05-25 15:18 ` Bruce Richardson
2018-05-26 9:32 ` Thomas Monjalon
2018-05-28 9:33 ` Bruce Richardson
2018-05-28 10:26 ` Thomas Monjalon
2018-05-28 13:20 ` Bruce Richardson [this message]
2018-05-29 10:38 ` Thomas Monjalon
2018-05-29 10:59 ` Bruce Richardson
2018-05-26 9:54 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2018-05-26 11:21 ` [dpdk-dev] [PATCH v4] " Thomas Monjalon
2018-05-28 9:39 ` Bruce Richardson
2018-05-29 14:42 ` [dpdk-dev] [PATCH v5] " Thomas Monjalon
2018-05-29 14:58 ` Richardson, Bruce
2018-05-29 15:37 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180528132023.GB8752@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).